Drawing Frames arround Widgets

sandro4912

With the frames my App looks like this:

How can i get rid of the spacings from the frame to the widgets?

I thought it was in the layout and setSpacing(0); whould remove it but it doesn't

The code so far:

private:
    LcdDisplay *mLcdDisplayMinesLeft;
    LcdDisplay *mLcdDisplayElapsedTime;
    SmileyPushButton *mSmileyPushButton;
    Minefield *mMinefield;

    QFrame *mTopFrame;
    QFrame *mBottomFrame;
    QFrame *mMainFrame;

Game::Game(QWidget *parent) :
    QWidget(parent),
    mLcdDisplayMinesLeft{ new LcdDisplay{ mDefaultMines} },
    mLcdDisplayElapsedTime{ new LcdDisplay },
    mSmileyPushButton{ new SmileyPushButton },
    mMinefield{ new Minefield{
                mDefaultFieldWidth,
                mDefaultFieldHeight,
                mDefaultMines }},
    mTopFrame{ new QFrame },
    mBottomFrame{ new QFrame },
    mMainFrame{ new QFrame }
{
    mMainFrame->setFrameStyle(QFrame::Panel | QFrame::Raised);
    mMainFrame->setLineWidth(3);

    mTopFrame->setFrameStyle(QFrame::Panel | QFrame::Sunken);
    mTopFrame->setLineWidth(3);

    mBottomFrame->setFrameStyle(QFrame::Panel | QFrame::Sunken);
    mBottomFrame->setLineWidth(3);

    auto topLayout = new QHBoxLayout;
    topLayout->setSpacing(0);
    topLayout->addWidget(mLcdDisplayMinesLeft);
    topLayout->addStretch();
    topLayout->addWidget(mSmileyPushButton);
    topLayout->addStretch();
    topLayout->addWidget(mLcdDisplayElapsedTime);
    mTopFrame->setLayout(topLayout);

    auto bottomLayout = new QHBoxLayout;
    bottomLayout->setSpacing(0);
    bottomLayout->addWidget(mMinefield);
    mBottomFrame->setLayout(bottomLayout);

    auto mainLayout = new QVBoxLayout;
    mainLayout->setSpacing(0);
    mainLayout->addWidget(mTopFrame);
    mainLayout->addWidget(mBottomFrame);

    mMainFrame->setLayout(mainLayout);

    auto layout = new QVBoxLayout;
    layout->setSpacing(0);
    layout->addWidget(mMainFrame);

    setLayout(layout);
}

mrjj

@sandro4912
Hi
Looking good. :)

The space can most likely be removed with

layout->setContentsMargins(0,0,0,0);

all layout have a default values of 9 for all 4 sides

sandro4912

@mrjj

Appling the margin i get this:

This is almost perfect. Just one nitpick.

The Top and Bottom frame seem to touch each other without any spae inbetween. Any change to add a space like between the outside frame and the inside frames?

The code now looks like this:

    auto topLayout = new QHBoxLayout;
    topLayout->setSpacing(0);
    topLayout->setContentsMargins(0,0,0,0);
    topLayout->addWidget(mLcdDisplayMinesLeft);
    topLayout->addWidget(mSmileyPushButton);
    topLayout->addWidget(mLcdDisplayElapsedTime);
    mTopFrame->setLayout(topLayout);

    auto bottomLayout = new QHBoxLayout;
    bottomLayout->setSpacing(0);
    bottomLayout->setContentsMargins(0,0,0,0);
    bottomLayout->addWidget(mMinefield);
    mBottomFrame->setLayout(bottomLayout);

    auto mainLayout = new QVBoxLayout;
    mainLayout->setSpacing(0);
    mainLayout->addWidget(mTopFrame);
    mainLayout->addWidget(mBottomFrame);

    mMainFrame->setLayout(mainLayout);

    auto layout = new QVBoxLayout;
    layout->setSpacing(0);
    layout->setContentsMargins(0,0,0,0);
    layout->addWidget(mMainFrame);

    setLayout(layout);

sandro4912

I could solve the Issue by removing the Space 0 here:

auto mainLayout = new QVBoxLayout;
    //mainLayout->setSpacing(0);
    mainLayout->addWidget(mTopFrame);
    mainLayout->addWidget(mBottomFrame);

Which gives:

That looks pretty close to the original:

Although it looks like there is still some kind of space between the minefield and the frame? Can it be removed aswell?

mrjj

Hi
It looks very much like the original
How nostalgic :)

sandro4912

Yes the only Issue I still see is the remainig space between minefield and the bottomFrame.

mrjj

Hi
There ?
alt text

sandro4912

Yes in the original theres no space at all.

I already throw out the top frame for testing to see if it causes it but still same result.

mrjj

@sandro4912
Hi
Im not sure where that space comes from as it seems you have it to zero

auto bottomLayout = new QHBoxLayout;
bottomLayout->setSpacing(0);
bottomLayout->setContentsMargins(0,0,0,0);
bottomLayout->addWidget(mMinefield);
mBottomFrame->setLayout(bottomLayout);

Did you try to raise the margins to see if you then get more space there ?

sandro4912

This post is deleted!

sandro4912

@mrjj

Yes if i rais the margin these spaces get higher. Still is very weired that 0 still gives these gaps.

I run the game in KDE Neon and Windows 10. On both OS is the same behaviour.

J.Hilk

hi @sandro4912 ,

my guess is, that the margins come from the mainLayout. You only set the setContentsMargins to 0 inside the bottomLayout, but the insert that layout into the mainLayout which has its own contentMargins still != 0

sandro4912

@J-Hilk

No it still has the same Issue:

    auto topLayout = new QHBoxLayout;
    topLayout->setSpacing(0);
    topLayout->setContentsMargins(0,0,0,0);
    topLayout->addWidget(mLcdDisplayMinesLeft);
    topLayout->addWidget(mSmileyPushButton);
    topLayout->addWidget(mLcdDisplayElapsedTime);
    mTopFrame->setLayout(topLayout);

    auto bottomLayout = new QHBoxLayout;
    bottomLayout->setSpacing(0);
    bottomLayout->setContentsMargins(0,0,0,0);
    bottomLayout->addWidget(mMinefield);
    mBottomFrame->setLayout(bottomLayout);

    auto mainLayout = new QVBoxLayout;
    mainLayout->setSpacing(0);
    mainLayout->setContentsMargins(0,0,0,0);
    mainLayout->addWidget(mTopFrame);
    mainLayout->addWidget(mBottomFrame);

    mMainFrame->setLayout(mainLayout);

    auto layout = new QVBoxLayout;
    layout->setSpacing(0);
    layout->setContentsMargins(0,0,0,0);
    layout->addWidget(mMainFrame);

    setLayout(layout);

Result:

J.Hilk

@sandro4912
mmh, strange.

I'm out of easy ideas to try 😞
sry

mrjj

Hi
What about INSIDE minefield ?
Did you use layout there ?

sandro4912

Yes inside the Minfield I place the Cells like this in the constructor:

auto layout = new QGridLayout;
   layout->setSpacing(0);

   for(int i = 0; i < mCells.size(); ++i) {
       auto column = static_cast<int>(i %  mFieldWidth);
       auto row = static_cast<int>(i /  mFieldWidth);

       layout->addWidget(mCells[i], row, column);
   }

   setLayout(layout);

mrjj

@sandro4912

But you dont seem to call setContentsMargins(0,0,0,0);
so maybe that is the space ?

sandro4912

@mrjj said in Drawing Frames arround Widgets:

setContentsMargins(0,0,0,0);

thats it!

I thought i tryed it before but i think i tryed:

setContentsMargins(0,0,0,0);

and not

layout->setContentsMargins(0,0,0,0);