Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Qt Development
  3. General and Desktop
  4. How to use QNetworkAccessManager without leaking memory.
Forum Updated to NodeBB v4.3 + New Features

How to use QNetworkAccessManager without leaking memory.

Scheduled Pinned Locked Moved Solved General and Desktop
37 Posts 8 Posters 4.8k Views 2 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • C Christian Ehrlicher
    3 Jun 2020, 04:19

    @Q139 said in How to use QNetworkAccessManager without leaking memory.:

    If someone plans to use it as ddos code it will probably flood your own memory up instead.

    No it won't - there is no leak in this code anymore.
    The disconnect() is not needed though.

    Q Offline
    Q Offline
    Q139
    wrote on 3 Jun 2020, 09:06 last edited by Q139 6 Mar 2020, 09:20
    #21

    I still get leak.
    alt text

    Could you check if application output gives SSL error while connecting to https site?
    I also had to install openSSL in addition to get it working, maybe it is related to that.
    And while tested on ubuntu got no leak , but it had SSL errors in app output.
    Got SSL for win7 and win10 from here, the lite edition, maybe that component causes problems.

    C 1 Reply Last reply 5 Jun 2020, 15:47
    0
    • B Bonnie
      3 Jun 2020, 02:28

      @Q139 Actually, I don't get a increasing memory while testing the last and the previous code of yours.
      I wonder if it needs to be tested with a url that have a big size of reply data...
      I'm using Qt 5.12 though...

      Q Offline
      Q Offline
      Q139
      wrote on 3 Jun 2020, 09:19 last edited by
      #22

      @Bonnie Used invalid url text , like "test" also and got leak.

      1 Reply Last reply
      0
      • Q Offline
        Q Offline
        Q139
        wrote on 4 Jun 2020, 11:49 last edited by Q139 6 Apr 2020, 11:52
        #23

        Install openSSL on Windows 7 or 10 and see if the app below leaks memory.

        Windows ssl libraries site
        direct link to download-Win64 OpenSSL v1.1.1g Light

        Project file

        1 Reply Last reply
        0
        • Q Offline
          Q Offline
          Q139
          wrote on 5 Jun 2020, 08:21 last edited by Q139 6 May 2020, 08:34
          #24

          Current solution to use QNetworkAcessManager 50 times:
          I thought maybe using just once and deleting gives overhead.
          This way it goes to ~100mb and back to ~20mb all the time, instead of gb+

          
          int qnamUses=0;
          QNetworkAccessManager *qnam=new QNetworkAccessManager;
          QNetworkReply *reply;
          
          void Form::startRequest()
          {
              qnamUses++;
              if(qnamUses>50){
                      qnam->deleteLater();
          
                qnam=new QNetworkAccessManager;
              }
          
              reply = qnam->get(QNetworkRequest(QUrl("www.microsoft.com")));
              connect(reply, &QNetworkReply::finished, this, &Form::httpFinished);
          }
          
          void Form::httpFinished()
          {
            //  qnam.clearAccessCache();
              //qnam->deleteLater();
              reply->deleteLater();
              QTimer::singleShot(0, this, &Form::startRequest);
          }
          
          
          J 1 Reply Last reply 5 Jun 2020, 08:27
          0
          • Q Q139
            5 Jun 2020, 08:21

            Current solution to use QNetworkAcessManager 50 times:
            I thought maybe using just once and deleting gives overhead.
            This way it goes to ~100mb and back to ~20mb all the time, instead of gb+

            
            int qnamUses=0;
            QNetworkAccessManager *qnam=new QNetworkAccessManager;
            QNetworkReply *reply;
            
            void Form::startRequest()
            {
                qnamUses++;
                if(qnamUses>50){
                        qnam->deleteLater();
            
                  qnam=new QNetworkAccessManager;
                }
            
                reply = qnam->get(QNetworkRequest(QUrl("www.microsoft.com")));
                connect(reply, &QNetworkReply::finished, this, &Form::httpFinished);
            }
            
            void Form::httpFinished()
            {
              //  qnam.clearAccessCache();
                //qnam->deleteLater();
                reply->deleteLater();
                QTimer::singleShot(0, this, &Form::startRequest);
            }
            
            
            J Offline
            J Offline
            jsulm
            Lifetime Qt Champion
            wrote on 5 Jun 2020, 08:27 last edited by
            #25

            @Q139 said in How to use QNetworkAccessManager without leaking memory.:

            qnam=new QNetworkAccessManager;

            Why do you create QNetworkAccessManager instance for each request? One can handle many requests...

            https://forum.qt.io/topic/113070/qt-code-of-conduct

            Q 1 Reply Last reply 5 Jun 2020, 08:30
            0
            • J jsulm
              5 Jun 2020, 08:27

              @Q139 said in How to use QNetworkAccessManager without leaking memory.:

              qnam=new QNetworkAccessManager;

              Why do you create QNetworkAccessManager instance for each request? One can handle many requests...

              Q Offline
              Q Offline
              Q139
              wrote on 5 Jun 2020, 08:30 last edited by
              #26

              @jsulm For 50 requests , then schedule for deletion. to prevent memory usage growth.
              Maybe i am using something incorrectly.

              1 Reply Last reply
              0
              • S Offline
                S Offline
                SGaist
                Lifetime Qt Champion
                wrote on 5 Jun 2020, 08:35 last edited by SGaist 6 May 2020, 08:35
                #27

                You never reset qnamUses. Therefore after 51 requests, you recreate your qnam object for every request.

                Interested in AI ? www.idiap.ch
                Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

                1 Reply Last reply
                0
                • Q Offline
                  Q Offline
                  Q139
                  wrote on 5 Jun 2020, 08:36 last edited by Q139 6 May 2020, 08:41
                  #28

                  Reset was fixed in test.
                  Is there a way to use single instance of QNetworkAccessManager for 10k+ times without drastic memory usage growth?

                  1 Reply Last reply
                  0
                  • Q Q139
                    3 Jun 2020, 09:06

                    I still get leak.
                    alt text

                    Could you check if application output gives SSL error while connecting to https site?
                    I also had to install openSSL in addition to get it working, maybe it is related to that.
                    And while tested on ubuntu got no leak , but it had SSL errors in app output.
                    Got SSL for win7 and win10 from here, the lite edition, maybe that component causes problems.

                    C Offline
                    C Offline
                    Christian Ehrlicher
                    Lifetime Qt Champion
                    wrote on 5 Jun 2020, 15:47 last edited by
                    #29

                    @Q139 said in How to use QNetworkAccessManager without leaking memory.:

                    I still get leak.

                    The Task manager is no tool to measure a memory leak!

                    Is there a way to use single instance of QNetworkAccessManager for 10k+ times without drastic memory usage growth?

                    Yes, simply use it.

                    Qt Online Installer direct download: https://download.qt.io/official_releases/online_installers/
                    Visit the Qt Academy at https://academy.qt.io/catalog

                    Q 1 Reply Last reply 5 Jun 2020, 15:56
                    1
                    • C Christian Ehrlicher
                      5 Jun 2020, 15:47

                      @Q139 said in How to use QNetworkAccessManager without leaking memory.:

                      I still get leak.

                      The Task manager is no tool to measure a memory leak!

                      Is there a way to use single instance of QNetworkAccessManager for 10k+ times without drastic memory usage growth?

                      Yes, simply use it.

                      Q Offline
                      Q Offline
                      Q139
                      wrote on 5 Jun 2020, 15:56 last edited by Q139 6 May 2020, 15:57
                      #30

                      @Christian-Ehrlicher It ends with app filling memory and crashing if simply using.

                      C 1 Reply Last reply 5 Jun 2020, 16:53
                      0
                      • Q Q139
                        5 Jun 2020, 15:56

                        @Christian-Ehrlicher It ends with app filling memory and crashing if simply using.

                        C Offline
                        C Offline
                        Christian Ehrlicher
                        Lifetime Qt Champion
                        wrote on 5 Jun 2020, 16:53 last edited by
                        #31

                        @Q139 I still don't have a valid reproducer for this behavior...

                        Qt Online Installer direct download: https://download.qt.io/official_releases/online_installers/
                        Visit the Qt Academy at https://academy.qt.io/catalog

                        Q 1 Reply Last reply 6 Jun 2020, 07:52
                        0
                        • C Christian Ehrlicher
                          5 Jun 2020, 16:53

                          @Q139 I still don't have a valid reproducer for this behavior...

                          Q Offline
                          Q Offline
                          Q139
                          wrote on 6 Jun 2020, 07:52 last edited by Q139 6 Jun 2020, 07:54
                          #32

                          @Christian-Ehrlicher I tryed and it leaks on win 7 in vmware and win 10 native.
                          What version of Qt are you running? Did you also intall the openSSL?

                          This produces problem in my tests. Only solution i find is to delete QNetworkAccessManager after some period and recreate it.
                          @Q139 said in How to use QNetworkAccessManager without leaking memory.:

                          Install openSSL on Windows 7 or 10 and see if the app below leaks memory.

                          Windows ssl libraries site
                          direct link to download-Win64 OpenSSL v1.1.1g Light

                          Project file

                          1 Reply Last reply
                          0
                          • C Offline
                            C Offline
                            Christian Ehrlicher
                            Lifetime Qt Champion
                            wrote on 6 Jun 2020, 09:12 last edited by
                            #33

                            @Q139 said in How to use QNetworkAccessManager without leaking memory.:

                            Did you also intall the openSSL?

                            No need for ssl at all since your url ist http.

                            Qt Online Installer direct download: https://download.qt.io/official_releases/online_installers/
                            Visit the Qt Academy at https://academy.qt.io/catalog

                            1 Reply Last reply
                            0
                            • C Offline
                              C Offline
                              Christian Ehrlicher
                              Lifetime Qt Champion
                              wrote on 6 Jun 2020, 11:08 last edited by
                              #34

                              ´Please update the wait time between two requests to 100ms and see if the problem still persists. Looks like there is a race condition when the same url is queried very fast. But can't see the main reason for it currently.

                              Qt Online Installer direct download: https://download.qt.io/official_releases/online_installers/
                              Visit the Qt Academy at https://academy.qt.io/catalog

                              1 Reply Last reply
                              1
                              • Q Offline
                                Q Offline
                                Q139
                                wrote on 8 Jun 2020, 17:44 last edited by Q139 6 Aug 2020, 17:44
                                #35

                                Using 100ms and variable urls solves it.

                                1 Reply Last reply
                                0
                                • K Offline
                                  K Offline
                                  kevinzhwl
                                  wrote on 12 Jun 2020, 02:27 last edited by
                                  #36

                                  Helpful discussion for me ,thank eveyone
                                  Same situation with Qt 5.14.2 Mingw on Windows7 and Qt5.9.9 on MacOSX

                                  1 Reply Last reply
                                  0
                                  • T Offline
                                    T Offline
                                    tibalt
                                    wrote on 6 Sept 2022, 01:20 last edited by
                                    #37

                                    @Christian-Ehrlicher said in How to use QNetworkAccessManager without leaking memory.:

                                    ´Please update the wait time between two requests to 100ms and see if the problem still persists. Looks like there is a race condition when the same url is queried very fast. But can't see the main reason for it currently.

                                    Hi, we meet this bug on site. is this bug fixed in the newer versions?

                                    1 Reply Last reply
                                    0

                                    • Login

                                    • Login or register to search.
                                    • First post
                                      Last post
                                    0
                                    • Categories
                                    • Recent
                                    • Tags
                                    • Popular
                                    • Users
                                    • Groups
                                    • Search
                                    • Get Qt Extensions
                                    • Unsolved