help in QDirIterator to a text file

[Abrar]

I created a function but don't know why whole app is crashing. Plz help on that...
Code:

QString getTree(const QString &path) {
QDirIterator it(path, QDir::AllEntries | QDir::NoDotAndDotDot | QDir::NoSymLinks);

while (it.hasNext()) {
it.next();
if (it.fileInfo().isDir()) {
qDebug() << it.fileInfo().path();
getTree(it.filePath());
}

qDebug() << "\t" << it.filePath();
}
}

[JonB]

@Abrar
while (it.hasNext) {

I don't do C++, but shouldn't that be it.hasNext()?

[mpergand]

You return nothing, that's the cause.

@JonB
Your're right ofcourse, in fact it doesn"t even compile.

[Abrar]

@mpergand thanks a lot it's working

[Abrar]

@JonB Yes you are right.
That was my typing mistake.
@mpergand it was compiling.

[JonB]

@Abrar
Never type "your code", always copy & paste! That would save a fair proportion of questions/answers in the forum!

[Abrar]

@JonB thanks for your suggestion.

[saber]

@Abrar made a function that works .but problems is it takes a long time to make the text file (not enter every folder and get the name).it takes long time if the folder tree is complex.

i wonder how the tree package that @mrjj pointing is take fraction of the time to make that same text file.

here is the code.

int pat = 0;
QString strDir;
QString getFileFolderTree(const QString &path)
{
    
    // ├

    // └

    // │

    // ──


    pat++;

    QDir dir(path);
    //dir.setSorting(QDir::DirsFirst);
    //dir.setNameFilters(QStringList("*"));
    dir.setFilter(QDir::AllDirs | QDir::NoDotAndDotDot | QDir::NoSymLinks);
    QStringList dList = dir.entryList();
    for (int i = 0; i < dList.count(); ++i) {
        QString newPath = QString("%1/%2").arg(dir.absolutePath()).arg(dList.at(i));

        QString strPat = "├── ";
        for (int i = 1; i < pat; i++) {
            strPat.insert(0, "│   ");
        }

        if (i == dList.count() - 1) {
            int pos = strPat.count() - 4;
            strPat = strPat.replace(pos, 1, "└");
        }

        strDir.append(strPat + QDir(dList.at(i)).dirName() + "\n");

        getFileFolderTree(newPath);
    }

    pat--;

    dir.setFilter(QDir::Files | QDir::NoDotAndDotDot | QDir::NoSymLinks);
    QStringList fList = dir.entryList();
    for (int i = 0; i < fList.count(); i++) {

        QString strPat = "├── ";
        for (int j = 1; j < pat + 1; j++) {
            strPat.insert(0, "│   ");
        }

        if (i == fList.count() - 1) {
            strPat = strPat.replace(strPat.count() - 4, 1, "└");
        }

        strDir.append(strPat + fList[i] + "\n");
    }

//    QDirIterator it(path, QDir::AllEntries | QDir::NoDotAndDotDot | QDir::NoSymLinks | QDir::System);
//    while (it.hasNext()) {
//        it.next();
//        if (it.fileInfo().isDir()) {
//            qDebug() << it.fileInfo().path();
//            getFileFolderTree(it.filePath());
//        }
//        qDebug() << "\t" << it.filePath();
//    }

    //qDebug() << strDir;

    if (!strDir.count())
        strDir.append(".\n");

    QFile file("/home/abrar/Desktop/UI.txt");
    file.open(QIODevice::Text | QIODevice::ReadWrite | QIODevice::Truncate);
    QTextStream out(&file);
    out << strDir;
    file.close();


    return QString();
}

so i need some help to dicress the time to make the text file .
help! help! help!
thanks.

[JonB]

@saber
It shouldn't take long. But you don't say how many files/directories there are --- if it's thousands, it will take longer....

You should put debug statements in or run under debugger to discover just which part is taking the time if you expect anybody to be able to help you. Saying "help! help! help!" doesn't do it.

[saber]

@JonB
thanks.
as in my Linux system debuger is not working (i tried to fix), i can't test it.

[jsulm]

@saber You still can put some debug output in your code as @JonB suggested

[JonB]

@saber
If you mean your gdb is not working you should get it working.