Skip to content
  • 0 Votes
    4 Posts
    484 Views
    SGaistS

    @oblivioncth said in Help with Autotest for Gerrit submission:

    So I should just add the cases locally, ensure they test correctly, and then commit --amend & push the changed test file as part of the rest of my submission?

    That's correct yes.

  • QtQuick w/o widgets

    Unsolved Qt Contribution
    2
    0 Votes
    2 Posts
    2k Views
    SGaistS

    Hi,

    Since those are the same patches you should only target one branch. If it's the wrong one, don't worry it will be changed for you.

    In order to get them move forward, you should add reviewers that are concerned by your patches e.g. the module maintainers.

    One probable remark you will have is that your patch modifies several unrelated stuff so you should split them in order to ensure atomic changes e.g. one disables the item view part, another one the shortcut etc.

  • Pushing code for review

    Solved Qt Contribution
    15
    0 Votes
    15 Posts
    6k Views
    kshegunovK

    @SGaist
    Ok. Thank you!