Important: Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct
QtQuick w/o widgets
-
Hello,
I am trying to make a static build of QtQuick w/o widgets. Basically, after lots of modifications I partially succeeded, size of my app got smaller by 10MB.The question is: how do I get my changes get accepted into source code tree so they are not lost??
Changes for v5.6:
https://codereview.qt-project.org/154024
https://codereview.qt-project.org/154027
Changes for v5.7:
https://codereview.qt-project.org/154345
https://codereview.qt-project.org/154533How changes are proparagated from v5.6 to v5.7 and dev? Do I have to duplicate 'em, or maintainers automatically move these upward?
Thank You
-
Hi,
Since those are the same patches you should only target one branch. If it's the wrong one, don't worry it will be changed for you.
In order to get them move forward, you should add reviewers that are concerned by your patches e.g. the module maintainers.
One probable remark you will have is that your patch modifies several unrelated stuff so you should split them in order to ensure atomic changes e.g. one disables the item view part, another one the shortcut etc.
