closeEvent not running

SGaist

@DoubleFelix said in closeEvent not running:

That fixes that error, but now when I try to access elements, it says they don't exist.
self.my_button.clicked.connect(self.button_clicked) raises AttributeError: 'MyWindow' object has no attribute 'my_button'

Because my_button is something that belongs to the widget you created with designer ? If so it's your "window" variable that will have access to it.

DoubleFelix

I tried switching it to window and now the closeEvent still does nothing. I have this now:

class TexasHoldEmServerWindow(QWidget):
    def __init__(self):
        super(TexasHoldEmServerWindow, self).__init__()
        file = QFile(os.path.join(os.path.dirname(__file__), "window.ui"))
        file.open(QFile.ReadOnly)
        loader = QUiLoader()
        window = loader.load(file, self)
        self.window = loadUiFile(os.path.join(os.path.dirname(__file__), "window.ui"))
        layout = QVBoxLayout()
        layout.addWidget(window)
        self.setLayout(layout)

        self.window.start_game_button.clicked.connect(self.start_game)

    def closeEvent(self, event):
        print("PLS WORK")
        event.accept()

No errors, but it still doesn't run the function

SGaist

You should learn how inheritance work.

The proper way to add closeEvent handling to your Designer based class is to create a proper class i.e. you cannot use QUiLoader for that.

Since you are using Python, you can cheat and monkey patch your window object (you really should name your variable in a more meaningful way).

DoubleFelix

I do have a different name, I just named it differently for convenience. Although I guess it's less convenient than I thought.
I think I understand how inheritance works, I just don't know how I'd make this a "proper" class while still loading from a UI. I guess I just don't know what I need to inherit to get closeEvent().

JonB

@DoubleFelix
I don't mean to open up a box of asps, but...

Are you wedded to using QUiLoader/loadUiFile? This reads the .ui file generated from Qt Designer at runtime. It does not lend itself to subclassing, I think. And I believe that is what @SGaist is referring to

The proper way to add closeEvent handling to your Designer based class is to create a proper class i.e. you cannot use QUiLoader for that.

though I stand to be corrected.

If that is so, read on:

Most C++ Qt-ers will instead run the uic tool at compilation stage to generate the source code for a derived class, and use that in their project. This gives better control and compile-time help, IMHO.

You can do the same from Python, if you wish. Exact depends on whether you are PyQt5 or PySide2/6, but principle is the same. They supply an equivalent pyuic tool, to read a .ui file and produce a Python class from it, which you then import.

You can then subclass from that and define your own def closeEvent override.

Read Option A: Generating a Python class. And compare against your way, which is Option B: Loading it directly. See which you prefer.

Hope this helps.

DoubleFelix

I wasn't aware that is what uic did. I will try that out! Is there a tool that can auto convert this stuff or do I need to do it with every change?

JonB

@DoubleFelix
You do have run the pyuic every time you re-save the .ui file. When using C++ inside Creator the build process will do that automatically just before recompiling. I don't know whether there is anything similar when you use Python/PySide inside Creator, or whether you have to do it by hand. You should Google around.

DoubleFelix

Okay, I used pyuic5 -x window.ui -o window.py in the same directory as my window.py, but it gives me

Fatal error in launcher: Unable to create process using '"d:\python\python.exe"  "D:\Python\Scripts\pyuic5.exe" -x window.ui -o window.py': The system cannot find the file specified.

I'm not sure why it can't find the file. It doesn't work if I provide a direct file path either.

JonB

@DoubleFelix
I don't know. But have a Google for, say, pyuic5 Fatal error in launcher. I'm getting a few hits for you to look through. I think one possible suggestion was make sure everything is either 32- or 64-bit?

I think the pyuic on your PATH is a pyuic.bat, which runs python.exe to execute the pyuic5.exe. Try just running D:\Python\Scripts\pyuic5.exe directly and see whether you get an error from that?

DoubleFelix

I can only find an instance of pyuic5.bat in an anaconda folder, which I do not use. I was originally running pyuic5.exe, which returns the error I'm getting. Sorry for not elaborating better. As for 32-bit vs. 64-bit, I have verified everything is 64-bit.

SGaist

How did you install PySide2 exactly ?

DoubleFelix

With pip install pyside6 (I use PySide6 but I was told they were the same but with more features so I'm not sure it matters)

JonB

@DoubleFelix
PySide6 is not the same as PySide2, hence the 6 instead of 2! It's PySide for Qt6, instead of for Qt5. It's new. It does not yet have all features either.

And I notice you are running pyuic5, which I assume from the 5 is for Qt5.

Anyway, if it were me, I would scrub (uninstall, remove) anything Qt6/PySide6, and install Qt 5.15-ish (latest) + PySide2. (If the PySide2 comes with its own version of Qt5 [I don't know if that's how it works] that's fine, you don't need to do Qt5 separately.) And try again, at least to see how that fares in comparison.

SGaist

Is it your system pip ? Conda ?

DoubleFelix

@JonB I have uninstalled PySide6 and installed PySide2 and I get the same error.
@SGaist I don't think it is but I'm not sure how to tell

I attempted to use a mix of PySide6's normal features with PyQt5's uic module, but using

class TexasHoldEmServerWindow(QMainWindow):
    def __init__(self):
        super(TexasHoldEmServerWindow, self).__init__()
        uic.loadUi(os.path.join(os.path.dirname(__file__), "window.ui"), self)

Raises this error:

Exception has occurred: TypeError
('Wrong base class of toplevel widget', (<class 'topaz.server.texas_hold_em.server_window.TexasHoldEmServerWindow'>, 'QMainWindow'))

SGaist

Isn't the original base widget a QWidget ?

DoubleFelix

I tried using that too but it throws the same error

SGaist

Then what base class did you select in designer ?

DoubleFelix

The main window is QMainWindow but I have a layout inside the window (grid) which is QWidget. Inheriting either gives the same error however.

DoubleFelix

I was able to get it working by using pyuic6 window.ui -o window.py
I have this:

        super(TexasHoldEmServerWindow, self).__init__()
        self.window = Ui_MainWindow
        self.window.setupUi(self)

But setupUi() also needs to passed a parameter called MainWindow, but I'm not sure what to give it here.