Optimization source code

fender

Good day. I would like to ask advice from more experienced programmers.
Is it possible to shorten this code?

    QString skzh = "ABC-";
    QString format = "%0%1%2%3%4%5%6%7%8%9%10%11";
    QStringList tokens;
    if( !data_[highLimit].isEmpty()) tokens << data_[highLimit];
    if( !data_[pressure].isEmpty()) tokens << data_[pressure]+data_[modification];
    if( !data_[3].isEmpty()) tokens << data_[3];
    if( !data_[4].isEmpty()) tokens << data_[4]+data_[5] ;
    if( !data_[6].isEmpty()) tokens << data_[6];
    if( !data_[7].isEmpty()) tokens << data_[7];
    if( !data_[8].isEmpty()) tokens << data_[8];
    if( !data_[9].isEmpty()) tokens << data_[9];
    if( !data_[10].isEmpty()) tokens << data_[10];
    if( !data_[11].isEmpty()) tokens << data_[11];
    format = tokens.join("-");
    format
            .arg(data_[highLimit])  
            .arg(data_[pressure])      
            .arg(data_[modification]) 
            .arg(data_[3])            
            .arg(data_[4])             
            .arg(data_[5])            
            .arg(data_[6])            
            .arg(data_[7])            
            .arg(data_[8])             
            .arg(data_[9])             
            .arg(data_[10])           
            .arg(data_[11]);          

    QString final= skzh + format;
    return final;

Thank u

aha_1980

@fender sure.

the first question hereby is: what do you want to achive?

mrjj

Hi
Also, what is data_ ?
I mean vector ? fixed array ?

Also
data_[highLimit] << index 1
data_[pressure] << index 2 ? or ?

fender

@mrjj

mainwindow.h

   enum Field { highLimit, pressure, modification };
    QString dataString()const;
    QString data_[12];

@aha_1980
reduce code without losing functionality

sierdzio

@fender said in Optimization source code:

QString format = "%0%1%2%3%4%5%6%7%8%9%10%11";

That value is overwritten later in format = tokens.join("-"); so you can remove the string data and just leave QString format;.

format
.arg(data_[highLimit])
.arg(data_[pressure])
.arg(data_[modification])
.arg(data_[3])
.arg(data_[4])
.arg(data_[5])
.arg(data_[6])
.arg(data_[7])
.arg(data_[8])
.arg(data_[9])
.arg(data_[10])
.arg(data_[11]);

That code does not do anything, you can remove it completely.