Compiling Qt Creator in OS X: unixutils.cpp

[Apelsinsaft]

Hi,

While the fireworks lit up the sky outside, I celebrated new year's by trying to compile Qt Creator straight from git. The linker gave this error:

Undefined symbols for architecture x86_64:
"Utils::UnixUtils::fileBrowser(QSettings const*)", referenced from:
Core::FileUtils::showInGraphicalShell(QWidget*, QString const&) in fileutils.o
"Utils::UnixUtils::substituteFileBrowserParameters(QString const&, QString const&)", referenced from:
Core::FileUtils::showInGraphicalShell(QWidget*, QString const&) in fileutils.o
ld: symbol(s) not found for architecture x86_64

I resolved it by removing the "!macx" condition on line 95 in src/libs/utils/utils-lib.pri, so that unixutils.cpp gets compiled for OS X. Is my fix "correct"? If so, should this be considered a bug in the utils-lib.pri file? I suspect that it might not be that simple, since unixutils.cpp was explicitly disabled for macx, but not for other unixes. However, Qt Creator built with the change, and seems to be running OK.