QTableWidget and edit mode

[Vlad02]

Hi everybody. I have next problem. Work with QTableWidget. I have next code:

void Window::editItem()
{
    isEdit = !isEdit;
    if(isEdit){
        ui->editButton->setStyleSheet(StyleHelper::getButtonClickedStyle());
        ui->memoryTable->setCurrentCell(-1, -1);
        QTableWidgetItem *item;
        for(int row = 0; row < ui->memoryTable->rowCount(); row++){
            for(int col = 0; col < ui->memoryTable->columnCount(); col++){
                item = ui->memoryTable->item(row, col);
                item->setFlags(item->flags() | Qt::ItemIsEditable);
                if(item){
                    ui->memoryTable->openPersistentEditor(item);
                }
            }
            if(!secFunc->getIsBigMemory())
                break;
        }
        ui->memoryTable->setCurrentCell(0, 0);
    } else {
        ui->editButton->setStyleSheet(StyleHelper::getButtonDefaultStyle());
        for(int row = 0; row < ui->memoryTable->rowCount(); row++){
            for(int col = 0; col < ui->memoryTable->columnCount(); col++){
                QTableWidgetItem *item = ui->memoryTable->item(row, col);
                item->setFlags(item->flags() & ~Qt::ItemIsEditable);
                if(item){
                    ui->memoryTable->closePersistentEditor(item);
                }
            }
        }
        ui->memoryTable->clearFocus();
    }
}

In edit mode text in cells highlighted in blue color how in next image:

How can I remove this selection and don't lose the ability to change the text in cells?

[JonB]

@Vlad02
Maybe this just shows that when the QTextEdit editor widget is created it has its content selected? You might have to set a timer to deselect content after a short time delay? Unless someone suggests better.

[mpergand]

@Vlad02
Looks like the selection mode is MultiSelection
Try:
tableWidget->setSelectionMode(QAbstractItemView::SingleSelection);

[Vlad02]

@mpergand This is not work in edit mode

[Vlad02]

@JonB Can you show what you mean?

[JonB]

@Vlad02
The sort of thing I have in mind is: I do not think you can access the editing widget created during QAbstractItemView::openPersistentEditor(). That means you would have to create your own QStyledItemDelegate for QAbstractItemView::setItemDelegate(QAbstractItemDelegate *delegate). You would have that create and return a QTextEdit for QAbstractItemDelegate::createEditor(). If that still marks its content as selected upon initial display, then you would put it a short QTimer to deselect the content just after it is made visible.

Could you at least confirm that what you are seeing is just a selection which can be removed? From the picture you show, confirm that if you click into (each of) those blue 00 cells the text becomes unselected and the blue disappears? And stays disappeared even if you click into another cell?

If I have time this morning I might give it a try to show code. It's a bit of work all for the sake of not wanting what appears to be a default selection, but it may be what you have to do.

[Vlad02]

@JonB
Okay, I will wait your example. Thanks!

[JonB]

@Vlad02 said in QTableWidget and edit mode:

Okay, I will wait your example. Thanks!

LOL, you are optimistic! :) OK, I will start playing with it now....

One question. Your code shows you making every cell in every row and column editable, but the picture only shows one row having been made editable/showing selected contents. Is that really the case?? (Because if so something else is going on.) Or does the picture come from code really making just one row editable?

And one further thing. The normal behaviour is to mark all cells as being editable, not switch that on and off, but only to go into edit mode on one cell at a time, when you click into that cell to edit. At that point it changes into a QTextEdit, and changes back again to plain text when finished editing. But you want an interface where a whole row goes into edit mode at a time, is that the requirement?

[Vlad02]

@JonB I check flag

if(!secFunc->getIsBigMemory())

If condition is true, other rows not editable.
Regarding editing. The matter is that I have 2 modes: in one all lines are available, in another only one. And yes, I need to change the values ​​of each cell in a row. The bottom line is that I need to be able to open the editor of all cells by pressing a key from the keyboard, and not by double clicking the mouse

It may be clearer if I say that this is conditionally the memory of a certain processor, into which I write commands to perform tasks (I write an emulator)

[Vlad02]

@JonB
By the way, I have custom delegate:

QWidget *MyDelegate::createEditor(QWidget *parent, const QStyleOptionViewItem &option, const QModelIndex &index) const
{
    QLineEdit *editor = new QLineEdit(parent);     
    editor->setStyleSheet(StyleHelper::getEditorItemStyle());   
    connect(editor, &QLineEdit::editingFinished, this, &MyDelegate::commitAndCloseEditor);
    (void) option;      
    (void) index;       
    return editor;
}

void MyDelegate::setEditorData(QWidget *editor, const QModelIndex &index) const
{
    QLineEdit *lineEdit = qobject_cast<QLineEdit*>(editor);
    lineEdit->setInputMask("HH");              
    lineEdit->setText(index.data().toString());
}

void MyDelegate::setModelData(QWidget *editor, QAbstractItemModel *model, const QModelIndex &index) const
{
    QLineEdit *lineEdit = qobject_cast<QLineEdit*>(editor);
    model->setData(index, lineEdit->text());
}

void MyDelegate::commitAndCloseEditor()
{
    QLineEdit *editor = qobject_cast<QLineEdit *>(sender());
    emit commitData(editor);
    emit closeEditor(editor);
}

Maybe it's help you :)

[JonB]

@Vlad02 said in QTableWidget and edit mode:

Maybe it's help you :)

That may save me all the work I am halfway through!

Since you already have the createEditor() delegate written, all I want you to do there is something like:

QLineEdit *editor = new QLineEdit(parent); 
QTimer::singleShot(100, this, [editor]() { editor->deselect(); } );

That's the idea, does it work? [I have tried this now under Ubuntu 22.04, Qt 5.15, and it works as intended.]

[Vlad02]

@JonB Hm, I have error that QLineEdit has no member named textCursor. I use Qt 5.6.0. Could there not be such a function or method?

[JonB]

@Vlad02
Re-read my code above, I corrected that (it was for QTextEdit not QLineEdit), it's even simpler now :)

[Vlad02]

@JonB Huh, I'm sorry, I have some problems :`)

I work on windows 10, may be related to this?

[JonB]

@Vlad02
This is because you are Qt 5.6 (why such an old version??). I still think you're supposed to have

void QTimer::singleShot(int msec, const QObject *context, Functor functor)

and I thought my lambda would match as a Functor? Sigh. Do you really need to stick on Qt 5.6, it's not a good idea...?

You will have to try something like:

QTimer::singleShot(100, [editor]() { editor->deselect(); } );

But I suppose that gives the same error message??

You need a lambda here really to pass the editor in context. I never used Qt 5.6 and I don't know what is acceptable for that, maybe an [old!] expert will see and comment...?

[Vlad02]

@JonB
No, this is work, thanks!!!

But what if, for example, I need to select the text of only the currently selected cell, but at the same time put everything in edit mode? And while doing this, I want to switch between cells through the Tab key. And when you switch to a cell, so that the text is highlighted completely in it. Is it difficult to implement?

I highlighted this with the mouse, but I would like this when switching between cells via Tab

[JonB]

@Vlad02 said in QTableWidget and edit mode:

I need to select the text of only the currently selected cell, but at the same time put everything in edit mode?

For that one, in createEditor() detect whether index refers to "the currently selected cell" and do not do the singleShot() to clear the selection for that one.

You are asking me too many questions now! I don't know what the Tab key does, I don't know whether that highlights all the content of the new cell or not, and I don't know whether you want the opposite behaviour! I have shown a possible approach using a delay timer to deselect/select in a QLineEdit, maybe you need something like this in your Tab case too. You will have to play.

[Vlad02]

@JonB Okay, thanks so much! You helped me a lot :) Have a good day!

[JonB]

@Vlad02
If necessary explain exactly what you want now, because I don't understand from what you wrote. So far as I know the Tab key will move to edit the next editable field, does it do that? If then you want it to select or deselect the whole of the new cell's edit's content, I think the QLineEdit will get some "focus" event or signal? Maybe you could put something on that to then do de/selection, if that is the issue?

[Vlad02]

@JonB said in QTableWidget and edit mode:

Tab key will move to edit the next editable field

Yes, you're right.

Just for convenience, it would be nice, when switching to each next cell, to select all the text in it in order to write something new, and not erase the old one and then write down the new one, that's what I'm talking about. And in the previous cell, just the new text remains and that's it, without any selections

P.S. Sorry for lengthy responses, I can write every 10 minutes :)