Merge two pieces of code

john_hobbyist

Traceback (most recent call last):
  File "code.py", line 653, in <module>
    window = OrthoView()
  File "code.py", line 279, in __init__
    self.plotCanvas = MyMplCanvas(self)
  File "code.py", line 109, in __init__
    super().__init__(parent)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5agg.py", line 21, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5.py", line 214, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 1722, in __init__
    figure.set_canvas(self)
AttributeError: 'OrthoView' object has no attribute 'set_canvas'

SGaist

You do realize that your OrthoView does not have such a method ? That its base class (QMainWindow) does not either ?

Therefore since you are taking your code from another project, you might want to check the code of said project for that method.

mrjj

@john_hobbyist said in Merge two pieces of code:

set_canvas

But this is not related to the RubberBand thing. ?

if i look in the ORG project
https://github.com/kklmn/OrthoView/blob/master/OrthoView.py

there is no such method?
So did you add it or where does it come from ?

john_hobbyist

@SGaist, @mrjj : I have posted the code previously. But again I got the code form github repository and I inserted inside the code for rubberband (all those I have posted in my initial post) I execute the python code and again the same error.... Any ideas??

mrjj

@john_hobbyist
Hi
the
'MyMplCanvas' object has no attribute 'rubberBand'
or the
object has no attribute 'set_canvas'

john_hobbyist

Hi, sorry, what should I do?

mrjj

@john_hobbyist

hi
fix the error.
Tell what line number and what it says.

john_hobbyist

@mrjj Hi, for the posted source code above...this is the error:

Traceback (most recent call last):
  File "code.py", line 513, in <module>
    window = OrthoView()
  File "code.py", line 279, in __init__
    self.plotCanvas = MyMplCanvas(self)
  File "code.py", line 113, in __init__
    super().__init__(parent)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5agg.py", line 21, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5.py", line 214, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 1722, in __init__
    figure.set_canvas(self)
AttributeError: 'OrthoView' object has no attribute 'set_canvas'

mrjj

Hi

Ok so it has NOTHING to do with the rubberband at all.
Even before you try to insert that, the app was not working.

So it complains about
figure.set_canvas(self)

So perhaps you didnt copy the figure class etc ?

john_hobbyist

@mrjj I have copied everything from the github repository. The only small modification I did in rubberband code is that I changed this part:

import sys

from PySide2.QtCore import QRect
from PySide2.QtCore import QSize
from PySide2.QtWidgets import QWidget
from PySide2.QtWidgets import QRubberBand
from PySide2.QtWidgets import QApplication

to this one:

import rubberband
import sys


from PyQt5 import QtWidgets
from PyQt5 import QtCore 


from PyQt5.QtWidgets import * 
from PyQt5 import QtCore, QtGui
from PyQt5.QtGui import * 
from PyQt5.QtCore import *

Could this be the source of the strange errors?

SGaist

Rather than just copying it, did you try to run the application from the repo as is ?

john_hobbyist

@SGaist Hi,yes, it runs without any problems!

SGaist

Then compare it to your version and see where the difference lies.

john_hobbyist

@SGaist : I have tried any possible solution! Is there any other way to select an area on image apart from rubberband?

JonB

@john_hobbyist
I don't think so, rubber band is the right way to do it. Even if there were another way, like just clicking, I presume you would face the same issues getting it right as you are now for rubber band.

john_hobbyist

I try for many hours to incorporate another code in the code from the github repository. I have fixed some errors (because it was written basically for PyQt4). But I cannot fix this error:

Traceback (most recent call last):
  File "code_2.py", line 333, in <module>
    screen_pixmap = QtGui.QPixmap.grabWidget(app.desktop()) 
NameError: name 'QtGui' is not defined
Segmentation fault (core dumped)

I change the QtWidgets to QtGui and I get this error:

Traceback (most recent call last):
File "code_2.py", line 333, in <module>
  screen_pixmap = QtWidgets.QPixmap.grabWidget(app.desktop()) 
AttributeError: module 'PyQt5.QtWidgets' has no attribute 'QPixmap'
Segmentation fault (core dumped)

Any ideas??

mrjj

Hi
Are you using Qtpy5 ?

I think its
from PyQt5.QtGui import QPixmap

https://www.pythonguis.com/faq/adding-images-to-pyqt5-applications/

john_hobbyist

@mrjj I have just tried what you suggest... Nothing changed!

john_hobbyist

Below is the original code (source: https://stackoverflow.com/questions/34220275/how-to-select-a-region-with-qrubberband-on-a-qlabel-like-in-ksnapshot). I changed "PyQt4" -> "PyQt5" and "QtGui" -> "QtWidgets". Should I change anything else? Any ideas??

from PyQt4 import QtGui, QtCore

class RubberbandEnhancedLabel(QtGui.QLabel):

    def __init__(self, parent=None):
        QtGui.QLabel.__init__(self, parent)
        self.selection = QtGui.QRubberBand(QtGui.QRubberBand.Rectangle, self)

    def mousePressEvent(self, event):
        '''
            Mouse is pressed. If selection is visible either set dragging mode (if close to border) or hide selection.
            If selection is not visible make it visible and start at this point.
        '''

        if event.button() == QtCore.Qt.LeftButton:

            position = QtCore.QPoint(event.pos())
            if self.selection.isVisible():
                # visible selection
                if (self.upper_left - position).manhattanLength() < 20:
                    # close to upper left corner, drag it
                    self.mode = "drag_upper_left"
                elif (self.lower_right - position).manhattanLength() < 20:
                    # close to lower right corner, drag it
                    self.mode = "drag_lower_right"
                else:
                    # clicked somewhere else, hide selection
                    self.selection.hide()
            else:
                # no visible selection, start new selection
                self.upper_left = position
                self.lower_right = position
                self.mode = "drag_lower_right"
                self.selection.show()

    def mouseMoveEvent(self, event):
        '''
            Mouse moved. If selection is visible, drag it according to drag mode.
        '''
        if self.selection.isVisible():
            # visible selection
            if self.mode is "drag_lower_right":
                self.lower_right = QtCore.QPoint(event.pos())
            elif self.mode is "drag_upper_left":
                self.upper_left = QtCore.QPoint(event.pos())
            # update geometry
            self.selection.setGeometry(QtCore.QRect(self.upper_left, self.lower_right).normalized())

app = QtGui.QApplication([])

screen_pixmap = QtGui.QPixmap.grabWindow(app.desktop().winId())

window = QtGui.QWidget()
layout = QtGui.QVBoxLayout(window)
label = RubberbandEnhancedLabel()
label.setPixmap(screen_pixmap)
layout.addWidget(label)
geometry = app.desktop().availableGeometry()
window.setFixedSize(geometry.width(), geometry.height())
window.show()
app.exec_()

JonB

@john_hobbyist said in Merge two pieces of code:

File "code_2.py", line 333, in <module>
  screen_pixmap = QtWidgets.QPixmap.grabWidget(app.desktop()) 
AttributeError: module 'PyQt5.QtWidgets' has no attribute 'QPixmap'

QPixMap is not a widget so it won't be in QtWidgets. It will be in QtGui. As per https://doc.qt.io/qt-5/qpixmap.html.

I changed "PyQt4" -> "PyQt5" and "QtGui" -> "QtWidgets".

You are supposed to be selective about that. Nobody said everything in QtGui changed to QtWidgets between 4 & 5. Just widgetty stuff!