Merge two pieces of code

SGaist

Rather than just copying it, did you try to run the application from the repo as is ?

john_hobbyist

@SGaist Hi,yes, it runs without any problems!

SGaist

Then compare it to your version and see where the difference lies.

john_hobbyist

@SGaist : I have tried any possible solution! Is there any other way to select an area on image apart from rubberband?

JonB

@john_hobbyist
I don't think so, rubber band is the right way to do it. Even if there were another way, like just clicking, I presume you would face the same issues getting it right as you are now for rubber band.

john_hobbyist

I try for many hours to incorporate another code in the code from the github repository. I have fixed some errors (because it was written basically for PyQt4). But I cannot fix this error:

Traceback (most recent call last):
  File "code_2.py", line 333, in <module>
    screen_pixmap = QtGui.QPixmap.grabWidget(app.desktop()) 
NameError: name 'QtGui' is not defined
Segmentation fault (core dumped)

I change the QtWidgets to QtGui and I get this error:

Traceback (most recent call last):
File "code_2.py", line 333, in <module>
  screen_pixmap = QtWidgets.QPixmap.grabWidget(app.desktop()) 
AttributeError: module 'PyQt5.QtWidgets' has no attribute 'QPixmap'
Segmentation fault (core dumped)

Any ideas??

mrjj

Hi
Are you using Qtpy5 ?

I think its
from PyQt5.QtGui import QPixmap

https://www.pythonguis.com/faq/adding-images-to-pyqt5-applications/

john_hobbyist

@mrjj I have just tried what you suggest... Nothing changed!

john_hobbyist

Below is the original code (source: https://stackoverflow.com/questions/34220275/how-to-select-a-region-with-qrubberband-on-a-qlabel-like-in-ksnapshot). I changed "PyQt4" -> "PyQt5" and "QtGui" -> "QtWidgets". Should I change anything else? Any ideas??

from PyQt4 import QtGui, QtCore

class RubberbandEnhancedLabel(QtGui.QLabel):

    def __init__(self, parent=None):
        QtGui.QLabel.__init__(self, parent)
        self.selection = QtGui.QRubberBand(QtGui.QRubberBand.Rectangle, self)

    def mousePressEvent(self, event):
        '''
            Mouse is pressed. If selection is visible either set dragging mode (if close to border) or hide selection.
            If selection is not visible make it visible and start at this point.
        '''

        if event.button() == QtCore.Qt.LeftButton:

            position = QtCore.QPoint(event.pos())
            if self.selection.isVisible():
                # visible selection
                if (self.upper_left - position).manhattanLength() < 20:
                    # close to upper left corner, drag it
                    self.mode = "drag_upper_left"
                elif (self.lower_right - position).manhattanLength() < 20:
                    # close to lower right corner, drag it
                    self.mode = "drag_lower_right"
                else:
                    # clicked somewhere else, hide selection
                    self.selection.hide()
            else:
                # no visible selection, start new selection
                self.upper_left = position
                self.lower_right = position
                self.mode = "drag_lower_right"
                self.selection.show()

    def mouseMoveEvent(self, event):
        '''
            Mouse moved. If selection is visible, drag it according to drag mode.
        '''
        if self.selection.isVisible():
            # visible selection
            if self.mode is "drag_lower_right":
                self.lower_right = QtCore.QPoint(event.pos())
            elif self.mode is "drag_upper_left":
                self.upper_left = QtCore.QPoint(event.pos())
            # update geometry
            self.selection.setGeometry(QtCore.QRect(self.upper_left, self.lower_right).normalized())

app = QtGui.QApplication([])

screen_pixmap = QtGui.QPixmap.grabWindow(app.desktop().winId())

window = QtGui.QWidget()
layout = QtGui.QVBoxLayout(window)
label = RubberbandEnhancedLabel()
label.setPixmap(screen_pixmap)
layout.addWidget(label)
geometry = app.desktop().availableGeometry()
window.setFixedSize(geometry.width(), geometry.height())
window.show()
app.exec_()

JonB

@john_hobbyist said in Merge two pieces of code:

File "code_2.py", line 333, in <module>
  screen_pixmap = QtWidgets.QPixmap.grabWidget(app.desktop()) 
AttributeError: module 'PyQt5.QtWidgets' has no attribute 'QPixmap'

QPixMap is not a widget so it won't be in QtWidgets. It will be in QtGui. As per https://doc.qt.io/qt-5/qpixmap.html.

I changed "PyQt4" -> "PyQt5" and "QtGui" -> "QtWidgets".

You are supposed to be selective about that. Nobody said everything in QtGui changed to QtWidgets between 4 & 5. Just widgetty stuff!

john_hobbyist

@JonB: Hi, as I posted previously:

Traceback (most recent call last):
  File "code_2.py", line 333, in <module>
    screen_pixmap = QtGui.QPixmap.grabWidget(app.desktop()) 
NameError: name 'QtGui' is not defined
Segmentation fault (core dumped)

I have also tried this....

SGaist

You did not import the module.

john_hobbyist

@SGaist: Something else than these?

import os
import sys
import cv2
from matplotlib.figure import Figure
import numpy as np
from PyQt5.QtGui import QIcon
from PyQt5.QtWidgets import (QMainWindow, QApplication, QWidget,QAction, QFileDialog, QMenu, 
                             QToolBar, QHBoxLayout, QTreeView, QFileSystemModel, QSizePolicy, 
                             QMessageBox)
from PyQt5.QtCore import Qt, QDir, QStandardPaths, QFileInfo
import matplotlib.backends.backend_qt5agg as mpl_qt
from PyQt5 import QtWidgets, QtCore
from PyQt5.QtGui import QPixmap

SGaist

You import QPixmap directly so use it directly as well.

john_hobbyist

@SGaist: I used this:

screen_pixmap = QPixmap.grabWidget(app.desktop())

I get this:

Traceback (most recent call last):
  File "code_2.py", line 335, in <module>
    screen_pixmap = QPixmap.grabWidget(app.desktop()) 
AttributeError: type object 'QPixmap' has no attribute 'grabWidget'
Segmentation fault (core dumped)

I followed this: https://stackoverflow.com/questions/29260686/qpixmap-has-no-attribute-grabwindow

and I changed to this:

screen_pixmap = QScreen.grabWidget(app.desktop())

and I get this:

Traceback (most recent call last):
  File "code_2.py", line 336, in <module>
    screen_pixmap = QScreen.grabWidget(app.desktop()) 
AttributeError: type object 'QScreen' has no attribute 'grabWidget'
Segmentation fault (core dumped)

When I changed to this:

screen_pixmap = QScreen.grabWindow(app.desktop().winId())

I get this:

Must construct a QApplication first.
Traceback (most recent call last):
  File "code_2.py", line 337, in <module>
    screen_pixmap = QScreen.grabWindow(app.desktop().winId()) 
AttributeError: 'NoneType' object has no attribute 'winId'
Segmentation fault (core dumped)

When I changed to this:

screen_pixmap = QScreen.grabWindow(app.desktop())

I get this:

Must construct a QApplication first.
Traceback (most recent call last):
  File "code_2.py", line 338, in <module>
    screen_pixmap = QScreen.grabWindow(app.desktop())#.winId()) 
TypeError: grabWindow(self, PyQt5.sip.voidptr, x: int = 0, y: int = 0, width: int = -1, height: int = -1): first argument of unbound method must have type 'QScreen'
Segmentation fault (core dumped)

I didn't find something about this...

JonB

@john_hobbyist
The last answer in the stackoverflow link you quoted claims to have "Full example for PyQt5". Did you at least try that? Not your own version of it, just exactly the example given there.

john_hobbyist

@JonB Yes, it works, but I try different rubberband code...please look at my first posts up...

john_hobbyist

This post is deleted!

john_hobbyist

What modifications should I do in the command?

john_hobbyist

I am trying to modify/incorporate from the correct running code from the stackoverflow that @JonB suggested. With this:

screen_pixmap = QScreen.grabWindow(app.primaryScreen(),QApplication.desktop().winId()).save(filename, 'png')

I get this:

Must construct a QApplication first.
Traceback (most recent call last):
  File "code_2.py", line 340, in <module>
    screen_pixmap = QScreen.grabWindow(app.primaryScreen(),QApplication.desktop().winId()).save(filename, 'png')
AttributeError: 'NoneType' object has no attribute 'winId'
Segmentation fault (core dumped)

And with this

screen_pixmap = QScreen.grabWindow(app.primaryScreen(),QApplication.desktop()).save(filename, 'png')

I get again this:

 construct a QApplication first.
Traceback (most recent call last):
  File "code_2.py", line 341, in <module>
    screen_pixmap = QScreen.grabWindow(app.primaryScreen(),QApplication.desktop()).save(filename, 'png')
TypeError: grabWindow(self, PyQt5.sip.voidptr, x: int = 0, y: int = 0, width: int = -1, height: int = -1): first argument of unbound method must have type 'QScreen'
Segmentation fault (core dumped)

in which I cannot find a reliable solution from google/stackoverflow...