accessing aggregates (QVector of a struct)

ODБOï

@mzimmers said in accessing aggregates (QVector of a struct):

your getBottleList() declares bottleList, which is also a member variable. Is this correct?

it's a mistake from me,obviously it should return the member variable QVariantList bottle List, and not declare anything . I will correct it

@mzimmers said in accessing aggregates (QVector of a struct):

I haven't gotten to this point yet, but I'm not clear on how the QML accesses the members of the BottleData object (for example, the volume). Do I use the property for this?

please take time to read my answer, i did show an example of usage in qml

@mzimmers said in accessing aggregates (QVector of a struct):

I'd like to make this class usable by other C++ classes. How do I return a BottleList from my QVariantList?

i don't know what do you mean here sorry, what class are you talking about ?

fcarney

Do your views need to react to changes in the data?
The list might be appropriate as a property.

Is the data updated all at once?
Yes, then you can return the QVariantList as a property.
No, then the list might be more appropriate as a model. This will allows updates to rows to be independent of each other.

You can return a model as a qvariant this way: QVariant::fromValue(customModel) or as a QAbstractItemModel*. The latter is in the meta object system that qml can recognize.

The reason I show the QVariant::fromValue is because I needed to return a model from a model in the data() call in my code. Something I just figured out.

Also, this page might be helpful to know what is by default accessible to QML from C++.

mzimmers

Let me back up a bit: for this overall effort, there are three distinct (though overlapping) efforts:

to collect the (current) information about the fill levels in 16 bottles in a rack. This is purely a C++ effort, and I've got it working.
to put the information into a form that is available to QML.
to render the information on a QML screen.

To answer fcarney's question, let's assume that the view should indeed be dynamic. I can update all the information on demand (from C++, which is adequate).

In my C++, I'd like to maintain a BottleList (as opposed to a QVariantList) for debugging purposes only. (Maybe there's a way to meaningfully examine the contents of a QVariantList in gdb, but I don't know of it.) I'm assuming that the QML needs a QVariant, right? I think it would be easier to implement a function that casts the list to a QVariantList for the QML, but I'm interested in others' opinions on this.

Thanks...

fcarney

The most basic would be a QVariantList that is a property. It would have a signal so that when the list is changed then the C++ can notify view. This will require a QVariantList to be built every time anything changes. For 16 items this is probably not a big deal. Keep your BottelList as is. The function that returns the values for the property can convert the entire list. The code that makes changes to the BottleList would need to fire the signal on changes.

mzimmers

Thanks for the information, guys. I'm making progress, but still can't quite connect all the dots. I've created a BottleList class, with a method:

QVariantList BottleList::getBottleListQv() {
    QVariantList qvl;
    BottleData bd;
    for (int i = 0; i < NBR_BOTTLES; ++i) {
        bd = getBottleData(i);
        qvl.append(QVariant::fromValue(bd));
    }
    return qvl;
}

Another class ChangeConsumables creates an instance of BottleList.

from my QML file:

        function getRackData() {
            var bottleRack = changeConsumablesViewModel.getBottleListQv()
            return bottleRack
        }
        Bottle {
            id: bottle1
            cellText: "W7"
            cellColor: "red"
        }

I have 16 entries similar to bottle1.

So, what I'm missing is...how to replace the hard-coded "W7" with the name field from the BottleData struct in my BottleList class?

Thanks.

kshegunov

You can refer to the object by id. Like this:

function loadRackDataFirst() {
    bottle1.cellText = changeConsumablesViewModel.getBottleListQv()[0].name
}

However you should convert to QString.

fcarney

Repeater {
  model: changeConsumablesViewModel.getBottleListQv() // or use property, a property will have a signal to update if the list changes
  Bottle {
    cellText: modelData.name
  }
}

If you want more interaction then a model might be more appropriate.

modelData Search for modelData on that page to understand where it comes from.

mzimmers

@kshegunov the "name" field isn't accessible as I've currently implemented it. I think I may have over-designed this. I've made several changes since my earlier posts, so let me recap my code:

The struct:

struct BottleData {
  Q_GADGET
public:
  uint32_t m_volume;               // amount in bottle (in uL)
  uint32_t m_amountNeeded;         // amount needed for synth (in uL)
  int m_position;                  // still figuring this one out
  std::string m_name;              // name of the reagent
  ReagentBottleType m_bottleType;  // bottle type.
  Q_PROPERTY(uint32_t volume MEMBER m_volume)
  Q_PROPERTY(uint32_t amountNeeded MEMBER m_amountNeeded)
  Q_PROPERTY(int position MEMBER m_position)
  Q_PROPERTY(std::string name MEMBER m_name)
  Q_PROPERTY(ReagentBottleType bottleType MEMBER m_bottleType)
};
Q_DECLARE_METATYPE(BottleData)

The class:

typedef QVector<BottleData> BottleDataList;

class BottleList : public QObject
{
    Q_OBJECT
private:
    BottleDataList m_bottleList;
public:
    explicit BottleList(QObject *parent = nullptr);
    Q_PROPERTY(QVariantList qvl READ getBottleListQv)
    QVariantList getBottleListQv();
    ...

From reading the docs, I was under the impression that I wouldn't need a getter for the fields in the struct, because I used the MEMBER macro. Did I misinterpret this?

mzimmers

@fcarney that looks really powerful. The complete definition of each model is like this:

        Bottle {
            id: bottle1
            cellX: 25
            cellY: 105
            cellHeight: 75
            cellWidth: 75
            bottleScaleFactor: scaleFactor
            cellText: "W7"
            cellColor: "red"
        }

If I use the repeater to load the names, can I alter the individual bottles afterwards?

Thanks...

PS: I'm aware that there's a lot of ugly hard-coding in here; I was going to address that after I got the connections working.

fcarney

If I use the repeater to load the names, can I alter the individual bottles afterwards?

It only alters the copy given to the Repeater. It has no way to get that data back.

I have not used Q_GADGETs before. What does it print out when you console.log(modelData)? Curious as what QML thinks that objects is.

fcarney

@mzimmers said in accessing aggregates (QVector of a struct):

From reading the docs, I was under the impression that I wouldn't need a getter for the fields in the struct, because I used the MEMBER macro. Did I misinterpret this?

I "think" so. DOH! I meant to agree to the MEMBER macro doing that, not you misinterpreting this.

mzimmers

@fcarney my console.log isn't working for this app, so I can't tell you. I discovered Q_GADGET from some online searching; in simplest terms, it's a lightweight version of Q_OBJECT (no signals/slots).

I'm not at all concerned with updating anything other than my display. But now you have me wondering where I should really define all those values. (I would rather not use JSON, but that's probably the right way to do this.)

fcarney

@mzimmers If you want your display to interact with the data then a full blown QAbstractListModel would be a better fit. Then each piece of the BottleData object could be its own role. With a setData routine you can edit that model.

kshegunov

@mzimmers said in accessing aggregates (QVector of a struct):

Q_DECLARE_METATYPE(BottleData)

is already done by the Q_GADGET so it's superfluous.

Switch

std::string m_name;

to QString.

Register the type with QML (qmlRegisterType) if you intend to create instances of it from there.

From reading the docs, I was under the impression that I wouldn't need a getter for the fields in the struct, because I used the MEMBER macro. Did I misinterpret this?

Nope, this is correct as far as I recall.

If I use the repeater to load the names, can I alter the individual bottles afterwards?

I don't think so, but I'm a noobster with QML. I believe you can imperatively create the items like this (untested):

Component {
        id: component
        Bottle { cellText: "default text" }
        onCompleted: changeConsumablesViewModel.getBottleListQv().forEach(element => function(element)  {
           createObject(parentItemId, { cellText: element.name });
        }, this);
}

or something akin.

mzimmers

OK, so why doesn't this work?

    Rectangle {
        id: rack
        function getBottleName(i) {
            return changeConsumablesViewModel.getBottleListQv()[i].m_name
        }
        Bottle {
            cellText: rack.getBottleName(0)// "W7"
        }

I get this error on the line with the "return" statement:

TypeError: Cannot read property 'm_name' of undefined

kshegunov

@mzimmers said in accessing aggregates (QVector of a struct):

TypeError: Cannot read property 'm_name' of undefined

Your property is called name, also check the elements you get in that array. Side note: you may need to wait for the component to be fully loaded before doing that (but take with a grain of salt).

mzimmers

@kshegunov said in accessing aggregates (QVector of a struct):

@mzimmers said in accessing aggregates (QVector of a struct):

TypeError: Cannot read property 'm_name' of undefined

Your property is called name, also check the elements you get in that array.

Tried with "name" -- same error.

Side note: you may need to wait for the component to be fully loaded before doing that (but take with a grain of salt).

Actually, I think you're on to it here. For some reason, the people who wrote this app (I'm just maintaining it) load all the QML files up-front, rather than as-needed. I think the problem is that this is an empty vector when this function is first called...I need to think of how best to handle that.

kshegunov

@mzimmers said in accessing aggregates (QVector of a struct):

Actually, I think you're on to it here. For some reason, the people who wrote this app (I'm just maintaining it) load all the QML files up-front, rather than as-needed. I think the problem is that this is an empty vector when this function is first called...I need to think of how best to handle that.

Check that through the console. If you want, you can try to wait for the component by adding[1]:

Component.onCompleted: <js code to do w/e>

[1]: https://doc.qt.io/qt-5/qml-qtqml-component.html#completed-signal

fcarney

Okay, I tested it. I cannot get Q_GADGET to work so I used Q_OBJECT:
class in main.cpp:

using ReagentBottleType = int;
class BottleData : public QObject
{
    Q_OBJECT

    Q_PROPERTY(int volume MEMBER m_volume NOTIFY somethingChanged)
    Q_PROPERTY(int amountNeeded MEMBER m_amountNeeded NOTIFY somethingChanged)
    Q_PROPERTY(int position MEMBER m_position NOTIFY somethingChanged)
    Q_PROPERTY(std::string name MEMBER m_name NOTIFY somethingChanged)
    Q_PROPERTY(ReagentBottleType bottleType MEMBER m_bottleType NOTIFY somethingChanged)
public:
    BottleData(QObject* parent=nullptr)
        : QObject(parent)
    {
        connect(this, &BottleData::somethingChanged, [this](){
            qDebug() << "somethingChanged" << m_position << QString::fromStdString(m_name) << m_volume;
        });
    }

    int m_volume=0;               // amount in bottle (in uL)
    int m_amountNeeded=0;         // amount needed for synth (in uL)
    int m_position=0;                  // still figuring this one out
    std::string m_name="";              // name of the reagent
    int m_bottleType=0;  // bottle type.

signals:
    void somethingChanged();
};

setting contextProperty in main.cpp for testing:

TestObj testobj;
auto context = engine.rootContext();
context->setContextProperty("varlisttestobj", &testobj);

QML to exercise the object in C++:

Column {
        anchors.top: listview1.bottom
        Repeater {
            model: varlisttestobj.varList

            Row {
                id: bottledelegate

                width: 50
                spacing: 20

                Component.onCompleted: console.log(modelData, modelData.position, modelData.volume)

                Timer {
                    interval: 1000
                    repeat: true
                    running: true
                    onTriggered: {
                        modelData.volume += 1
                    }
                }

                Text {
                    text: modelData.position
                    height: 20
                }
                Text {
                    text: modelData.volume
                    height: 20
                }
            }
        }
    }

QML did not like uint32_t at all. So you will have to find another type that it likes on that page with compatible QML types I linked earlier.

fcarney

Oops, I forgot test object in main.cpp:

class TestObj : public QObject
{
    Q_OBJECT
    Q_PROPERTY(QVariantList varList READ varList NOTIFY varListChanged)
    //Q_PROPERTY(QObjectList objList READ objList NOTIFY objListChanged)

public:
    TestObj(QObject* parent=nullptr)
        : QObject(parent)
    {
        for(int count=0; count<10; ++count){
            auto bottle = new BottleData();
            bottle->m_volume = count*10;
            bottle->m_position = count;
            m_bottleData.append(bottle);
        }

        emit varListChanged();
    }

    QVariantList varList(){
        QVariantList list;
        for(auto bottleData: qAsConst(m_bottleData)){
            list.append(QVariant::fromValue(bottleData));
        }
        return list;
    }
    /*
    QObjectList objList(){
        QObjectList list;
        for(auto bottleData: qAsConst(m_bottleData)){
            list.append(bottleData);
        }
        return list;
    }
    */


signals:
    void varListChanged();

private:
    QVector<BottleData*> m_bottleData;

};