Timers cannot be ####### from another thread
-
@SGaist I think that "mpsckClient" was created in the same where the QThread lives (probably in the constructor) but it is using it in the thread that manages the QThread (the run method)
-
@SGaist, here is part of the prototype:
class clsMsgSender : public QObject { Q_OBJECT ... }And the constructor:
clsMsgSender::clsMsgSender(clsModule* pModule) : mblnRun(true), mblnStopped(false) , meSckState(QAbstractSocket::ConnectedState) , mpModule(nullptr) , mpsckClient(nullptr) , mpThread(nullptr) { setModule(pModule); clsMsgSender::mspService = this; QObject::connect(this, &clsMsgSender::tryToConnect ,this, &clsMsgSender::onTryToConnect, Qt::DirectConnection); QObject::connect(this, &clsMsgSender::removeTrkrs ,this, &clsMsgSender::onRemoveTrkrs, Qt::DirectConnection); QObject::connect(this, &clsMsgSender::sendJSON ,this, &clsMsgSender::onSendJSON, Qt::DirectConnection); QObject::connect(this, &clsMsgSender::startService ,this, &clsMsgSender::onCreateMsgSndrThrd, Qt::DirectConnection); QObject::connect(this, &clsMsgSender::write ,this, &clsMsgSender::onWrite, Qt::DirectConnection); mpsckClient = new QTcpSocket(this); QObject::connect(mpsckClient, &QTcpSocket::connected ,this, &clsMsgSender::onConnected); QObject::connect(mpsckClient, &QAbstractSocket::errorOccurred ,this, &clsMsgSender::onErrorOccurred); QObject::connect(mpsckClient, &QTcpSocket::disconnected ,this, &clsMsgSender::onDisconnected); emit startService(); }And the slot onCreateMsgSndrThrd:
void clsMsgSender::onCreateMsgSndrThrd() { if ( mpThread == nullptr ) { mpThread = new QThread; moveToThread(mpThread); QObject::connect(mpThread, &QThread::started, this, &clsMsgSender::run); mpThread->start(); } }@SPlatten move the socket creation in run. Sockets cannot be moved to other threads. They have to be created in the thread they will actually work in.
Interested in AI ? www.idiap.ch
Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct -
@SPlatten move the socket creation in run. Sockets cannot be moved to other threads. They have to be created in the thread they will actually work in.
-
@SPlatten move the socket creation in run. Sockets cannot be moved to other threads. They have to be created in the thread they will actually work in.
@SGaist, @eyllanesc , do you mean:
void clsMsgSender::run() { mpsckClient = new QTcpSocket(this); QObject::connect(mpsckClient, &QTcpSocket::connected ,this, &clsMsgSender::onConnected); QObject::connect(mpsckClient, &QAbstractSocket::errorOccurred ,this, &clsMsgSender::onErrorOccurred); QObject::connect(mpsckClient, &QTcpSocket::disconnected ,this, &clsMsgSender::onDisconnected); //Default last state to connected as it won't be! QTcpSocket::SocketState sckCurState; while( mblnRun == true ) { ... -
@eyllanesc , mpsckClient is created in the clsMsgSender constructor which is not in a thread.
@SPlatten said in Timers cannot be ####### from another thread:
@eyllanesc , mpsckClient is created in the clsMsgSender constructor which is not in a thread.
Wrong, the object creation happens in the main thread.
You always have at least one thread when you execute an application.
Interested in AI ? www.idiap.ch
Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct -
@SPlatten said in Timers cannot be ####### from another thread:
@eyllanesc , mpsckClient is created in the clsMsgSender constructor which is not in a thread.
Wrong, the object creation happens in the main thread.
You always have at least one thread when you execute an application.
-
And that is the issue. You are thus creating your socket in the main thread as well.
Interested in AI ? www.idiap.ch
Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct -
@SGaist , sorry, I'm not sure why you say that, the class clsMsgSender is not a socket. If you mean that:
mpsckClient = new QTcpSocket(this);Is that the problem? because this is in the clsMsgSender constructor, then please explain what I should do because I suggested moving it into the thread and the response was no.
Can you please clarify what I'm doing wrong and how to fix it?
-
@SPlatten said in Timers cannot be ####### from another thread:
new QTcpSocket(this);
This creates an object with the parent in the main thread. And since a child must be in the same thread as the parent...
Don't pass this as parent and delete it by your own. -
@Christian-Ehrlicher for sockets you have to go one step further and ensure it's created in the thread that will actually use it.
Interested in AI ? www.idiap.ch
Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct -
@Christian-Ehrlicher for sockets you have to go one step further and ensure it's created in the thread that will actually use it.
-
Start with the QThread. There are several other chapters linked from the details of the class.
Interested in AI ? www.idiap.ch
Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct -
Start with the QThread. There are several other chapters linked from the details of the class.
@SGaist , I've just read the details on QThread and I didn't see anything specifically regarding the use of Sockets. I then found this when searching online:
https://forum.qt.io/topic/57753/qtcpsocket-and-qthread
Obviously you are familiar with this one.https://stackoverflow.com/questions/34641732/qtcpsocket-handling-in-another-qthread
Not sure what the conclusion of the above was...https://www.bogotobogo.com/Qt/Qt5_QTcpServer_Multithreaded_Client_Server.php
Working through this....I must say the approach the last link takes is exactly the way I started, with sub-classing my listening class from QTcpServer, however after several posts here advising not to do this I changed my class.
