Qt Forum

    • Login
    • Search
    • Categories
    • Recent
    • Tags
    • Popular
    • Users
    • Groups
    • Search
    • Unsolved

    How to find the code changes that fixed a particular Bug?

    General and Desktop
    3
    17
    2422
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • R
      rajeshbk last edited by

      Hi,

      We are currently using QT 4.7 for an application and using ListView. We are currently experiencing memory leak and found this is fixed as part of Bug "QTBUG-25784 : QML Listview has memory leaks when QList<QObject*> model is used".

      The fix is available in release 4.8.2 but I do not want to upgrader my QT version now. How can I find the actual code fix for the bug so that I can source the same in version 4.7. Please let me know the steps to find the same.

      Thanks & Regards,
      Rajesh B.K

      1 Reply Last reply Reply Quote 0
      • sierdzio
        sierdzio Moderators last edited by

        You need to look at "All" activity on this Jira item. There is the link to gerrit change-id: "link":https://codereview.qt-project.org/#change,26452.

        (Z(:^

        1 Reply Last reply Reply Quote 0
        • R
          rajeshbk last edited by

          Thanks a lot, It helped a lot.

          1 Reply Last reply Reply Quote 0
          • sierdzio
            sierdzio Moderators last edited by

            Pleasure.

            The interface could be more user-friendly, to be honest :/

            (Z(:^

            1 Reply Last reply Reply Quote 0
            • SGaist
              SGaist Lifetime Qt Champion last edited by

              Agreed, this might be a feature request ? :)

              Interested in AI ? www.idiap.ch
              Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

              1 Reply Last reply Reply Quote 0
              • sierdzio
                sierdzio Moderators last edited by

                Probably, yes. Jira is rather flexible, it should facilitate such a change.

                (Z(:^

                1 Reply Last reply Reply Quote 0
                • R
                  rajeshbk last edited by

                  One more query, How do we map the Bug ID say QTBUG-25784 to the Review ID in Jira. I tried seaching in Jira by bug ID, but no search result found.

                  1 Reply Last reply Reply Quote 0
                  • sierdzio
                    sierdzio Moderators last edited by

                    That is probably not really possible :( Maybe with some advanced search, I don't really know.

                    (Z(:^

                    1 Reply Last reply Reply Quote 0
                    • R
                      rajeshbk last edited by

                      Okay, Then how did you find the right entry for the QTBUG-25784 in Jira? Scrolled accross all the Jira entries ?

                      1 Reply Last reply Reply Quote 0
                      • sierdzio
                        sierdzio Moderators last edited by

                        Go to "Source" "tab":https://bugreports.qt-project.org/browse/QTBUG-25784?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel - there is a Change-ID entry there. Copy the id and search for it on gerrit.

                        (Z(:^

                        1 Reply Last reply Reply Quote 0
                        • R
                          rajeshbk last edited by

                          Sorry if I am appearing too dumb :)

                          In bugreports.qt-project.org for the given bug I could not find the change ID. I understand from your link https://codereview.qt-project.org/#change,26452 that the change ID is 26452.

                          But I could neither find the source tab nor the ID 26452 in the Jira

                          Could you please let me know if I am missing something?

                          1 Reply Last reply Reply Quote 0
                          • sierdzio
                            sierdzio Moderators last edited by

                            No. This is change-ID for given item: I1d6cd4dfc2530424535a7e00164563d9b4aaa513.

                            (Z(:^

                            1 Reply Last reply Reply Quote 0
                            • R
                              rajeshbk last edited by

                              Okay, But I am unable to find this change ID in https://bugreports.qt-project.org/browse/QTBUG-25784

                              Neither do I find the source tab. Is Login to https://bugreports.qt-project.org/ required to view the change ID ?

                              1 Reply Last reply Reply Quote 0
                              • sierdzio
                                sierdzio Moderators last edited by

                                Ha, bingo :) I didn't know about that, but yes, you need to be logged in. When I logged out, I could not see the change ID anymore.

                                This is bad. We're talking about GUI toolkit and our bug reporting tool has inconvenient UI... a bit ironic, isn't it? xD

                                (Z(:^

                                1 Reply Last reply Reply Quote 0
                                • SGaist
                                  SGaist Lifetime Qt Champion last edited by

                                  Indeed... Another feature request ? :)

                                  Interested in AI ? www.idiap.ch
                                  Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

                                  1 Reply Last reply Reply Quote 0
                                  • sierdzio
                                    sierdzio Moderators last edited by

                                    Done: "link":https://bugreports.qt-project.org/browse/QTJIRA-227. Please watch and vote ;)

                                    (Z(:^

                                    1 Reply Last reply Reply Quote 0
                                    • R
                                      rajeshbk last edited by

                                      Thanks. I could get the change ID for that Bug, But for another bug QTBUG-21747 the source is empty. Is there another path to find the associated code changes?

                                      1 Reply Last reply Reply Quote 0
                                      • First post
                                        Last post