How to find the code changes that fixed a particular Bug?

rajeshbk · wrote on 24 Jul 2013, 11:51

Hi,

We are currently using QT 4.7 for an application and using ListView. We are currently experiencing memory leak and found this is fixed as part of Bug "QTBUG-25784 : QML Listview has memory leaks when QList<QObject*> model is used".

The fix is available in release 4.8.2 but I do not want to upgrader my QT version now. How can I find the actual code fix for the bug so that I can source the same in version 4.7. Please let me know the steps to find the same.

Thanks & Regards,
Rajesh B.K

sierdzio · wrote on 25 Jul 2013, 09:20

You need to look at "All" activity on this Jira item. There is the link to gerrit change-id: "link":https://codereview.qt-project.org/#change,26452.

rajeshbk · wrote on 25 Jul 2013, 09:32

Thanks a lot, It helped a lot.

sierdzio · wrote on 25 Jul 2013, 09:33

Pleasure.

The interface could be more user-friendly, to be honest :/

SGaist · wrote on 25 Jul 2013, 10:18

Agreed, this might be a feature request ? :)

sierdzio · wrote on 25 Jul 2013, 10:20

Probably, yes. Jira is rather flexible, it should facilitate such a change.

rajeshbk · wrote on 25 Jul 2013, 10:47

One more query, How do we map the Bug ID say QTBUG-25784 to the Review ID in Jira. I tried seaching in Jira by bug ID, but no search result found.

sierdzio · wrote on 25 Jul 2013, 10:57

That is probably not really possible :( Maybe with some advanced search, I don't really know.

rajeshbk · wrote on 25 Jul 2013, 11:10

Okay, Then how did you find the right entry for the QTBUG-25784 in Jira? Scrolled accross all the Jira entries ?

sierdzio · wrote on 25 Jul 2013, 11:31

Go to "Source" "tab":https://bugreports.qt-project.org/browse/QTBUG-25784?page=com.atlassian.jirafisheyeplugin:fisheye-issuepanel - there is a Change-ID entry there. Copy the id and search for it on gerrit.

rajeshbk · wrote on 26 Jul 2013, 07:33

Sorry if I am appearing too dumb :)

In bugreports.qt-project.org for the given bug I could not find the change ID. I understand from your link https://codereview.qt-project.org/#change,26452 that the change ID is 26452.

But I could neither find the source tab nor the ID 26452 in the Jira

Could you please let me know if I am missing something?

sierdzio · wrote on 26 Jul 2013, 07:35

No. This is change-ID for given item: I1d6cd4dfc2530424535a7e00164563d9b4aaa513.

rajeshbk · wrote on 26 Jul 2013, 07:41

Okay, But I am unable to find this change ID in https://bugreports.qt-project.org/browse/QTBUG-25784

Neither do I find the source tab. Is Login to https://bugreports.qt-project.org/ required to view the change ID ?

sierdzio · wrote on 26 Jul 2013, 07:47

Ha, bingo :) I didn't know about that, but yes, you need to be logged in. When I logged out, I could not see the change ID anymore.

This is bad. We're talking about GUI toolkit and our bug reporting tool has inconvenient UI... a bit ironic, isn't it? xD

SGaist · wrote on 26 Jul 2013, 08:05

Indeed... Another feature request ? :)

sierdzio · wrote on 26 Jul 2013, 08:13

Done: "link":https://bugreports.qt-project.org/browse/QTJIRA-227. Please watch and vote ;)

rajeshbk · wrote on 26 Jul 2013, 09:46

Thanks. I could get the change ID for that Bug, But for another bug QTBUG-21747 the source is empty. Is there another path to find the associated code changes?