Merge two pieces of code

JonB

@john_hobbyist
So, nicely, do you use some Python debugger to execute your code?

john_hobbyist

@JonB I write the code on a simple text editor and run it on Ubuntu's command line..

JonB

@john_hobbyist
Yeah, that's not a great starting point :) That means you have to put print() statements everywhere if you want to know what's going on.

Unfortunately so far as I know Qt Creator still offers nothing fur running/debugging Python. (Has this changed?) I used PyCharm as editor and debugger for my Python coding, it was great, but not integrated with Qt Creator if you are designing UI files there. Else, I don't know but running under pdb might be better than nothing at all.

john_hobbyist

Yes, I work with "prints" inside code.... So here how things are: The program goes to the below methods (source on my previous posts) , but it does not displays the rectangle so it does not call screenshot...Any ideas?

Sorry! Updated the correct code!

    def mousePressEvent(self, event):
        print("56")
        '''
            Mouse is pressed. If selection is visible either set dragging mode (if close to border) or hide selection.
            If selection is not visible make it visible and start at this point.
        '''

        if event.button() == QtCore.Qt.LeftButton:
            print("57")

            position = QtCore.QPoint(event.pos())
            print("58")
            if self.selection.isVisible():
                print("59")
                # visible selection
                if (self.upper_left - position).manhattanLength() < 20:
                    print("60")
                    # close to upper left corner, drag it
                    self.mode = "drag_upper_left"
                    print("61")
                elif (self.lower_right - position).manhattanLength() < 20:
                    print("62")
                    # close to lower right corner, drag it
                    self.mode = "drag_lower_right"
                    print("63")
                else:
                    print("64")
                    # clicked somewhere else, hide selection
                    self.selection.hide()
                    print("65")
            else:
                # no visible selection, start new selection
                print("66")
                self.upper_left = position
                print("67")
                self.lower_right = position
                print("68")
                self.mode = "drag_lower_right"
                print("69")
                self.selection.show()
                print("70")

    def mouseMoveEvent(self, event):
        print("71")
        '''
            Mouse moved. If selection is visible, drag it according to drag mode.
        '''
        if self.selection.isVisible():
            print("72")
            # visible selection
            if self.mode == "drag_lower_right":
                print("73")
                self.lower_right = QtCore.QPoint(event.pos())
                print("74")
            elif self.mode == "drag_upper_left":
                print("75")
                self.upper_left = QtCore.QPoint(event.pos())
                print("76")
            # update geometry
            self.selection.setGeometry(QtCore.QRect(self.upper_left, self.lower_right).normalized())
            print("77")

def take_screenshot():
    print("205")
    from PyQt5 import QtCore as pyqt5c
    print("206")
    from PyQt5 import QtWidgets as pyqt5w
    print("207")
    screen = pyqt5w.QApplication.primaryScreen()
    print("208")
    winid = pyqt5w.QApplication.desktop().winId()
    print("209")
    pixmap = screen.grabWindow(winid)
    print("210")

    ba = pyqt5c.QByteArray()
    print("211")
    buff = pyqt5c.QBuffer(ba)
    print("212")
    pixmap.save(buff, "PNG")
    print("213")
    return ba.data()

if __name__ == "__main__":
    print("214")
    app = QApplication(sys.argv)
    print("215")
    icon = QIcon(os.path.join(selfDir, '_static', 'orthoview.ico'))
    print("216")
    app.setWindowIcon(icon)
    print("217")
    from PyQt5.QtWidgets import *
    print("218")
    data = take_screenshot()
    print("219")
    window = QWidget()
    print("220")
    layout = QtWidgets.QVBoxLayout(window)
    print("221")
    pixmap = QPixmap()
    print("222")
    pixmap.loadFromData(data)
    print("223")
    label = QtWidgets.QLabel()
    print("224")
    label.setPixmap(pixmap)
    print("225")
    
    layout.addWidget(label)     
    print("226")
    geometry = app.desktop().availableGeometry()        
    print("227")
    window.setFixedSize(geometry.width(), geometry.height())       
    print("228")
    window = OrthoView()
    print("229")
    window.show()
    print("230")
    sys.exit(app.exec_())

JonB

@john_hobbyist
Seems to be much the same code as you started with, re-pasted. I don't understand how you said you had moved from Qt4 to Qt5 with QtGui changes, yet now you have QtGui.QLabel, which as far as I know should not work....

Anyway, I don't know what path your code is or is not following. It's time for you to put your own print() statements in if you want to understand what is going on....

john_hobbyist

@JonB Yes, I have put "prints" inside the code, that is how I figure out on which parts of code the execution goes...

JonB

@john_hobbyist
But you don't tell me, so you want me to guess?

Does it hit the self.selection.show()? Does it hit the move code? What is your usage of Python is instead of == in if self.mode is "drag_lower_right"?

I leave it to you now.

john_hobbyist

@JonB Sorry! I updated the right code! Please see above 2-3 posts..
When I press the mouse button it goes: 56, 57,58, 59, 62, 63, 56, 57,58, 59, 62, 63....
When I move the mouse, it goes 71, 72, 73, 74, 77, 71, 72, 73, 74, 77...
Either I have loaded an image or not!

JonB

@john_hobbyist
I don't know.

 self.lower_right = QtCore.QPoint(event.pos())
self.upper_left = QtCore.QPoint(event.pos())
self.selection.setGeometry(QtCore.QRect(self.upper_left, self.lower_right).normalized())

Are the coordinates of event.pos() correct for setGeometry()? Start by getting some visible rubber band, e.g. put suitable constants in there instead of relying on mouse positions?

SGaist

@john_hobbyist did you try to just get the rubber band stuff working on a minimal widget ?

You can then apply that knowledge to your more complex application.

john_hobbyist

@SGaist I am searching how do this.... and basically what @JonB suggested...

Update: I noticed that the rectangle works but it is constrained inside tool bar...(upper left corner) not inside the area that I load the image...

mrjj

@john_hobbyist
Hi
Progress :) \o/

Check for RubberbandEnhancedLabel (if you use it still ) what parent you assign to it
when you create it.

john_hobbyist

@mrjj You mean this:

label = RubberbandEnhancedLabel()

but I do not use it. I have it as comment from previous code. Basically the whole unused/commented code is this:

    app = QtWidgets.QApplication([])

    screen_pixmap = QScreen.grabWindow (self, win_id, left, top, width, height)
    
    window = QtGui.QWidget()
    
    layout = QtWidgets.QVBoxLayout(window)
    label = RubberbandEnhancedLabel()
    label.setPixmap(screen_pixmap)
    layout.addWidget(label)
    geometry = app.desktop().availableGeometry()
    window.setFixedSize(geometry.width(), geometry.height())

which I do not use (copied from one of the sources above...). Should I use something from here?

mrjj

@john_hobbyist
Hi
So what IS the blue rectangle then ?

Check the parent where you create it.

john_hobbyist

@mrjj Please look in the previous posts. I have posted everything...

mrjj

@john_hobbyist
Yes but its hard to know what you currently have.
So the blue rectangle is a QRubberband ?

So there place where you create it, what is used as the parent.
It kinda seems like the Toolbar as else it would not clip to it.

is self.selection the RubberBand ?

john_hobbyist

@mrjj Yes, you are right! It is used inside

MyMplCanvas

Yes it is rubberband,

self.selection = QtWidgets.QRubberBand(QtWidgets.QRubberBand.Rectangle, self)

mrjj

@john_hobbyist
Hi
Hmm The reason its up in the Toolbar seems not to be be related to parent

class MyMplCanvas(mpl_qt.FigureCanvasQTAgg):
....
self.selection = QtWidgets.QRubberBand(QtWidgets.QRubberBand.Rectangle, self)

I assume here self is MyMplCanvas and as far as we know MyMplCanvas is the class that draw the image.

So the Rubberband works, but cant be dragged outside that little area ?

john_hobbyist

@mrjj "So the Rubberband works, but cant be dragged outside that little area ?"
Yes!

mrjj

@john_hobbyist
Ok. That is bizarre as that sounds like it is inside the toolbar.
and the mouseXXX functions are under the MyMplCanvas ?

I don't get this as then it should not work if it's placed in toolbar as the mouse events go into
MyMplCanvas.

unde this line
self.selection = QtWidgets.QRubberBand(QtWidgets.QRubberBand.Rectangle, self)

is it possible to
print (self) ?

Im not sure if it just shows the address.