PyQt Multi Language problem

[JonB]

@StarterKit
I would have answered that way, but not given that OP claims

when I click change language, widgets all change language, only QDialog is not updating.

If it were a matter of all widgets need re-translating, how would the OP report that other widgets change language but only a QDialog does not?

I still suspect retranslation is necessary, but cannot explain the OP's observation in this light.

[StarterKit]

@JonB, topic starter haven't mentioned anything about retranslateUi() and how (s)he calls it. So, I have a reason to suspect that it was called for one window but not for another. Am I right? I don't know. But I see reasons to suspect this kind of behavior.

[SGaist]

@StarterKit retranslateUi is a method generated not a standard QWidget method however, you are getting in the correct direction.

@Hai-Anh-Luu what you need to do is to implement your own retranslateUi method and call it from both the __init__ function (or load_ui function) and from the changeEvent function when the QEvent.LanguageEvent happens. Set all the texts of your various dialog widgets in retranslateUi.

[Hai Anh Luu]

@SGaist Thank for your answer. I wrote the retranslateUi() function and put it in the load_ui() function after initializing the QLabels. But without any change, my QDialog is still not updating. This is my retranslateUi() function:

def retranslateUi(self):
    self.mylabel.setText(QCoreApplication.translate("DialogInMap", u"Dialog in Map", None))
    self.label_2.setText(QCoreApplication.translate("DialogInMap", u"Hello in Map", None))

And this is my .ts file in vi_VN language, in en_US.ts, I do not translate use translation type="unfinished"></translation> , so I will not show it here:

<context>
<name>DialogInMap</name>
<message>
<location filename="../presentation/map_screen/dialog_map.py" line="12"/>
<source>Dialog in Map</source>
<translation type="unfinished">Hộp thoại ở Map</translation>
</message>
<message>
<location filename="../presentation/map_screen/dialog_map.py" line="16"/>
<source>Hello in Map</source>
<translation type="unfinished">Xin chào ở Map</translation>
</message>
</context>

@StarterKit Thank for your answer, but I just want to update language without restart application.

[JonB]

@Hai-Anh-Luu
I think you should do some simple debugging (print() statements) which will help you/us identify where the problem lies:

• Show what the currently installed/active translation is immediately before the translate() statements.
• Just output print(QCoreApplication.translate("DialogInMap", u"Dialog in Map", None)), now we don't have to worry about setting widget texts.
• Copy that line to immediately after wherever you change the translation language. Now we don't have to worry about being in dialog code.
• Create a plain QDialog, not sub-classed. Test that for translation.

[SGaist]

@Hai-Anh-Luu from what you wrote, you did not implement one of the most important thing: the changeEvent method. That's the one you need for dynamic translation to happen.

[StarterKit]

Hi @SGaist
Thanks for mentioning QEvent.LanguageEvent - I overlooked it when I studied my problem.
My biggest pain was creation of retranalateUi() methods manually. There were too many stupid manual work so I decided that language change isn't an often thing and user may tolerate application restart that will handle all widgets automatically.

But as we have all this discussion - do you know any way or have any idea of how to automate retranslateUi() creation for custom dialogs? uic obviosly does it so I'm curios is there any better way rather then list all widgets by hand and keep them up to date...

[SGaist]

@StarterKit how many widgets do you have in that dialog ?

The only thing you need to do for getting translated widgets is to move all the setText or equivalent calls from the constructor to the "retranslateUi" method.

[StarterKit]

@SGaist, Thanks!
I see your point - if I have .setText() anyway in a constructor I may move it to retranslateUi() and just make a single call. I haven't thought this way. I'll refactor.

[Hai Anh Luu]

I finally found the solution. Do not need retranslateUi() in QDialog because if the translations exist, and the translation is loaded correctly, when create new Dialog (show() or exec() action), it will also show the appropriate translated text.

My error was loading wrong QTranslator in QApplication. In QMainWindow, this is my correct code:

translator variable must use in both if name function and in body of QMainWindow. Earlier I made the mistake of instantiating a new QTranslator in the body of the QMainWindow (change_language() fuction) and using it to load the new language, so it was out of sync with the original QTranslator in the name function.

    def change_language(self):
        current_language = None
        if LanguageQSettings().get_current_language() == Style.Language.vie:
            # Set tieng Anh o day
            current_language = Style.Language.en
        else:
            # Set tieng Viet o day
            current_language = Style.Language.vie

        translator.load(current_language)
        app.installTranslator(translator)
        self.retranslateUi()
        LanguageQSettings().set_current_language(current_language)

    def retranslateUi(self):
        self.home_screen.retranslate_Ui()
        if not self.login_screen.deleteLater:
            self.login_screen.retranslateUi_login()
        self.update()


if __name__ == "__main__":
    app = QApplication(sys.argv)
    translator = QTranslator()
    translator.load(LanguageQSettings().get_current_language())
    app.installTranslator(translator)

    app.setWindowIcon(QIcon(Style.Image.icon128))
    app.setApplicationName(Style.Text.app_name)
    widget = MainWindow()
    widget.show()
    sys.exit(app.exec())```