How to pass a value from one class to another where each class is on different file

john_hobbyist

@SGaist said in How to pass a value from one class to another where each class is on different file:

As already written earlier, the fact that you post snipets of parts of your code distributed makes it almost impossible to help you.

As @JonB already suggested: you likely did not import class_1 properly in the file where you define class_2.

Yes, I do! Nothing works! Apart from signals/slots and getters/setters how can I pass the value from class_1 to class_2? class_1 and class_2 are stored in different files...

SGaist

Well, this is the standard way to do it.

The fact that your classes are in two different files just means that you have to use proper imports to be able to use them. Nothing more.

From the looks of it, you essentially need to clean up your code base.

As suggested earlier, you should write a small dummy project that does what you want and then adapt that to your big code base.

john_hobbyist

@SGaist said in How to pass a value from one class to another where each class is on different file:

Well, this is the standard way to do it.

The fact that your classes are in two different files just means that you have to use proper imports to be able to use them. Nothing more.

From the looks of it, you essentially need to clean up your code base.

As suggested earlier, you should write a small dummy project that does what you want and then adapt that to your big code base.

I tried this: https://www.geeksforgeeks.org/getter-and-setter-in-python/ and this: https://programmer.group/pyqt5-quick-start-pyqt5-signal-slot-mechanism.html that have source code. I will try again

john_hobbyist

@JonB : What's the purpose of these lines:

# in `MainWindow` class, somewhere
self.window1 = class_1()
self.window2 = class_2()

?

JonB

@john_hobbyist
In the example, class_1 & class_2 are each some kind of widget/window classes, each derived from QWidget. class_1() & class_2() each create a new instance (window in this case) of the respective class. I store the references in two member variables of self, perhaps your MainWindow class.

john_hobbyist

I am working on this: https://doc.qt.io/qtforpython/examples/example_widgets__thread_signals.html which is perfect for what I want to achieve because it has int signals and includes 3 classes. I am trying to divide it on 3 files. Each class on a separate file and import the other 2 classes from the files. But I get the following error:

(most likely due to a circular import)

How would you divide it?

SGaist

You are not even posting the error, how can we know ?

john_hobbyist

@SGaist said in How to pass a value from one class to another where each class is on different file:

You are not even posting the error, how can we know ?

from thread_signals_1 import MainForm
ImportError: cannot import name 'MainForm' from partially initialized module 'thread_signals_1' (most likely due to a circular import) (/home/someone/Desktop/test_code/PyQt5_signals_slots_test/thread_signals_1.py)

SGaist

Please show the exact code you are currently using. All files.

john_hobbyist

Am I allowed to post code (changed though) from this link: https://doc.qt.io/qtforpython/examples/example_widgets__thread_signals.html here? I see something about copyright down in the above website.

SGaist

Post the code with the adequate copyright notice.

john_hobbyist

I am working on JonB's code... After some modifications, I get this error:

File "main_code.py", line 73, in __init__
  self.window1.oneParameterSignal.connect(test.onOneParameterSlot) 
TypeError: class_1 cannot be converted to PyQt5.QtCore.QObject in this context

I googled it, and I found this solution: https://stackoverflow.com/questions/36522809/pyqt5-connection-doesnt-work-item-cannot-be-converted-to-pyqt5-qtcore-qobject

However I cannot understand what to do..even here it is not clear to me https://doc.qt.io/qtforpython-5/PySide2/QtWidgets/QGraphicsObject.html#more

(source of the modified code: https://programmer.group/pyqt5-quick-start-pyqt5-signal-slot-mechanism.html under the paragraph: 3. Advances in signal slot applications, 1. Custom Signal Slot).

Any idea? :-)

JonB

@john_hobbyist
class_1 does not inherit from QObject so cannot emit signals, hence that error message I would say. I said I assumed your class_1 was supposed to be a widget, but goodness knows....

You really need to grasp some of the basics, rather than just banging in code which does not make sense and seeing what happens. First you need to understand classes and instances, which is a C++ thing. Then for signals & slots have you read through https://doc.qt.io/qt-6/signalsandslots.html and understood it? Then read it again? If you follow what is there it has e.g.

All classes that inherit from QObject or one of its subclasses (e.g., QWidget) can contain signals and slots

john_hobbyist

@JonB said in How to pass a value from one class to another where each class is on different file:

@john_hobbyist
class_1 does not inherit from QObject so cannot emit signals, hence that error message I would say. I said I assumed your class_1 was supposed to be a widget, but goodness knows....

You really need to grasp some of the basics, rather than just banging in code which does not make sense and seeing what happens. First you need to understand classes and instances, which is a C++ thing. Then for signals & slots have you read through https://doc.qt.io/qt-6/signalsandslots.html and understood it? Then read it again? If you follow what is there it has e.g.

All classes that inherit from QObject or one of its subclasses (e.g., QWidget) can contain signals and slots

You are right!!!! I fixed it. I think I am close...

This line:

# connect the Qt `QPushButton.clicked()` signal to `self.on_some_button_clicked()`
self.some_button.clicked.connect(self.on_some_button_clicked)

either I put it in class_1 and when the class_1 is called, it should run. Either I put it in main class, where I have all the menu's choices connected to the related classes, where each class is a different file. What modifications should I do in the above command in any of the 2 cases?

SGaist

Where is some_button located in your code ?
Where is on_some_button_clicked located in your code ?

john_hobbyist

@SGaist said in How to pass a value from one class to another where each class is on different file:

Where is some_button located in your code ?
answer: In main

Where is on_some_button_clicked located in your code ?
answer: In class_1

john_hobbyist

@john_hobbyist said in How to pass a value from one class to another where each class is on different file:

I need to pass the value from var_1 to var_2

When I pass the var_1 (from class_1) to var_2 (from class_2) via the signals/slots, the beginning of class_1 and class_2 how should it be? Should I use init and things like this? I am searching it on literature...