signals and slots

[Bono151]

Hi All,

a question regarding pyqtSignal.
in one of m threads I'm declaring a signal:
finished = pyqtSignal(list)
and at the end of the thread I'm emitting the signal to indicate a thread has ended and among that I'm passing a list:
self.finished.emit(self.cmd_log)

in my main window I'm setting :
self.thread_ver.finished.connect(lambda log: self.on_finished(log, "ver"))
the finished.connect is calling self.on_finished() and passing log as the cmd_log signal that was emitted in the thread and a string.
during the run I get:
TypeError: <lambda>() missing 1 required positional argument: 'log'

def on_finished(self, log, type):
    if type == "ver":
        self.btub_ver.create_graph()
        self.pb_eye_ver_run.setStyleSheet('QPushButton {color: green}')
        self.btub_ver.add_lane_overlay(self.bitmap, self.label_eye_lanes_all, self.label_tab_eye_all)
    else:
        self.btub.create_graph()
        self.pb_eye_run.setStyleSheet('QPushButton {color: green}')
        self.btub.add_lane_overlay(self.bitmap, self.label_eye_lanes_all, self.label_tab_eye_all)
    for line in log:
        self.te_log.append(line)

any idea why is happening? in a previous version I didnt user the extra string "ver"
I used self.thread_ver.finished.connect(lambda: self.on_finished) and it worked OK

Manny thanks

[SGaist]

Hi and welcome to devnet,

Which version of Python are you using ?
Which version of PyQt ?

[Bono151]

@SGaist
PyQt5 and Python 3.9

[SGaist]

Can you provide a full minimal script that triggers this issue ?

[Bono151]

@SGaist
many thanks for assisting me. I hope you were refering to the following

worker class:

import constant
from time import sleep
from math import log10
from plot_graph import plot_graph
import matplotlib.pyplot as plt
from PyQt5.QtWidgets import QLabel, QWidget, QTextEdit
from PyQt5.QtGui import QPixmap
from PyQt5.QtCore import QObject, pyqtSignal


class bathtub(QObject):
    err_counters = None
    word_counters = None
    bit_counters = None
    ber_counters = None
    pi_pos = None
    done_dwelling = None
    spi_if = None
    plot_list = None
    plots = None
    progress_val = 0
    cmd_log = []

    finished = pyqtSignal(list)
    progress = pyqtSignal(int)

    def __init__(self, die_offset, d2d_ser, spi_if, eye_tab, ber_target, lanes_bitmap):
        super().__init__()
        self.pri_tx = die_offset.pri_tx
        self.pri_rx = die_offset.pri_rx
        self.sec_tx = die_offset.sec_tx
        self.sec_rx = die_offset.sec_rx
        self.d2d_ser = d2d_ser
        #self.lanes = lanes
        self.spi_if = spi_if
        #self.te_log = te_log
        self.eye_tab = eye_tab
        self.ber_target = ber_target
        self.lanes_bitmap = lanes_bitmap

#    def build_bathtub(self):
    def run(self):
        self.init_arrays()
        self.disable_prbs_checker()  # disable automatically clear the counters
        self.pi_override_and_record_lanes()
        self.set_prbs32_lanes()
        self.move_pi_to_corner_pos("dec")#decrementing the pi to PI_LEFT_MARGINS
        self.sweep_pi_pos("inc")#sweep the pi position up to the center
        self.move_pi_to_corner_pos("inc")  # rementing the pi to PI_LEFT_MARGINS
        self.sweep_pi_pos("dec")  # sweep the pi position up to the center
        self.restore_system()
        #self.create_graph()
        self.finished.emit(self.cmd_log)
        self.cmd_log.clear()

Main Window:

   def pb_eye_run_handler(self):
        self.te_log.clear()# later will be replaced by writing to file
        self.thread = QThread()
        self.btub = bathtub(offset, self.d2d_ser, self.spi_if, self.tab_eye, float(self.le_ber_target.text()), self.lanes_bitmap)
        self.btub.moveToThread(self.thread)
        self.thread.started.connect(self.btub.run)
        self.btub.finished.connect(self.thread.quit)
        self.btub.finished.connect(self.btub.deleteLater)
        self.btub.progress.connect(lambda progress: self.on_progress("", progress))
        self.thread.finished.connect(self.thread.deleteLater)
        self.pb_eye_run.setStyleSheet('QPushButton {color: red}')
        self.thread.start()
        self.thread.finished.connect(lambda cmd_log: self.on_finished(cmd_log, ""))



   def on_finished(self, log, type):
        if type == "ver":
            self.btub_ver.create_graph()
            self.pb_eye_ver_run.setStyleSheet('QPushButton {color: green}')
            self.btub_ver.add_lane_overlay(self.bitmap, self.label_eye_lanes_all, self.label_tab_eye_all)
        else:
            self.btub.create_graph()
            self.pb_eye_run.setStyleSheet('QPushButton {color: green}')
            self.btub.add_lane_overlay(self.bitmap, self.label_eye_lanes_all, self.label_tab_eye_all)
        for line in log:
            self.te_log.append(line)

    def on_progress(self, type, val):
        if type == "ver":
            self.progressBar_ver.setValue(val)
        else:
            self.progressBar.setValue(val)

[SGaist]

Partly, it's not exactly minimal and also does not allow to reproduce the issue.

[Bono151]

@SGaist I dont think I will be able to share minimal code for reproducing