QString replace %U

[sonichy]

@JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

[jsulm]

@sonichy said in QString replace %U:

deepin-draw

This is a relative path. Pass whole path, so it can actually be found...
And please add error handling...

[JonB]

@sonichy said in QString replace %U:

@JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

I previously wrote:

Is sExec set to the correct full path to the executable? What do you think your process->setWorkingDirectory(path); achieves? Because if you think it is used to locate the executable to run, it is not.

[jsulm]

@JonB Yes, it is said that people often do not read carefully...

[JonB]

@jsulm
It would be nice if questioners answered questions and acted on recommendations before just reposting that something does not work. Makes we wonder sometimes why we bother. If I ask a question and somebody gives some suggestions I act on those carefully before asking again. But that's another topic... :)

[sonichy]

@JonB
The Linux desktop file installed by root(deb) do not contain Path.
And absolute exe path do not work either:

/usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\"

Error handle

connect(action, &QAction::triggered, [=](){
    QProcess *process = new QProcess;
    //process->setWorkingDirectory(path);
    qDebug() << sExec;
    //process->start(sExec); //crash
    process->setProgram(sExec);
    connect(process, &QProcess::readyReadStandardError, [=](){
         qDebug() << process->errorString(); //nothing
    });
    bool b = process->startDetached();
    qDebug() << b; //false
    //QProcess::startDetached(sExec, QStringList(), path);
});

[JonB]

@sonichy

• If you mean that qDebug() << sExec; outputs /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" then that is your problem. That line is not a program/executable, is it? The first word is the executable and the second word is an argument (and when passed as an argument it should not then have "s around it). And if that is the case it would have saved a lot of time if you had shown this from the start.

• qDebug() << process->errorString(); //nothing This is not what you are supposed to output if you receive some data on standard error, you are supposed to print the data you receive.

[jsulm]

@sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
"/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
So, what do you want to start actually?!

[JonB]

@jsulm Who knows....

[sonichy]

This post is deleted!

[sonichy]

@jsulm said in QString replace %U:

@sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
"/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
So, what do you want to start actually?!

deepin-draw is relative path.
google-chrome is absolute path.
I make openwith function, I can choose program to start.

[jsulm]

@sonichy Third time: add error handling to see why QProcess fails to start the executable...
Also, sExec should NOT contain executable and parameter! Parameters to the executable are passed as another QStringList parameter https://doc.qt.io/qt-5/qprocess.html#setArguments

[sonichy]

@jsulm said in QString replace %U:

@sonichy Third time: add error handling to see why QProcess fails to start the executable...

Already add.

connect(process, &QProcess::readyReadStandardError, [=](){
         qDebug() << process->errorString(); //nothing
});

[jsulm]

@sonichy said in QString replace %U:

Already add.

No.
You again did not read what I wrote: "I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred".
I'm out of this thread...

[sonichy]

@JonB said in QString replace %U:

@sonichy

• If you mean that qDebug() << sExec; outputs /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" then that is your problem. That line is not a program/executable, is it? The first word is the executable and the second word is an argument (and when passed as an argument it should not then have "s around it). And if that is the case it would have saved a lot of time if you had shown this from the start.

• qDebug() << process->errorString(); //nothing This is not what you are supposed to output if you receive some data on standard error, you are supposed to print the data you receive.

/usr/bin/google-chrome-stable home/sonichy/Desktop/description.xml
false

Add "*" is to include space in filename.

[JonB]

@sonichy
In my previous post:

• I already told you what you need to do in QProcess::readyReadStandardError, you have not acted on it.

• I already told you that if sExec is /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" (or anything similar, with or without the quotes) that won't work, why it won't work, and what you need to do about it. But you did not answer (and now you have but not acted on what I said). And nor will plain deepin-draw, unless it is on your PATH

I too am done.

[sonichy]

@JonB @jsulm

I found the reason: QProcess->setProgram(sExec), sExec can not contain space, if not will fail to start.
Program and arguments must separated!

sExec = sExec.left(sExec.indexOf(" "));
connect(action, &QAction::triggered, [=](){
    QProcess *process = new QProcess;
    process->setWorkingDirectory(path);
    qDebug() << sExec;
    process->setProgram(sExec);
    process->setArguments(QStringList() << filepath);
    bool b = process->startDetached();
    qDebug() << b;
});

[JonB]

@sonichy said in QString replace %U:

QProcess->setProgram(sExec), sExec can not contain space, if not will fail to start.

Not true. Space in the path to or name of the executable is fine.

Program and arguments must separated!

Which is why I told you earlier

That line is not a program/executable, is it? The first word is the executable and the second word is an argument

And that is why I would like you to read what we write and act on it, not just do nothing about it.....

Whole of your lambda body code with QProcess *process = new QProcess onward could be replaced with just one line:

QProcess::startDetached(sExec, QStringList() << filepath, path);

if you want to avoid the memory leak.