Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Qt Development
  3. General and Desktop
  4. QString replace %U
Forum Updated to NodeBB v4.3 + New Features

QString replace %U

Scheduled Pinned Locked Moved Solved General and Desktop
41 Posts 5 Posters 9.3k Views 1 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • JonBJ JonB

    @sonichy said in QString replace %U:

    This is new problem after modify the code

    Fair enough, I did say you would have see whether it causes problems. This raises a nasty question of what Qt requires the scope/lifetime of the process used in QProcess::startDetached() to be: it cannot be "forever", because we know detached processes survive even exiting the parent program. Maybe it requires it to exist till at least started() signal has been received, I don't know.

    Actually, hang on! The overload of startDetached you are using is bool QProcess::startDetached(const QString &program, const QStringList &arguments, const QString &workingDirectory = QString(), qint64 *pid = nullptr). That is static!

    Soooo:

    • process->setWorkingDirectory(sPath); has no effect (the method signature above takes an optional parameter for the working directory instead).

    • Your QProcess *process = new QProcess; is not used.

    • You can write QProcess::startDetached(sExec, QStringList()); instead, no QProcess instance needed, and no leaking.

    • Given this I find it hard to believe that changing QProcess *process to QProcess process can have any effect....

    sonichyS Offline
    sonichyS Offline
    sonichy
    wrote on last edited by
    #21

    @JonB Two method:
    bool QProcess::startDetached(qint64 *pid = nullptr)

    [static] bool QProcess::startDetached(const QString &program, const QStringList &arguments, const QString &workingDirectory = QString(), qint64 *pid = nullptr)

    And static do not start either.

    QProcess::startDetached(sExec, QStringList(), path);
    
    jsulmJ JonBJ 2 Replies Last reply
    0
    • sonichyS sonichy

      @JonB Two method:
      bool QProcess::startDetached(qint64 *pid = nullptr)

      [static] bool QProcess::startDetached(const QString &program, const QStringList &arguments, const QString &workingDirectory = QString(), qint64 *pid = nullptr)

      And static do not start either.

      QProcess::startDetached(sExec, QStringList(), path);
      
      jsulmJ Offline
      jsulmJ Offline
      jsulm
      Lifetime Qt Champion
      wrote on last edited by
      #22

      @sonichy Please add error handling - QProcess has functionality for that...

      https://forum.qt.io/topic/113070/qt-code-of-conduct

      1 Reply Last reply
      1
      • sonichyS sonichy

        @JonB Two method:
        bool QProcess::startDetached(qint64 *pid = nullptr)

        [static] bool QProcess::startDetached(const QString &program, const QStringList &arguments, const QString &workingDirectory = QString(), qint64 *pid = nullptr)

        And static do not start either.

        QProcess::startDetached(sExec, QStringList(), path);
        
        JonBJ Offline
        JonBJ Offline
        JonB
        wrote on last edited by
        #23

        @sonichy
        Then I do not see that anything you have had so far can have succeeded, but it's most unclear from your comments what that case is.

        As per my previous, could you please show what your qDebug() << sExec; is outputting, instead of making us guess?

        sonichyS 1 Reply Last reply
        0
        • JonBJ JonB

          @sonichy
          Then I do not see that anything you have had so far can have succeeded, but it's most unclear from your comments what that case is.

          As per my previous, could you please show what your qDebug() << sExec; is outputting, instead of making us guess?

          sonichyS Offline
          sonichyS Offline
          sonichy
          wrote on last edited by
          #24

          @JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

          jsulmJ JonBJ 2 Replies Last reply
          0
          • sonichyS sonichy

            @JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

            jsulmJ Offline
            jsulmJ Offline
            jsulm
            Lifetime Qt Champion
            wrote on last edited by
            #25

            @sonichy said in QString replace %U:

            deepin-draw

            This is a relative path. Pass whole path, so it can actually be found...
            And please add error handling...

            https://forum.qt.io/topic/113070/qt-code-of-conduct

            1 Reply Last reply
            1
            • sonichyS sonichy

              @JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

              JonBJ Offline
              JonBJ Offline
              JonB
              wrote on last edited by JonB
              #26

              @sonichy said in QString replace %U:

              @JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

              I previously wrote:

              Is sExec set to the correct full path to the executable? What do you think your process->setWorkingDirectory(path); achieves? Because if you think it is used to locate the executable to run, it is not.

              jsulmJ sonichyS 2 Replies Last reply
              0
              • JonBJ JonB

                @sonichy said in QString replace %U:

                @JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

                I previously wrote:

                Is sExec set to the correct full path to the executable? What do you think your process->setWorkingDirectory(path); achieves? Because if you think it is used to locate the executable to run, it is not.

                jsulmJ Offline
                jsulmJ Offline
                jsulm
                Lifetime Qt Champion
                wrote on last edited by
                #27

                @JonB Yes, it is said that people often do not read carefully...

                https://forum.qt.io/topic/113070/qt-code-of-conduct

                JonBJ 1 Reply Last reply
                1
                • jsulmJ jsulm

                  @JonB Yes, it is said that people often do not read carefully...

                  JonBJ Offline
                  JonBJ Offline
                  JonB
                  wrote on last edited by
                  #28

                  @jsulm
                  It would be nice if questioners answered questions and acted on recommendations before just reposting that something does not work. Makes we wonder sometimes why we bother. If I ask a question and somebody gives some suggestions I act on those carefully before asking again. But that's another topic... :)

                  1 Reply Last reply
                  0
                  • JonBJ JonB

                    @sonichy said in QString replace %U:

                    @JonB deepin-draw "/home/sonichy/Desktop/KuGou.png"

                    I previously wrote:

                    Is sExec set to the correct full path to the executable? What do you think your process->setWorkingDirectory(path); achieves? Because if you think it is used to locate the executable to run, it is not.

                    sonichyS Offline
                    sonichyS Offline
                    sonichy
                    wrote on last edited by sonichy
                    #29

                    @JonB
                    The Linux desktop file installed by root(deb) do not contain Path.
                    And absolute exe path do not work either:

                    /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\"
                    

                    Error handle

                    connect(action, &QAction::triggered, [=](){
                        QProcess *process = new QProcess;
                        //process->setWorkingDirectory(path);
                        qDebug() << sExec;
                        //process->start(sExec); //crash
                        process->setProgram(sExec);
                        connect(process, &QProcess::readyReadStandardError, [=](){
                             qDebug() << process->errorString(); //nothing
                        });
                        bool b = process->startDetached();
                        qDebug() << b; //false
                        //QProcess::startDetached(sExec, QStringList(), path);
                    });
                    
                    JonBJ jsulmJ 2 Replies Last reply
                    0
                    • sonichyS sonichy

                      @JonB
                      The Linux desktop file installed by root(deb) do not contain Path.
                      And absolute exe path do not work either:

                      /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\"
                      

                      Error handle

                      connect(action, &QAction::triggered, [=](){
                          QProcess *process = new QProcess;
                          //process->setWorkingDirectory(path);
                          qDebug() << sExec;
                          //process->start(sExec); //crash
                          process->setProgram(sExec);
                          connect(process, &QProcess::readyReadStandardError, [=](){
                               qDebug() << process->errorString(); //nothing
                          });
                          bool b = process->startDetached();
                          qDebug() << b; //false
                          //QProcess::startDetached(sExec, QStringList(), path);
                      });
                      
                      JonBJ Offline
                      JonBJ Offline
                      JonB
                      wrote on last edited by JonB
                      #30

                      @sonichy

                      • If you mean that qDebug() << sExec; outputs /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" then that is your problem. That line is not a program/executable, is it? The first word is the executable and the second word is an argument (and when passed as an argument it should not then have "s around it). And if that is the case it would have saved a lot of time if you had shown this from the start.

                      • qDebug() << process->errorString(); //nothing This is not what you are supposed to output if you receive some data on standard error, you are supposed to print the data you receive.

                      sonichyS 1 Reply Last reply
                      0
                      • sonichyS sonichy

                        @JonB
                        The Linux desktop file installed by root(deb) do not contain Path.
                        And absolute exe path do not work either:

                        /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\"
                        

                        Error handle

                        connect(action, &QAction::triggered, [=](){
                            QProcess *process = new QProcess;
                            //process->setWorkingDirectory(path);
                            qDebug() << sExec;
                            //process->start(sExec); //crash
                            process->setProgram(sExec);
                            connect(process, &QProcess::readyReadStandardError, [=](){
                                 qDebug() << process->errorString(); //nothing
                            });
                            bool b = process->startDetached();
                            qDebug() << b; //false
                            //QProcess::startDetached(sExec, QStringList(), path);
                        });
                        
                        jsulmJ Offline
                        jsulmJ Offline
                        jsulm
                        Lifetime Qt Champion
                        wrote on last edited by
                        #31

                        @sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
                        "/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
                        So, what do you want to start actually?!

                        https://forum.qt.io/topic/113070/qt-code-of-conduct

                        JonBJ sonichyS 3 Replies Last reply
                        1
                        • jsulmJ jsulm

                          @sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
                          "/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
                          So, what do you want to start actually?!

                          JonBJ Offline
                          JonBJ Offline
                          JonB
                          wrote on last edited by
                          #32

                          @jsulm Who knows....

                          1 Reply Last reply
                          0
                          • jsulmJ jsulm

                            @sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
                            "/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
                            So, what do you want to start actually?!

                            sonichyS Offline
                            sonichyS Offline
                            sonichy
                            wrote on last edited by
                            #33
                            This post is deleted!
                            1 Reply Last reply
                            0
                            • jsulmJ jsulm

                              @sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
                              "/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
                              So, what do you want to start actually?!

                              sonichyS Offline
                              sonichyS Offline
                              sonichy
                              wrote on last edited by
                              #34

                              @jsulm said in QString replace %U:

                              @sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
                              "/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
                              So, what do you want to start actually?!

                              deepin-draw is relative path.
                              google-chrome is absolute path.
                              I make openwith function, I can choose program to start.

                              jsulmJ 1 Reply Last reply
                              0
                              • sonichyS sonichy

                                @jsulm said in QString replace %U:

                                @sonichy I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred
                                "/usr/bin/google-chrome-stable" - I don't get it - didn't you want to start deepin-draw before?
                                So, what do you want to start actually?!

                                deepin-draw is relative path.
                                google-chrome is absolute path.
                                I make openwith function, I can choose program to start.

                                jsulmJ Offline
                                jsulmJ Offline
                                jsulm
                                Lifetime Qt Champion
                                wrote on last edited by jsulm
                                #35

                                @sonichy Third time: add error handling to see why QProcess fails to start the executable...
                                Also, sExec should NOT contain executable and parameter! Parameters to the executable are passed as another QStringList parameter https://doc.qt.io/qt-5/qprocess.html#setArguments

                                https://forum.qt.io/topic/113070/qt-code-of-conduct

                                sonichyS 1 Reply Last reply
                                0
                                • jsulmJ jsulm

                                  @sonichy Third time: add error handling to see why QProcess fails to start the executable...
                                  Also, sExec should NOT contain executable and parameter! Parameters to the executable are passed as another QStringList parameter https://doc.qt.io/qt-5/qprocess.html#setArguments

                                  sonichyS Offline
                                  sonichyS Offline
                                  sonichy
                                  wrote on last edited by
                                  #36

                                  @jsulm said in QString replace %U:

                                  @sonichy Third time: add error handling to see why QProcess fails to start the executable...

                                  Already add.

                                  connect(process, &QProcess::readyReadStandardError, [=](){
                                           qDebug() << process->errorString(); //nothing
                                  });
                                  
                                  jsulmJ JonBJ 2 Replies Last reply
                                  0
                                  • sonichyS sonichy

                                    @jsulm said in QString replace %U:

                                    @sonichy Third time: add error handling to see why QProcess fails to start the executable...

                                    Already add.

                                    connect(process, &QProcess::readyReadStandardError, [=](){
                                             qDebug() << process->errorString(); //nothing
                                    });
                                    
                                    jsulmJ Offline
                                    jsulmJ Offline
                                    jsulm
                                    Lifetime Qt Champion
                                    wrote on last edited by
                                    #37

                                    @sonichy said in QString replace %U:

                                    Already add.

                                    No.
                                    You again did not read what I wrote: "I was talking about https://doc.qt.io/qt-5/qprocess.html#errorOccurred".
                                    I'm out of this thread...

                                    https://forum.qt.io/topic/113070/qt-code-of-conduct

                                    1 Reply Last reply
                                    0
                                    • JonBJ JonB

                                      @sonichy

                                      • If you mean that qDebug() << sExec; outputs /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" then that is your problem. That line is not a program/executable, is it? The first word is the executable and the second word is an argument (and when passed as an argument it should not then have "s around it). And if that is the case it would have saved a lot of time if you had shown this from the start.

                                      • qDebug() << process->errorString(); //nothing This is not what you are supposed to output if you receive some data on standard error, you are supposed to print the data you receive.

                                      sonichyS Offline
                                      sonichyS Offline
                                      sonichy
                                      wrote on last edited by
                                      #38

                                      @JonB said in QString replace %U:

                                      @sonichy

                                      • If you mean that qDebug() << sExec; outputs /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" then that is your problem. That line is not a program/executable, is it? The first word is the executable and the second word is an argument (and when passed as an argument it should not then have "s around it). And if that is the case it would have saved a lot of time if you had shown this from the start.

                                      • qDebug() << process->errorString(); //nothing This is not what you are supposed to output if you receive some data on standard error, you are supposed to print the data you receive.

                                      /usr/bin/google-chrome-stable home/sonichy/Desktop/description.xml
                                      false

                                      Add "*" is to include space in filename.

                                      1 Reply Last reply
                                      0
                                      • sonichyS sonichy

                                        @jsulm said in QString replace %U:

                                        @sonichy Third time: add error handling to see why QProcess fails to start the executable...

                                        Already add.

                                        connect(process, &QProcess::readyReadStandardError, [=](){
                                                 qDebug() << process->errorString(); //nothing
                                        });
                                        
                                        JonBJ Offline
                                        JonBJ Offline
                                        JonB
                                        wrote on last edited by JonB
                                        #39

                                        @sonichy
                                        In my previous post:

                                        • I already told you what you need to do in QProcess::readyReadStandardError, you have not acted on it.

                                        • I already told you that if sExec is /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" (or anything similar, with or without the quotes) that won't work, why it won't work, and what you need to do about it. But you did not answer (and now you have but not acted on what I said). And nor will plain deepin-draw, unless it is on your PATH

                                        I too am done.

                                        sonichyS 1 Reply Last reply
                                        0
                                        • JonBJ JonB

                                          @sonichy
                                          In my previous post:

                                          • I already told you what you need to do in QProcess::readyReadStandardError, you have not acted on it.

                                          • I already told you that if sExec is /usr/bin/google-chrome-stable \"/home/sonichy/Desktop/description.xml\" (or anything similar, with or without the quotes) that won't work, why it won't work, and what you need to do about it. But you did not answer (and now you have but not acted on what I said). And nor will plain deepin-draw, unless it is on your PATH

                                          I too am done.

                                          sonichyS Offline
                                          sonichyS Offline
                                          sonichy
                                          wrote on last edited by sonichy
                                          #40

                                          @JonB @jsulm

                                          I found the reason: QProcess->setProgram(sExec), sExec can not contain space, if not will fail to start.
                                          Program and arguments must separated!

                                          sExec = sExec.left(sExec.indexOf(" "));
                                          connect(action, &QAction::triggered, [=](){
                                              QProcess *process = new QProcess;
                                              process->setWorkingDirectory(path);
                                              qDebug() << sExec;
                                              process->setProgram(sExec);
                                              process->setArguments(QStringList() << filepath);
                                              bool b = process->startDetached();
                                              qDebug() << b;
                                          });
                                          
                                          JonBJ 1 Reply Last reply
                                          0

                                          • Login

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular
                                          • Users
                                          • Groups
                                          • Search
                                          • Get Qt Extensions
                                          • Unsolved