InsertRow

JonB

@Duy-Khang
At last! A QSqlQueryModel is for querying SQL, it does not allow insertions, because it does not know where to insert any rows. It sounds like you should switch to a QSqlTableModel for inserts etc.? I assume the rows you show are all in one table, which is where you want to insert/update/delete rows.

Duy Khang

oh,I don't know that before and how to insert new row if i use QSqlTableModel ?

JonB

@Duy-Khang
The code you showed would work if the model is a QSqlTableModel instead of a QSqlQueryModel, and you have specified the table. You can search https://doc.qt.io/qt-5/qsqltablemodel.html and https://doc.qt.io/qt-5/qsqltablemodel-members.html for insertRow and see what you come across. There is also QSqlTableModel::insertRecord() etc. if you prefer a record-based interface to a row-based interface, that is a matter of preference.

BTW you don't need to worry about/implement the beginInsertRows() etc. you asked about if you use a QSqlTableModel, its implementation handles that for you.

Duy Khang

and QSqlTableModel can not setQuery() how to do this ?

JonB

@Duy-Khang
Please read the documentation rather than asking each time. It is beneficial to you to understand, not just be told. There is even an example at https://doc.qt.io/qt-5/qsqltablemodel.html#details.

Duy Khang

Thank you very much

Duy Khang

@JonB

do you know how to disable or turn off the these indexs in this picture ?

Christian Ehrlicher

@Duy-Khang said in InsertRow:

do you know how to disable or turn off the these indexs in this picture ?

Hide the horizontal and vertical header.

JonB

@Duy-Khang
~~If that column is in the table but you don't want to show it, use void QTableView::hideColumn(int column) to suppress it in your view.~~

Oh, I misunderstood what you were wanting to hide in your picture! I thought you meant the first column!

In which case it's the horizontal header as @Christian-Ehrlicher has pointed you to.

Duy Khang

@Christian-Ehrlicher thank you.

Duy Khang

@JonB yes, thank you, it works

Duy Khang

@JonB hi,

how can i change the name of column in picture ?

SGaist

What names do you want there ?

Duy Khang

@SGaist hi, how can I insert a row after the current row, assuming we don't have any rows at first, I use QSqlTableModel.

SGaist

The same as usual.

As for setting the header data, it's shown in the QSqlTableModel documentation.

Duy Khang

yes, i have done it and then how can I insert a row after the current row, assuming we don't have any rows at first, I use QSqlTableModel.

SGaist

What issue do you have with using insertRow ?

JonB

@Duy-Khang said in InsertRow:

how can I insert a row after the current row, assuming we don't have any rows at first

In addition to what @SGaist has been saying, how do you have a "current" row to insert after if you don't have any rows to start with?

ArthurPYQT

import sys

from PyQt5.QtWidgets import QWidget, QApplication,QTableView, QVBoxLayout,QPushButton
from PyQt5.QtSql import QSqlDatabase, QSqlQuery, QSqlTableModel,QSqlRecord

class demo(QWidget):
    def __init__(self):
        super().__init__()
        lyt = QVBoxLayout()
        self.setLayout(lyt)
        tview = QTableView()
        btn = QPushButton('add')
        lyt.addWidget(tview)
        lyt.addWidget(btn)
        db = QSqlDatabase.addDatabase("QSQLITE")
        db.setDatabaseName(r"xxx.db")
        self.model = testModel(db)
        tview.setModel(self.model)
        btn.clicked.connect(self.insertNewRecord)
    
    def insertNewRecord(self):
        r = QSqlRecord()
        r.setValue('name', 'hello')
        r.setValue('age', 23)

        if self.model.insertRecord(0, r):

            print(self.model.submitAll())
            print(self.model.lastError().text())
        else:
            self.model.db.rollback()
            print(self.model.lastError().text())
        self.model.select()
        
class testModel(QSqlTableModel):
    def __init__(self, db):
        super().__init__()
        self.db = db
     
        print(self.db.open())
        self.setTable('test')
        self.setEditStrategy(QSqlTableModel.OnManualSubmit)
        print(self.select())
        print(self.lastError().text())
        print(self.tableName())

if __name__ == '__main__':
    app = QApplication(sys.argv)
    t = demo()
    t.show()
    sys.exit(app.exec())

data is displayed properly, but when i try to insertRecord, something wrong "No fields to update ". tableview not updated, let alone the database.

how to insert a record into the table?

JonB

@ArthurPYQT
Since you call print(self.model.lastError().text()) both when insertRecord(0, r) succeeds and when it fails, do you want to tell us (actually prove) which route your code is following...?