Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Qt Development
  3. General and Desktop
  4. Increasing usage for C++ new operators based on data model indexes?
QtWS25 Last Chance

Increasing usage for C++ new operators based on data model indexes?

Scheduled Pinned Locked Moved Unsolved General and Desktop
data modelscreateindexallocationnew operatorssoftware design
116 Posts 6 Posters 51.3k Views
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • E elfring

    …, however I still don't see how you're going to have a generic type (i.e. QAbstractItemModel) that deals with concrete types it does know nothing about ...

    Various data structures are accessible over pointers (or customised indexes?).

    Does the class “QVariant” provide also a programming interface for pointer data types?

    …, the placement new if you're crazy enough to build your own heap manager (or for some very specific similar purposes), …

    I am trying to increase the software development attention for the latter.

    VRoninV Offline
    VRoninV Offline
    VRonin
    wrote on last edited by VRonin
    #21

    @elfring said in Increasing usage for C++ new operators based on data model indexes?:

    Does the class “QVariant” provide also a programming interface for pointer data types?

    Yes using QVariant::fromValue or via the constructor if the type is a QObject subclass.
    hic sunt leones though as you need to make clear in your logic who owns the items pointed. In general a QVariant containing a owning pointer is a ticking time bomb toward memory leak and/or double deletion.

    I prefer to avoid null pointers which can eventually be returned by such a cast operation.

    If you are certain of the downcast type you can even use static_cast and forget about null pointers

    "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
    ~Napoleon Bonaparte

    On a crusade to banish setIndexWidget() from the holy land of Qt

    E 1 Reply Last reply
    1
    • VRoninV VRonin

      @elfring said in Increasing usage for C++ new operators based on data model indexes?:

      Does the class “QVariant” provide also a programming interface for pointer data types?

      Yes using QVariant::fromValue or via the constructor if the type is a QObject subclass.
      hic sunt leones though as you need to make clear in your logic who owns the items pointed. In general a QVariant containing a owning pointer is a ticking time bomb toward memory leak and/or double deletion.

      I prefer to avoid null pointers which can eventually be returned by such a cast operation.

      If you are certain of the downcast type you can even use static_cast and forget about null pointers

      E Offline
      E Offline
      elfring
      wrote on last edited by
      #22

      In general a QVariant containing a owning pointer is a ticking time bomb toward memory leak and/or double deletion.

      • The safe handling of object lifetimes is a general software development challenge.
      • But this class is the only way to get data from a model so far, isn't it?

      If you are certain of the downcast type you can even use static_cast and forget about null pointers

      Can it be more convenient to let a C++ new operator (which can work also with extra allocation parameters directly) perform the desired data type conversion?

      VRoninV 1 Reply Last reply
      0
      • E elfring

        In general a QVariant containing a owning pointer is a ticking time bomb toward memory leak and/or double deletion.

        • The safe handling of object lifetimes is a general software development challenge.
        • But this class is the only way to get data from a model so far, isn't it?

        If you are certain of the downcast type you can even use static_cast and forget about null pointers

        Can it be more convenient to let a C++ new operator (which can work also with extra allocation parameters directly) perform the desired data type conversion?

        VRoninV Offline
        VRoninV Offline
        VRonin
        wrote on last edited by
        #23

        @elfring said in Increasing usage for C++ new operators based on data model indexes?:

        The safe handling of object lifetimes is a general software development challenge.
        But this class is the only way to get data from a model so far, isn't it?

        Yes, what I'm saying is that if you want to store a pointer in a QVariant you probably want a non-owning pointer. Keep the owning pointer somewhere else.

        Can it be more convenient to let a C++ new operator (which can work also with extra allocation parameters directly) perform the desired data type conversion?

        No, new allocates memory. static_cast just tell the compiler to treat a piece of memory as it was a different type.

        But this class is the only way to get data from a model so far, isn't it?

        And here we come back to the fact that having your objects implicitly shared stored in a QVariant directly is much more practical and has a negligible impact on performance

        "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
        ~Napoleon Bonaparte

        On a crusade to banish setIndexWidget() from the holy land of Qt

        E 1 Reply Last reply
        1
        • VRoninV VRonin

          @elfring said in Increasing usage for C++ new operators based on data model indexes?:

          The safe handling of object lifetimes is a general software development challenge.
          But this class is the only way to get data from a model so far, isn't it?

          Yes, what I'm saying is that if you want to store a pointer in a QVariant you probably want a non-owning pointer. Keep the owning pointer somewhere else.

          Can it be more convenient to let a C++ new operator (which can work also with extra allocation parameters directly) perform the desired data type conversion?

          No, new allocates memory. static_cast just tell the compiler to treat a piece of memory as it was a different type.

          But this class is the only way to get data from a model so far, isn't it?

          And here we come back to the fact that having your objects implicitly shared stored in a QVariant directly is much more practical and has a negligible impact on performance

          E Offline
          E Offline
          elfring
          wrote on last edited by
          #24

          new allocates memory.

          Only if you do not use the construct “placement new”.

          And here we come back to the fact that having your objects implicitly shared stored in a QVariant directly is much more practical

          I guess that the run time consequences are more interesting then for the distinction if only pointers are transferred or complete “value objects” are copied.

          and has a negligible impact on performance

          There are software applications where more data transfers might not have a directly noticeable effect. But I guess that some C++ programmers have got a strong focus on software efficiency.

          kshegunovK VRoninV 2 Replies Last reply
          0
          • E elfring

            new allocates memory.

            Only if you do not use the construct “placement new”.

            And here we come back to the fact that having your objects implicitly shared stored in a QVariant directly is much more practical

            I guess that the run time consequences are more interesting then for the distinction if only pointers are transferred or complete “value objects” are copied.

            and has a negligible impact on performance

            There are software applications where more data transfers might not have a directly noticeable effect. But I guess that some C++ programmers have got a strong focus on software efficiency.

            kshegunovK Offline
            kshegunovK Offline
            kshegunov
            Moderators
            wrote on last edited by
            #25

            This is getting pretty ridiculous ...

            @elfring said in Increasing usage for C++ new operators based on data model indexes?:

            Only if you do not use the construct “placement new”.

            Yeah, which I have a creeping suspicion you haven't. The so called placement new is nothing more than going around calling constructors on a preallocated memory block. So where is this preallocated memory going to come from? It's going to materialize from the ether?

            If you're intent on pushing this make-you-own-heap-for-models, I advise to create a proof-of-concept first, then we can have something to base a discussion on, otherwise - thanks but no thanks, I'm out of this conversation.

            Read and abide by the Qt Code of Conduct

            E 1 Reply Last reply
            0
            • kshegunovK kshegunov

              This is getting pretty ridiculous ...

              @elfring said in Increasing usage for C++ new operators based on data model indexes?:

              Only if you do not use the construct “placement new”.

              Yeah, which I have a creeping suspicion you haven't. The so called placement new is nothing more than going around calling constructors on a preallocated memory block. So where is this preallocated memory going to come from? It's going to materialize from the ether?

              If you're intent on pushing this make-you-own-heap-for-models, I advise to create a proof-of-concept first, then we can have something to base a discussion on, otherwise - thanks but no thanks, I'm out of this conversation.

              E Offline
              E Offline
              elfring
              wrote on last edited by
              #26

              The so called placement new is nothing more than going around calling constructors on a preallocated memory block.

              I agree on this aspect.

              But can you pass a “model index” as another allocation parameter (for existing data) to this C++ operator?

              1 Reply Last reply
              0
              • E elfring

                new allocates memory.

                Only if you do not use the construct “placement new”.

                And here we come back to the fact that having your objects implicitly shared stored in a QVariant directly is much more practical

                I guess that the run time consequences are more interesting then for the distinction if only pointers are transferred or complete “value objects” are copied.

                and has a negligible impact on performance

                There are software applications where more data transfers might not have a directly noticeable effect. But I guess that some C++ programmers have got a strong focus on software efficiency.

                VRoninV Offline
                VRoninV Offline
                VRonin
                wrote on last edited by VRonin
                #27

                @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                Only if you do not use the construct “placement new”.

                Is your plan to do exactly what dynamic_cast does but using a new operator? I mean it's possible but I don't see why you'd want to do it. How would you implement it?

                guess that the run time consequences are more interesting then for the distinction if only pointers are transferred or complete “value objects” are copied.
                There are software applications where more data transfers might not have a directly noticeable effect. But I guess that some C++ programmers have got a strong focus on software efficiency.

                @VRonin said in Increasing usage for C++ new operators based on data model indexes?:

                having your objects implicitly shared

                With implicitly shared objects, the distinction from a pointer to a complete value object when copying is just an operator++ on an int. 1 atomic instruction. 100000 times more efficient than a dynamic_cast.
                If you want to go into memory difference it's 32bits more. If 32 bits break your design then it's the design itself that comes into question

                "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
                ~Napoleon Bonaparte

                On a crusade to banish setIndexWidget() from the holy land of Qt

                E 1 Reply Last reply
                0
                • VRoninV VRonin

                  @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                  Only if you do not use the construct “placement new”.

                  Is your plan to do exactly what dynamic_cast does but using a new operator? I mean it's possible but I don't see why you'd want to do it. How would you implement it?

                  guess that the run time consequences are more interesting then for the distinction if only pointers are transferred or complete “value objects” are copied.
                  There are software applications where more data transfers might not have a directly noticeable effect. But I guess that some C++ programmers have got a strong focus on software efficiency.

                  @VRonin said in Increasing usage for C++ new operators based on data model indexes?:

                  having your objects implicitly shared

                  With implicitly shared objects, the distinction from a pointer to a complete value object when copying is just an operator++ on an int. 1 atomic instruction. 100000 times more efficient than a dynamic_cast.
                  If you want to go into memory difference it's 32bits more. If 32 bits break your design then it's the design itself that comes into question

                  E Offline
                  E Offline
                  elfring
                  wrote on last edited by
                  #28

                  Is your plan to do exactly what dynamic_cast does but using a new operator?

                  Maybe.

                  But these C++ operations provide different functionality, don't they?

                  With implicitly shared objects, the distinction from a pointer to a complete value object when copying is just an operator++ on an int.

                  Will it become nicer to avoid (or reduce) even the influence of object reference counting?

                  VRoninV 1 Reply Last reply
                  0
                  • E elfring

                    Is your plan to do exactly what dynamic_cast does but using a new operator?

                    Maybe.

                    But these C++ operations provide different functionality, don't they?

                    With implicitly shared objects, the distinction from a pointer to a complete value object when copying is just an operator++ on an int.

                    Will it become nicer to avoid (or reduce) even the influence of object reference counting?

                    VRoninV Offline
                    VRoninV Offline
                    VRonin
                    wrote on last edited by
                    #29

                    @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                    Will it become nicer to avoid (or reduce) even the influence of object reference counting?

                    C++ is moving in the opposite direction actually. If you try to suggest replacing std::shared_ptr (which is a pointer + a reference counter) with raw pointers on Stack Overflow you'd better bring a helmet and kevlar vest because you are going to get shot.
                    The ISO C++ style guide goes one step further and even discourages the use of owning raw pointer and suggest ownership encapsulation (an implicitly shared object behaves as a smart pointer). If you don't like it, good luck convincing Herb Sutter and Bjarne Stroustrup himself.

                    But these C++ operations provide different functionality, don't they?

                    Yes but so far you did not highlight any need for custom allocation, your problems all seem to come from casting.

                    "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
                    ~Napoleon Bonaparte

                    On a crusade to banish setIndexWidget() from the holy land of Qt

                    E 1 Reply Last reply
                    2
                    • VRoninV VRonin

                      @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                      Will it become nicer to avoid (or reduce) even the influence of object reference counting?

                      C++ is moving in the opposite direction actually. If you try to suggest replacing std::shared_ptr (which is a pointer + a reference counter) with raw pointers on Stack Overflow you'd better bring a helmet and kevlar vest because you are going to get shot.
                      The ISO C++ style guide goes one step further and even discourages the use of owning raw pointer and suggest ownership encapsulation (an implicitly shared object behaves as a smart pointer). If you don't like it, good luck convincing Herb Sutter and Bjarne Stroustrup himself.

                      But these C++ operations provide different functionality, don't they?

                      Yes but so far you did not highlight any need for custom allocation, your problems all seem to come from casting.

                      E Offline
                      E Offline
                      elfring
                      wrote on last edited by
                      #30

                      but so far you did not highlight any need for custom allocation,

                      I suggest to reconsider the software situation once more.

                      A pair of row and column values (data model index, address or coordinate) can be passed as a parameter to a C++ new operator.
                      You can choose then if you need to work with fresh objects (using dynamic memory allocation) or would like to reuse existing data.

                      Is the usage of the construct “placement new” a kind of customised operation?

                      your problems all seem to come from casting.

                      I hope that specific software development challenges can be adjusted when the new operator call takes care of casting to the desired target (pointer) data type already.

                      VRoninV 1 Reply Last reply
                      0
                      • E elfring

                        but so far you did not highlight any need for custom allocation,

                        I suggest to reconsider the software situation once more.

                        A pair of row and column values (data model index, address or coordinate) can be passed as a parameter to a C++ new operator.
                        You can choose then if you need to work with fresh objects (using dynamic memory allocation) or would like to reuse existing data.

                        Is the usage of the construct “placement new” a kind of customised operation?

                        your problems all seem to come from casting.

                        I hope that specific software development challenges can be adjusted when the new operator call takes care of casting to the desired target (pointer) data type already.

                        VRoninV Offline
                        VRoninV Offline
                        VRonin
                        wrote on last edited by
                        #31

                        @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                        A pair of row and column values (data model index, address or coordinate) can be passed as a parameter to a C++ new operator.
                        You can choose then if you need to work with fresh objects (using dynamic memory allocation) or would like to reuse existing data.
                        Is the usage of the construct “placement new” a kind of customised operation?

                        Once again, the model implementation might or might not allocate data. This should not be a problem of the API user.

                        Could you please provide a concrete example of what you are suggesting?
                        Otherwise we are just discussing of theory and nobody is gaining any value out of it.
                        I will not continue the discussion until you provide at least a code snippet

                        "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
                        ~Napoleon Bonaparte

                        On a crusade to banish setIndexWidget() from the holy land of Qt

                        E 2 Replies Last reply
                        3
                        • VRoninV VRonin

                          @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                          A pair of row and column values (data model index, address or coordinate) can be passed as a parameter to a C++ new operator.
                          You can choose then if you need to work with fresh objects (using dynamic memory allocation) or would like to reuse existing data.
                          Is the usage of the construct “placement new” a kind of customised operation?

                          Once again, the model implementation might or might not allocate data. This should not be a problem of the API user.

                          Could you please provide a concrete example of what you are suggesting?
                          Otherwise we are just discussing of theory and nobody is gaining any value out of it.
                          I will not continue the discussion until you provide at least a code snippet

                          E Offline
                          E Offline
                          elfring
                          wrote on last edited by
                          #32

                          Could you please provide a concrete example of what you are suggesting?

                          Does the software situation become really more challenging for passing a few extra parameters to a (member) function when it is “accidentally” (or intentionally) called “new”?

                          1 Reply Last reply
                          0
                          • VRoninV VRonin

                            @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                            A pair of row and column values (data model index, address or coordinate) can be passed as a parameter to a C++ new operator.
                            You can choose then if you need to work with fresh objects (using dynamic memory allocation) or would like to reuse existing data.
                            Is the usage of the construct “placement new” a kind of customised operation?

                            Once again, the model implementation might or might not allocate data. This should not be a problem of the API user.

                            Could you please provide a concrete example of what you are suggesting?
                            Otherwise we are just discussing of theory and nobody is gaining any value out of it.
                            I will not continue the discussion until you provide at least a code snippet

                            E Offline
                            E Offline
                            elfring
                            wrote on last edited by
                            #33

                            … concrete example of what you are suggesting?

                            • https://isocpp.org/wiki/faq/dtors#placement-new
                            • https://en.wikipedia.org/wiki/Placement_syntax
                            • https://stackoverflow.com/questions/222557/what-uses-are-there-for-placement-new
                            • https://www.geeksforgeeks.org/placement-new-operator-cpp/
                            • http://blog.aaronballman.com/2011/08/the-placement-new-operator/
                            • https://thispointer.com/whats-placement-new-operator-and-why-do-we-need-it/
                            • https://eli.thegreenplace.net/2011/02/17/the-many-faces-of-operator-new-in-c
                            • https://archive.org/details/TICPP2ndEdVolOne
                            1 Reply Last reply
                            0
                            • sierdzioS Offline
                              sierdzioS Offline
                              sierdzio
                              Moderators
                              wrote on last edited by
                              #34

                              The first link clearly states:

                              ADVICE: Don’t use this “placement new” syntax unless you have to. Use it only when you really care that an object is placed at a particular location in memory. For example, when your hardware has a memory-mapped I/O timer device, and you want to place a Clock object at that memory location.

                              In case of model indexes, there seems to be no need to use placement new.

                              (Z(:^

                              E 1 Reply Last reply
                              5
                              • sierdzioS sierdzio

                                The first link clearly states:

                                ADVICE: Don’t use this “placement new” syntax unless you have to. Use it only when you really care that an object is placed at a particular location in memory. For example, when your hardware has a memory-mapped I/O timer device, and you want to place a Clock object at that memory location.

                                In case of model indexes, there seems to be no need to use placement new.

                                E Offline
                                E Offline
                                elfring
                                wrote on last edited by
                                #35

                                In case of model indexes, there seems to be no need to use placement new.

                                • Do you care if customised model data were “placed at a particular location in memory”?
                                • How do you think about to get direct access to object data which are managed by a class like QVariant?
                                sierdzioS 1 Reply Last reply
                                0
                                • E elfring

                                  In case of model indexes, there seems to be no need to use placement new.

                                  • Do you care if customised model data were “placed at a particular location in memory”?
                                  • How do you think about to get direct access to object data which are managed by a class like QVariant?
                                  sierdzioS Offline
                                  sierdzioS Offline
                                  sierdzio
                                  Moderators
                                  wrote on last edited by
                                  #36

                                  @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                                  In case of model indexes, there seems to be no need to use placement new.

                                  • Do you care if customised model data were “placed at a particular location in memory”?

                                  No I don't.

                                  • How do you think about to get direct access to object data which are managed by a class like QVariant?

                                  I don't understand the question. Accessing data of a QVariant is possible and trivial, if necessary.

                                  (Z(:^

                                  E 1 Reply Last reply
                                  4
                                  • sierdzioS sierdzio

                                    @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                                    In case of model indexes, there seems to be no need to use placement new.

                                    • Do you care if customised model data were “placed at a particular location in memory”?

                                    No I don't.

                                    • How do you think about to get direct access to object data which are managed by a class like QVariant?

                                    I don't understand the question. Accessing data of a QVariant is possible and trivial, if necessary.

                                    E Offline
                                    E Offline
                                    elfring
                                    wrote on last edited by
                                    #37

                                    Accessing data of a QVariant is possible and trivial, if necessary.

                                    Can the data access become more convenient (and safe) for customised data types?

                                    VRoninV 1 Reply Last reply
                                    0
                                    • E elfring

                                      Accessing data of a QVariant is possible and trivial, if necessary.

                                      Can the data access become more convenient (and safe) for customised data types?

                                      VRoninV Offline
                                      VRoninV Offline
                                      VRonin
                                      wrote on last edited by
                                      #38

                                      @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                                      Can the data access become more convenient (and safe) for customised data types?

                                      No.
                                      get->change->set is mildly less convenient but infinitely safer.

                                      Can you think of an example code, and paste it below, where it would?

                                      "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
                                      ~Napoleon Bonaparte

                                      On a crusade to banish setIndexWidget() from the holy land of Qt

                                      E 1 Reply Last reply
                                      1
                                      • VRoninV VRonin

                                        @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                                        Can the data access become more convenient (and safe) for customised data types?

                                        No.
                                        get->change->set is mildly less convenient but infinitely safer.

                                        Can you think of an example code, and paste it below, where it would?

                                        E Offline
                                        E Offline
                                        elfring
                                        wrote on last edited by
                                        #39

                                        Can you think of an example code, and paste it below, where it would?

                                        I suggest to take another look at a specific implementation detail: How many function calls do you need finally to get access to a member variable within a customised data model so far?

                                        VRoninV 1 Reply Last reply
                                        0
                                        • E elfring

                                          Can you think of an example code, and paste it below, where it would?

                                          I suggest to take another look at a specific implementation detail: How many function calls do you need finally to get access to a member variable within a customised data model so far?

                                          VRoninV Offline
                                          VRoninV Offline
                                          VRonin
                                          wrote on last edited by VRonin
                                          #40

                                          @elfring said in Increasing usage for C++ new operators based on data model indexes?:

                                          How many function calls do you need finally to get access to a member variable within a customised data model so far?

                                          2 chained. QModelIndex::data and QVariant::value<T>. e.g.: index.data().value<QString>();. Don't think you can do better.
                                          Can you show us how would your new implementation look? Call this a test. You haven't wrote a single line of code in all your posts. I want to check that at least you have a rough idea of what you are talking about

                                          "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
                                          ~Napoleon Bonaparte

                                          On a crusade to banish setIndexWidget() from the holy land of Qt

                                          E 1 Reply Last reply
                                          4

                                          • Login

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular
                                          • Users
                                          • Groups
                                          • Search
                                          • Get Qt Extensions
                                          • Unsolved