Translate QDialogButtonBox

Exotic_Devel

I'm getting warnings

../../../TecTracker/Core/gui/connecdialog.cpp: In constructor 'Connecdialog::Connecdialog(QWidget*)':
../../../TecTracker/Core/gui/connecdialog.cpp:34:48: warning: statement has no effect [-Wunused-value]
QT_TRANSLATE_NOOP("QPlatformTheme", "Cancel");
^
../../../TecTracker/Core/gui/connecdialog.cpp:35:47: warning: statement has no effect [-Wunused-value]
QT_TRANSLATE_NOOP("QPlatformTheme", "Apply");
^
../../../TecTracker/Core/gui/connecdialog.cpp:36:46: warning: statement has no effect [-Wunused-value]
QT_TRANSLATE_NOOP("QPlatformTheme", "&Yes");
^
../../../TecTracker/Core/gui/connecdialog.cpp:37:45: warning: statement has no effect [-Wunused-value]
QT_TRANSLATE_NOOP("QPlatformTheme", "&No");
^
../../../TecTracker/Core/gui/connecdialog.cpp:38:44: warning: statement has no effect [-Wunused-value]
QT_TRANSLATE_NOOP("QPlatformTheme", "Ok");
^

cincirin

Yes, that's correct because you didn't use the returned char*, it's a compiler warning, but not an error.
Put an Q_UNUSED macro in front of every QT_TRANSLATE_NOOP and the warning is off:
Q_UNUSED(QT_TRANSLATE_NOOP(...))

Exotic_Devel

Sorry for raising the topic, i was kinda busy.

In my test did not work

@int main(int argc, char *argv[])
{
QApplication app(argc, argv);
QTranslator translation;
translation.load("translations/core_connecdialog_ptBr.ts");

Testdataaccess testdataaccess(&app);
Testconnecdialog testconnecdialog(&app);
Testdynamicqtwidgets testedynamicqtwidgets(&app);

//QTest::qExec(&testedynamicqtwidgets, argc, argv);
//QTest::qExec(&testdataaccess, argc, argv);
QTest::qExec(&testconnecdialog, argc, argv);

app.installTranslator(&translation);
app.exec();
}@

.ts files can be used directly @translation.load("translations/core_connecdialog_ptBr.ts")@ or is necessary to run lrelease?

SGaist

ts files are "internationalization sources". You have to run lrelease to get the file for QTranslator to use.

Exotic_Devel

Ok, I run lrelease, qm file was generated, however, nothing was translated. Everything is still in English.

My main.cpp

@int main(int argc, char *argv[])
{
QApplication app(argc, argv);
QTranslator translation;
translation.load("translations/core_connecdialog_ptBr");

Testdataaccess testdataaccess(&app);
Testconnecdialog testconnecdialog(&app);
Testdynamicqtwidgets testedynamicqtwidgets(&app);

//QTest::qExec(&testedynamicqtwidgets, argc, argv);
//QTest::qExec(&testdataaccess, argc, argv);
QTest::qExec(&testconnecdialog, argc, argv);

app.installTranslator(&translation);
app.exec();
}
@

!http://i60.tinypic.com/wh1c48.png(MyLinguist)!

cincirin

Basically you have two errors:
a) check the return value of translation.load(...) to be sure the translation is correctly loaded
b) I'm not 100% sure about this, but you call installTranslator after your Ui is created. I think in this way you'll have to retranslate the Ui (check dynamic translation in the docs). Anyway, try to move installTranslator before the widgets are created

Exotic_Devel

Ok, worked

@int main(int argc, char *argv[])
{
QApplication app(argc, argv);
QTranslator translation;

translation.load("translations/core_connecdialog_ptBr");

app.installTranslator(&translation);

Testdataaccess testdataaccess(&app);
Testconnecdialog testconnecdialog(&app);
Testdynamicqtwidgets testedynamicqtwidgets(&app);

//QTest::qExec(&testedynamicqtwidgets, argc, argv);
//QTest::qExec(&testdataaccess, argc, argv);
QTest::qExec(&testconnecdialog, argc, argv);

app.exec();
}
@

but QDialogButtonBox is not translated.
I added QT_TRANSLATE_NOOP, did the translation with Qt Linguist. But still in english.

!http://i60.tinypic.com/2nsary8.png(QDialogButtonBox)!

SGaist

Do you have

@translation.load("translations/core_connecdialog_ptBr");@

in the same folder as your executable ?

cincirin

@Exotic_Devel: your linguist seems to be un-translated. If I look at ConecConfDialog source there are 0(zero) items translated from 7. The same for QPlatformTheme, there are 0(zero) items from 5 translated.

So, I don't know how your binary application is ever translated. Maybe it is looking for other "lrelease"-ed translation ? (not the one from screenshot)

edit: make sure you save the linguist translation before the "lrelease"

Exotic_Devel

Ok, in Qt Linguist lacked [Translation] => [Done and Next] menu, but is still without translation. Below the images.

!http://i61.tinypic.com/34tea2e.png(mylinguist)!
!http://i58.tinypic.com/6teqlj.png(mydir)!
!http://i59.tinypic.com/21lr3ps.png(mydir2)!

Exotic_Devel

Ok, in Qt Linguist lacked [Translation] => [Done and Next] menu, but is still without translation. Below the images.

!http://i61.tinypic.com/34tea2e.png(mylinguist)!
!http://i58.tinypic.com/6teqlj.png(mydir)!
!http://i59.tinypic.com/21lr3ps.png(mydir2)!

Exotic_Devel

Saved and used again lrelease

Exotic_Devel

Saved and used again lrelease

Exotic_Devel

Unfortunately the solution with QT_TRANSLATE_NOOP did not solve. I opted for the solution mentioned by SGaist.

@qdbb_okcancel->button(QDialogButtonBox::Cancel)->setText(tr("&Cancel"));
@

Now the translation works well

Thank you all

Exotic_Devel

Unfortunately the solution with QT_TRANSLATE_NOOP did not solve. I opted for the solution mentioned by SGaist.

@qdbb_okcancel->button(QDialogButtonBox::Cancel)->setText(tr("&Cancel"));
@

Now the translation works well

Thank you all