Libqpsd - Qt/C++ plugin for Photoshop Document (PSD/PSB )
-
[quote author="asgohtals" date="1366364540"]hi,
i have added some psbs to our ftp:
"ftp://scruffy.caa.tuwien.ac.at/staff/diem/small-psb.zip":ftp://scruffy.caa.tuwien.ac.at/staff/diem/small-psb.zip
"ftp://scruffy.caa.tuwien.ac.at/staff/diem/not-that-small-psb.zip":ftp://scruffy.caa.tuwien.ac.at/staff/diem/not-that-small-psb.zip
the zips contain 3 images in Lab, CMYK and quadtoneI hope they are of use for you.
[/quote]
Thank you again for there images! They were all very nice and libqpsd were able to read them!
However, there still a bug in the Lab to RGB conversion and several pixels in the "wall-small-Lab.psb" are MISCALCULATED. The conversion algorithm were contributed by Yuezhao and we still don't have a perfect reference for the method other than "EasyRGB.com":http://www.easyrgb.com/
Morever, I will update the libqpsd repository tonight :) Feel free to check it.
-
I have found a psd (CMYK) with wrong color conversions:
"ftp://scruffy.caa.tuwien.ac.at/staff/diem/libpsd-cmyk.zip":ftp://scruffy.caa.tuwien.ac.at/staff/diem/libpsd-cmyk.zip
we currently use the lipqpsd version from the ~17.04.2013 unfortunately, I cannot test it with the current github version as imageData.size() (qpsdhandler.cpp::730) is 0 for this image (did some interfaces change except for the refactoring?). -
[quote author="asgohtals" date="1368800361"]I have found a psd (CMYK) with wrong color conversions:
"ftp://scruffy.caa.tuwien.ac.at/staff/diem/libpsd-cmyk.zip":ftp://scruffy.caa.tuwien.ac.at/staff/diem/libpsd-cmyk.zip
we currently use the lipqpsd version from the ~17.04.2013 unfortunately, I cannot test it with the current github version as imageData.size() (qpsdhandler.cpp::730) is 0 for this image (did some interfaces change except for the refactoring?).
[/quote]Thank you for the image file. I just found out that it has 5 channels: cyan, magenta, yellow, key, and alpha... which is not actually tested with a real psd file. The original code takes the image in the arrangement A-C-M-Y-K which is incorrect. It should be C-M-Y-K-A. I just updated it with the bug fix.
The new code should be working... to be sure try building it with the following lines uncommented:
@
qpsdhandler.cpp::25 //#include <QDebug>
qpsdhandler.cpp::372-382 //#verification
@If possible, use it on Qt Creator to get the debug output (when opening a psd file) then send me those outputs. Thanks.
EDIT: Possible reason for imageData.size() becoming zero was that it falls under "Zip with/without prediction" type of compression. Currently, it ONLY supports Raw and RLE.
-
hi again,
you have added:
@if (format() == "psd") { // line 266...@to distinguish between psd/psb. The problem is, that we provide QPsdHandler directly with a buffer. Hence, the format() returns an empty string. Then, the compression value is loaded wrongly since in qpsdhandler.cpp::269 the skipRawData command is not executed. -However, for some cases (e.g. file prefetching) it would be cool to be able to call QPsdHandler with (already) loaded buffers.-
EDIT: now that I have found how to set the 'format' properly, we can work with buffers & whatever we want...
The call that didn't work was something like that (without line 10):
@
bool DkBasicLoader::loadPSDFile(QFileInfo fileInfo) {QFile file(fileInfo.absoluteFilePath());
file.open(QIODevice::ReadOnly);QPsdHandler psdHandler;
psdHandler.setDevice(&file); // QFile is an IODevice// EDIT: fixes the issues described:
psdHandler.setFormat(fileInfo.suffix().toLocal8Bit());if (psdHandler.canRead(&file))
return psdHandler.read(&this->qImg);return false;
}
@by the way, thanks for the fast CMYKA fix : )
-
[quote author="asgohtals" date="1369139349"]hi again,
you have added:
@if (format() == "psd") { // line 266...@ [/quote]Yeah, I added it since the "psb" update. There is a difference between "Layer and Mask Info Length" of PSD (4 bytes) and PSB (8 bytes) files. I can't find a workaround yet.... but I think the possible solution is to modify the "switch()" statement at line 186 into this:
@ //Line 186
switch (version) {
case 1: setFormat("psd");
break;
case 2: setFormat("psb");
break;
default: return false;
break;
}
@I won't update the repository right away, but tell me if this solution works. Thanks!
-
I made some major bugfixes today:
Lab (w/alpha) to to RGB conversion. "Here":http://www.pixentral.com/show.php?picture=1sbw7IyUMILv6LmcbhxobqtjcQ5N1 is the link to the screenshot.
16-bit RGB(A) and CMYK(A) support
Used D50 reference (whitepoint) instead of D65.
Too bad the image (wall-small-lab.psb) is too big and loading is still very slow. What are the options to prevent the GUI from freezing for some time? QEventLoop? etc?
-
The new Lab conversion is very nice.
We simply load images in a thread in order to prevent the GUI from freezing:
@
void DkImageLoader::load(QFileInfo file, bool silent, int cacheState) {// loadFile() does the real loading job
QMetaObject::invokeMethod(
this,
"loadFile",
Qt::QueuedConnection,
Q_ARG(QFileInfo, file),
Q_ARG(bool, silent),
Q_ARG(int, cacheState));
}
@in order to get this working, the 'DkImageLoader' needs to be moved to a worker thread:
@
// part of the DkImageLoader constructor
qRegisterMetaType<QFileInfo>("QFileInfo");
loaderThread = new QThread;
loaderThread->start();
moveToThread(loaderThread);
@ -
Good day!
Almost all color modes (Bitmap, Indexed, Grayscale, RGB, CMYK, Multichannel, Lab) in the following bit depth are supported now: 1bpc, 8 bpc, 16 bpc.
All that is left is 32-bpc (HDRI, high-dynamic-range imaging). To render/convert it to 8 bpc (to QImage), it needs to be processed using "tone mapping":http://en.wikipedia.org/wiki/Tone_mapping
I don't have any experiences on this and I am out of ideas now, so maybe somebody can help in implementing it.
Thanks. I will appreciate any help. :D
-
[quote author="Code_ReaQtor" date="1353719546"]Greetings!
I started coding a plugin for Photoshop Document (PSD/PSB).
This library is licensed under GNU LGPL.Critiques, contributors, developers, etc. are all welcome to visit "libqpsd on GitHub":https://github.com/Code-ReaQtor/libqpsd
Thanks![/quote]Good Works