QXMLStreamReader problems (Just reads the first element)

[aletom]

Hi,
as I wrote in the title I made a simple XML file writer and I'm trying to make an XML reader but while the writer seems to be ok the reader just reads the first element, adds it in my container (named "c") and then it just skips all the remaining elements.
I'll paste both the reader and the writer code.
Thank you very much.

Container<Box> XmlIO::read() const {
    Container<Box> c;

    QFile file(filename);
    if(!file.open(QIODevice::ReadOnly)) {
        qWarning()<< "Impossibile aprire il file" << file.errorString();
        return c;
    }

    QXmlStreamReader reader(&file);
    if(reader.readNextStartElement() && reader.name() == "root") {


            while(reader.readNextStartElement())
                if(reader.name() == "imbarcazione") {



                 const QXmlStreamAttributes attributes = reader.attributes();
                 const QString type =attributes.hasAttribute("type")? attributes.value("type").toString() : "";


                    reader.readNextStartElement();

                    const QString nome = reader.readElementText();


                    reader.readNextStartElement();

                    const unsigned int lenght = (reader.readElementText()).toUInt();

                    reader.readNextStartElement();

                    const unsigned int crew = (reader.readElementText()).toUInt();


                    if(type== "Scialuppa"){

                        reader.readNextStartElement();

                        const unsigned int rowing = (reader.readElementText()).toUInt();

                        
                        c.insert(Box(new Scialuppa(nome.toStdString(), lenght, crew, rowing)));
                    }
                      else if (type =="Mercantile"){

                            reader.readNextStartElement();
                            const unsigned tree = (reader.readElementText()).toUInt();
                            reader.readNextStartElement();
                            const float sail = (reader.readElementText()).toFloat();
                            reader.readNextStartElement();
                            const unsigned int load = (reader.readElementText()).toUInt();
                            reader.readNextStartElement();
                            QString goldtmp = reader.readElementText();
                            const bool gold = (goldtmp=="true") ? true : false;


                            c.insert(Box(new NaveMercantile(nome.toStdString(), lenght, crew, tree, sail, load, gold)));
                    }
                            else if(type == "Galeone"){
                                 reader.readNextStartElement();
                                 const unsigned tree = (reader.readElementText()).toUInt();
                                 reader.readNextStartElement();
                                 const float sail = (reader.readElementText()).toFloat();
                                 reader.readNextStartElement();
                                 const unsigned int cannon = (reader.readElementText()).toUInt();
                                 reader.readNextStartElement();
                                 const unsigned int mortar = (reader.readElementText()).toUInt();

                                 c.insert(Box(new Galeone(nome.toStdString(), lenght, crew, tree, sail, cannon, mortar)));
                            }



                }
     }

    file.close();



    return c;
}


void XmlIO::write(const Container<Box>& c) const {

    QSaveFile file(filename);


    if(!file.open(QIODevice::WriteOnly)) {
        throw std::exception();
    }

    QXmlStreamWriter writer(&file);

    writer.setAutoFormatting(true);
    writer.writeStartDocument();
    writer.writeComment("File di salvataggio dell'applicazione");

    writer.writeStartElement("root");                                // <root>

    Container<Box>::constiter it = c.constbegin();

    while(it!= c.constend()) {
        writer.writeStartElement("imbarcazione");                            // <imbarcazione>


        const Imbarcazione* i = &**it;
        const std::string type = i->getType();
        const std::string name = i->getName();
        const unsigned int lenght = i->getLenght();
        const unsigned int crew = i->getCrew();

          writer.writeAttribute("type", QString::fromStdString(type));           // <imbarcazione type="valore">




          writer.writeStartElement("name");
          writer.writeCharacters(QString::fromStdString(name));
          writer.writeEndElement();

           writer.writeStartElement("lenght");
          writer.writeCharacters(QString::number(lenght));
          writer.writeEndElement();

           writer.writeStartElement("crew");
          writer.writeCharacters(QString::number(crew));
          writer.writeEndElement();

        if(type=="Scialuppa")
            {
               const ImbarcazioneARemi* iar = dynamic_cast<const ImbarcazioneARemi*>(i);

               const unsigned int rowing = iar->getRowing();

                writer.writeStartElement("rowing");
               writer.writeCharacters(QString::number(rowing));
               writer.writeEndElement();

            }
        else if(type=="Mercantile"){
            const NaveMercantile* nm = dynamic_cast<const NaveMercantile*>(i);

            const unsigned int tree = nm->getTrees();
            const float sail = nm->getSailSurface();
            const unsigned int load = nm->getLoad();
            const bool goldtmp = nm->hasGold();
            QString gold = goldtmp ? "true" : "false";


            writer.writeStartElement("tree");
            writer.writeCharacters(QString::number(tree));
            writer.writeEndElement();

            writer.writeStartElement("sail");
            writer.writeCharacters(QString::number(sail));
            writer.writeEndElement();

            writer.writeStartElement("load");
            writer.writeCharacters(QString::number(load));
            writer.writeEndElement();

            writer.writeStartElement("gold");
            writer.writeCharacters(gold);
            writer.writeEndElement();
        }
        else if (type=="Galeone"){
            const Galeone* g = dynamic_cast<const Galeone*>(i);

            const unsigned int tree = g->getTrees();
            const float sail = g->getSailSurface();
            const unsigned int cannon = g->getCannons();
            const unsigned int mortar = g->getMortars();

            writer.writeStartElement("tree");
            writer.writeCharacters(QString::number(tree));
            writer.writeEndElement();

            writer.writeStartElement("sail");
            writer.writeCharacters(QString::number(sail));
            writer.writeEndElement();

            writer.writeStartElement("cannon");
            writer.writeCharacters(QString::number(cannon));
            writer.writeEndElement();

            writer.writeStartElement("mortar");
            writer.writeCharacters(QString::number(mortar));
            writer.writeEndElement();
        }





        writer.writeEndElement(); // </imbarcazione>

        ++it;

        if (writer.hasError())
            throw std::exception();
    }

    writer.writeEndElement();                                        // </root>
    writer.writeEndDocument();

file.commit();
}

[SGaist]

Hi and welcome to devnet,

Can you also share a small XML file that should trigger this error ?

[aletom]

This post is deleted!

[aletom]

@SGaist
Thank you, this is what my XML writer produces:

<?xml version="1.0" encoding="UTF-8"?>

<!--File di salvataggio dell'applicazione-->

-<root>


-<imbarcazione type="Galeone">

<name>zxcvb</name>

<lenght>70</lenght>

<crew>20</crew>

<tree>5</tree>

<sail>1000</sail>

<cannon>10</cannon>

<mortar>2</mortar>

</imbarcazione>


-<imbarcazione type="Mercantile">

<name>asdf</name>

<lenght>34</lenght>

<crew>10</crew>

<tree>3</tree>

<sail>500</sail>

<load>56</load>

<gold>true</gold>

</imbarcazione>


-<imbarcazione type="Scialuppa">

<name>qwerty</name>

<lenght>12</lenght>

<crew>12</crew>

<rowing>3</rowing>

</imbarcazione>

</root>