Using two QGLShaderProgram for objects in a same 3D scene [SOLVED]

billouparis

In the meantime you can download it from here:
http://www.mediafire.com/?bdejk5y93gr3wqv

In the draw function, you will see there are four different UseCases, you can use the "define" preprocessor directive to activate each one, and see the problems occuring,

Thank you,
Bill

billouparis

Hello ZapB, did you have time to test my source code?
Thank you,
Bill

ZapB

I managed to get it built yesterday but when I ran it I got some error complaining about one of your shaders not defining some variable as a varying. I can't recall which it was at the moment. I am really busy today so I'll try to take a proper look tomorrow.

billouparis

In the myWidget.cpp file, you can choose three different options declared as defines.
#define PC_BILL , #define PC_WORK, #define TARGET_IMX
maybe you can switch between the two firsts (either PC_BILL, or PC_WORK), and see if your vertex compiles alright then.
I have this workshop forecast on monday, it could be nice if I can solve the issue before if you are able to help me ;)

Thank you,
Bill

billouparis

Hello, anybody?

matrixx

Hey, I got your program compiled using BILL definition. The output of the program:
myWidget::myWidget parent WinID = 0x80650
BILL : InitializeGL
Vertex Shader compiled OK ""
Fragment Shader compiled OK ""
Program 3 linked OK ""
Vertex Shader compiled OK ""
Fragment Shader compiled OK ""
Program 6 linked OK ""
BILL : ResizeGL
BILL : myWidget instance : myWidget(0x9ba6f18)
model draw
Error 1282 myWidget.cpp 436
model draw
model draw
model draw
BILL : myWidget ~myWidget
BILL : myWidget instance : myWidget(0x9ba6f18)

As visual, I saw three identical green triangles.

I dunno if this helps any, I need to dive into shader programs and source code to deeply analyze what the shaders are supposed to do, and are they doing what they are suppose to :)

edit: forgot to say that this output was from USE_CASE1. Running now the rest of them.

edit2: Ran the rest of the use cases and got indeed some missing triangles, now digging into the code :)

ZapB

Sorry for the delay on this. I'll try to take another look this weekend too.

matrixx

Found the problem:

When you set uniform values like this:
@
g_hProjMatrixLoc = qGLShaderProgramTextures->uniformLocation("g_matProj");
qGLShaderProgramTextures->setUniformValue(g_hProjMatrixLoc, matProj3);
@
you have to have your shaderprogram binded to current context with
@
qGLShaderProgramTextures->bind()
@
before modifying uniforms.

Also a tip:
the two clauses above can be replaced with one:
@
qGLShaderProgramTextures->setUniformValue("g_matProj", matProj3);
@
where it uses uniform name directly.

Of course if you want to save your uniform location for later use, then the tip is useless :)

edited to format code blocks.

ZapB

matrixx: Well spotted and it applies to the other matrices too.

The fix is to change your paintGL() function to this:

@
void myWidget::paintGL()
{
/prepare projection matrix, only once!/
static bool loop = 1;
static GLfloat matProj3[4][4];
if (loop == 1)
{
memset (matProj3, 0, 16*sizeof(GLfloat));
matProj3[0][0] = 2;
matProj3[1][1] = matProj3[0][0] * g_fAspectRatio;
matProj3[2][2] = -1.0f;
matProj3[2][3] = -1.0f;
matProj3[3][2] = -1.0f;
loop = 0;
}

// Clear the colorbuffer and depth-buffer
QColor bgColor(10,15,255,255);
qglClearColor( bgColor );
DEBUGBILL
glClear( GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT );
DEBUGBILL

qGLShaderProgramTextures->bind();
g_hProjMatrixLoc = qGLShaderProgramTextures->uniformLocation("g_matProj");
qGLShaderProgramTextures->setUniformValue(g_hProjMatrixLoc, matProj3);

qGLShaderProgramScreen->bind();
g_hProjMatrixLoc = qGLShaderProgramScreen->uniformLocation("g_matProj");
qGLShaderProgramScreen->setUniformValue(g_hProjMatrixLoc, matProj3);

QMatrix4x4 tempRot(+cosf( fAngle ),0,-sinf( fAngle ),0,
                   0,1,0,0,
                   +sinf( fAngle ) ,0,+cosf( fAngle ),0,
                   0,0,0,1.0);

GLuint g_hSamplerLoc = 0;
qGLShaderProgramTextures->bind();
g_hSamplerLoc = qGLShaderProgramTextures->uniformLocation("g_matModelView");
qGLShaderProgramTextures->setUniformValue(g_hSamplerLoc, tempRot);

qGLShaderProgramScreen->bind();
g_hSamplerLoc = qGLShaderProgramScreen->uniformLocation("g_matModelView");
qGLShaderProgramScreen->setUniformValue(g_hSamplerLoc, tempRot);

drawTest();

}
@

The reason it worked for the different shaders depending which one was drawn first is beause your were not properly restoring which shader was bound each time around the rendering loop. Now they are explicitly set.

As an aside this type of thing is much easier to spot if you use a consistent coding style. I can spot at least two different coding styles in this file.

billouparis

matrixx and ZapB YOU ARE GENIOUS! Thank you so much for this, I really didn't know this, but of course the more I progress in openGL the more this error is made obvious.
THANK YOU!!!

billouparis

we can lock this thread now of course!

DenisKormalev

Thread closing is not neccessary (because there can be other people who will have similar problem later). But marking as [solved] will be good, don't forget to do it.