Important: Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

Microsoft Compiler does not recognize #warning (specifically in qglfunctions.h)



  • I'm hoping that an existing Qt developer will be willing to submit the following patch so that a warning can be issued by any Microsoft C++ compiler, instead of an error about an unrecognized preprocessor command. This is regarding 4.8, but may also apply to 5.x.

    @diff --git a/src/opengl/qglfunctions.h b/src/opengl/qglfunctions.h
    index e142b1e..fce919e 100644
    --- a/src/opengl/qglfunctions.h
    +++ b/src/opengl/qglfunctions.h
    @@ -43,9 +43,14 @@
    #define QGLFUNCTIONS_H

    #ifdef GLEW_H
    +#ifdef _MSC_VER
    +#pragma message (FILE ": qglfunctions.h is not compatible with GLEW, GLEW defines will be undefined")
    +#pragma message (FILE ": To use GLEW with Qt, do not include <QtOpenGL> or <QGLFunctions> after glew.h")
    +#else
    #warning qglfunctions.h is not compatible with GLEW, GLEW defines will be undefined
    #warning To use GLEW with Qt, do not include <QtOpenGL> or <QGLFunctions> after glew.h
    #endif
    +#endif

    #include <QtOpenGL/qgl.h>

    @


  • Lifetime Qt Champion

    Hi and welcome to devnet,

    There's already bug "here":https://bugreports.qt-project.org/browse/QTBUG-26326 concerning that problem.

    If you want, you can submit your patch through gerrit


Log in to reply