Layout, widgets not inside ???

SGaist

@SPlatten said in Layout, widgets not inside ???:

I just can't see how my code differs from the example.

Parent handling from child widgets, that's the main difference I already suggested to avoid.

JoeCFD

@SPlatten said in Layout, widgets not inside ???:

QGroupBox *groupBox = new QGroupBox(tr("Exclusive Radio Buttons"));

QRadioButton *radio1 = new QRadioButton(tr("&Radio button 1"));
QRadioButton *radio2 = new QRadioButton(tr("R&adio button 2"));
QRadioButton *radio3 = new QRadioButton(tr("Ra&dio button 3"));

radio1->setChecked(true);
QVBoxLayout *vbox = new QVBoxLayout;
vbox->addWidget(radio1);
vbox->addWidget(radio2);
vbox->addWidget(radio3);
vbox->addStretch(1);
groupBox->setLayout(vbox);

return groupBox;

    auto groupBox = new QGroupBox(tr("Exclusive Radio Buttons"), this );

    auto radio1 = new QRadioButton(tr("&Radio button 1"), groupBox);
    auto radio2 = new QRadioButton(tr("R&adio button 2"), groupBox);
    auto radio3 = new QRadioButton(tr("Ra&dio button 3"), groupBox);

    auto button_group = new QButtonGroup;
    button_group->addButton(radio1) ; 
    button_group->addButton(radio2) ;
    button_group->addButton(radio3) ;
    button_group->setExclusive( true );
    radio1->setChecked(true);

    auto vbox = new QVBoxLayout( groupBox );
    vbox->addWidget(radio1);
    vbox->addWidget(radio2);
    vbox->addWidget(radio3);
    vbox->addStretch(1);

    return groupBox;

JoeCFD

    QString group_style_sheet = QString("QGroupBox{border: %1px solid gray;border-radius: %2px;margin-top: %3px;}" )
                                                                         .arg( m_groupBorderThickness )
                                                                        .arg( m_groupBorderRadius )
                                                                        .arg( text_font_size * 1.6 );

Also you may need to set group style sheet to move text to the top of group frame. I do use it. Otherwise, the title text may push the radio buttons out of the group frame. Set minimum height to your group box.
If you do not want to set border properties, it is OK. But it is better to set margin top which is related to your group font size. Play with font size and parameter 1.6 and you will be able to move the radio buttons into the group frame.

SPlatten

@JoeCFD, I'm not sure what you are demonstrating here? The section of code I pasted comes directly from the Qt link, also posted.

What purpose does the QButtonGroup serve?

I edited my XML and applied the style:

<groupbox id="enSEX" eol="true" align="left" layout="vertical" 
		  dbfield="vcSex" properties="QGroupBox { border-radius: 8px; background-color:#ff0000; };">
	<radiobutton id="rdoM" text="Male" default="true" position="0,0"/>
	<radiobutton id="rdoF" text="Female" position="1,0"/>
</groupbox>

Here is the result:
Screenshot 2021-10-18 at 20.37.30.png

SPlatten

@SGaist , if only I could show you the rest of my code, when I create any widget I pass the parent widget to the constructor that creates the new widget.

JoeCFD

@SPlatten said in Layout, widgets not inside ???:

QButtonGroup

QButtonGroup serves making radio buttons exclusive. It is a common use. Otherwise, you need to handle them. Works for other buttons as well.
Adding stylesheet with margin-top will help you move the radio buttons into the group box(set some minimum size to the groupbox to accomodate these buttons). I had the same problem as yours before. I solved the issue with stylesheet. Did you notice your title text("Exclusive Radio Buttons") does not show because it is inside the group box. The first radio button is there too.

SPlatten

@JoeCFD , thank you, so is this a Qt bug? as the link I posted before doesn't use QButtonGroup ?

JoeCFD

@SPlatten It is true that that is a bug in the example. You copied it from there. If qbuttongroup is not used, you have to have a slot onButtonClicked to toggle them(messy). Sometimes, you may need it for your app.

QButtonGroup is very helpful. Now you know how to use it.

SPlatten

@JoeCFD , I'll try to describe what I'm working on, I am developing an engine that reads the configuration of what will be contained in a window from an XML set of files. The XML can be edited and reloaded into the engine with no source code changes required, the engine renders the content of the XML file converting it to widgets, as an example:

<?xml version="1.0" encoding="utf-8"?>
<form title="Test form" id="frmTest" hspacing="0" vspacing="0" width="480"
	  height="480" modal="false">
	<entry control="listwidget" label="Select:" id="enSEL"
		   cols="24" rows="1" mode="single" excludeFromChangeCheck="true"
		   resetPropertiesOnChange="true" eol="true">
		<subscriber signal="itemSelectionChanged" 
					target="simon2.js@listWidgetHandler"/>		
		<subscriber signal="currentItemChanged"
					target="simon2.js@listWidgetChanged"/>		
	</entry>
	<entry control="lineedit" label="First name:" id="enFN" eol="true"
		   cols="24" maxlength="24" accept="alpha_only" dbfield="vcFirstName"/>
	<entry control="lineedit" label="Surnname:" id="enSN" eol="true"
		   cols="24" maxlength="24" accept="alpha_only" dbfield="vcSurName"/>
	<groupbox id="enSEX" eol="true" align="left" layout="vertical" 
			  dbfield="vcSex" properties="QGroupBox { border-radius: 8px; background-color:#ff0000; }">
		<radiobutton id="rdoM" text="Male" default="true" position="0,0"/>
		<radiobutton id="rdoF" text="Female" position="1,0"/>
	</groupbox>
	<entry control="checkbox" label="Employed:" id="enEmp" eol="true"
		  dbfield="intEmployed"/>
	<entry control="textedit" label="Address:" id="enADR" eol="true"
		   maxlength="256" accept="alpha_numeric" cols="24" rows="5"
		   dbfield="vcAddress"/>
	<groupbox id="enButtons" eol="true" align="right" layout="horizontal">		   
		<button id="btnApply" api="applyChanges">
			<subscriber signal="clicked" target="simon2.js@applyButton"/>
		</button>
		<button id="btnUndo" api="undoChanges"/>
		<button id="btnOK" api="submitAndClose"/>	
	</groupbox>			
	<on saveChanges="Save changes before changing selection?"/>
	<on setup="simon2.js@setupForm"/>
</form>

I'm still having problems in getting the layout and groupbox to work properly, now I am getting a problem where after setting the layout, the code jumps into QWidgetRepaintManager::removeDirtyWidget.

This happens immediately after I call setLayout on the QGroupBox widget.

SGaist

Are you giving a parent to the layout before calling setLayout ?

JoeCFD

@SPlatten Good stuff. Can you please show your code for building layout? XML file has only properties of widgets and can not tell why layout goes wrong.

A good practice for debugging is to keep a small GUI case with ui file generated from qt designer and then you compile this case. From ui_*** file created in build, you can see how widgets are laid out. In this way, you can save a lot of time. I believe your time worths some good money.

SPlatten

@JoeCFD , the issue I have now is that I've created a mock up using Qt Creator and in this I added a QGroupBox, then into this I added a QVBoxLayout then added three QRadioButtons, I then examined the document as XML and everything looked fine, when I build and ran it also looked fine.

However I'm having difficulty replicating this, I have a QGroupBox, I've created a layout and used setLayout on the QGroupBox widget, so far so good....but now I want to set the parent to the layout but can't, because the layouts are not derived from QWidget and calling ->widget() on the layout returns nullptr. I want to use the layout like a widget so I can add other widgets to it using the layout as a parent.

jsulm

@SPlatten said in Layout, widgets not inside ???:

I want to use the layout like a widget so I can add other widgets to it using the layout as a parent.

You can't. A layout is not QWidget. And I'm wondering why you want to do this? There is already a simple way to add a widget to a layout.

SPlatten

@jsulm, I've tried implementing this:

            QLayout* pobjLayout(nullptr);
            if ( pobjParent != nullptr ) {
    //Does the parent have a layout?
                pobjLayout = pobjParent->pobjGetLayout();
                if ( pobjLayout != nullptr ) {
    //Yes, clear the pobjParWidget widget
                    pobjParWidget = nullptr;
                }
            }
            pobjWidget = qobject_cast<QWidget*>(clsCNT::pCreate(this,
                                                                mstrName,
                                                                strCSS,
                                                                slstProperties,
                                                                pobjParWidget));
            if ( pobjLayout != nullptr ) {
    //Add the widget to the layout
                pobjLayout->addWidget(pobjWidget);                
            }

However this doesn't work either, the radio buttons still appear outside of the groupbox and not in the layout, I've single stepped the logic, so the radio button widgets are added to the layout.

jsulm

@SPlatten said in Layout, widgets not inside ???:

pobjLayout->addWidget(pobjWidget)

Is this line executed?
If it is: to which widget does this layout belong? What is pobjGetLayout() actually doing?

SPlatten

@jsulm , yes, it is. I've used setObjectName to assign the layouts and widgets the id's they have in the XML.

In the above pobjLayout points to a QVBoxLayout and pobjWidget points to a QRadioButton.

The layout is appended to a QGroupBox via setLayout.

JoeCFD

@JoeCFD said in Layout, widgets not inside ???:

QString group_style_sheet = QString("QGroupBox{border: %1px solid gray;border-radius: %2px;margin-top: %3px;}" )
.arg( m_groupBorderThickness )
.arg( m_groupBorderRadius )
.arg( text_font_size * 1.6 );

override the style sheet of group box in the xml with
int margin_top = font().pointSize()* 1.6;
QString group_style_sheet = QString("QGroupBox{border: 2px solid gray;border-radius: 8px;margin-top: %1px;}" ).arg( margin_top );
You try to hardcode it and see if it works.

SPlatten

@JoeCFD , thank you appreciated, why isn't this kind of thing required when positioning and using Qt Creator? This is the XML copied from the UI file which works perfectly.

   <widget class="QGroupBox" name="groupBox">
    <property name="geometry">
     <rect>
      <x>120</x>
      <y>170</y>
      <width>301</width>
      <height>201</height>
     </rect>
    </property>
    <property name="title">
     <string>GroupBox</string>
    </property>
    <widget class="QWidget" name="verticalLayoutWidget">
     <property name="geometry">
      <rect>
       <x>9</x>
       <y>29</y>
       <width>291</width>
       <height>161</height>
      </rect>
     </property>
     <layout class="QVBoxLayout" name="verticalLayout">
      <item>
       <widget class="QRadioButton" name="Radio1">
        <property name="text">
         <string>Radio1</string>
        </property>
       </widget>
      </item>
      <item>
       <widget class="QRadioButton" name="Radio2">
        <property name="text">
         <string>Radio2</string>
        </property>
       </widget>
      </item>
      <item>
       <widget class="QRadioButton" name="Radio3">
        <property name="text">
         <string>Radio3</string>
        </property>
       </widget>
      </item>
     </layout>
    </widget>
   </widget>
  </widget>
 </widget>

No sign of any styles or positioning, I'm now trying to reverse the logic to see where the difference is.

This is what I found in the debugger looking at how the above XML appears:
Screenshot 2021-10-20 at 18.06.21.png
What I don't understand is what is **[0] "verticalLayout" as a child ?

Drill down a bit more into this layout:
Screenshot 2021-10-20 at 18.25.22.png
It appears that the groupBox has one child which I agree with and expect verticalLayoutWidget, the layout has 4 children which I didn't expect:

verticalLayout
Radio1
Radio2
Radio3

What is verticalLayout and where did it come from, it has no children, it isn't in the XML layout ?

Just to clarify, just in case the screenshot isn't clear it shows:

groupBox
    verticalLayout
        verticalLayoutWidget
        Radio1
        Radio2
        Radio3

Its verticalLayoutWidget that is the mystery...

Another edit, looked again at the XML and it does match the debugger screenshot. It looks like there is a fiddle in that the first widget is not the QVBoxLayout but a Widget called "verticalLayoutWidget".

JoeCFD

@SPlatten group box has a layout for three radio buttons and is a child as well. In total, it has 4 children.

SPlatten

@JoeCFD, please see edit, bit at the bottom.

Call for Presentations - Qt World Summit

Unsolved Layout, widgets not inside ???