Solved Why cross-thread invoke will report “QObject: Cannot create children for a parent that is in a different thread.”？

[Crawl.W]

Such as the title，confusing warning!Such as a member funcation of QSerialPort's instance invoked by child thread. I do not wanna get a solution,rahter than know why for the warning is given.

//main.cpp
int main(int argc, char *argv[])
{
    //...
    TestClass *testclass2 = TestClass::GetInstance();

    TempMyThread *mythread = new TempMyThread;
    mythread->start();
    //...
}

//tempthread.cpp
void TempMyThread::run(){
    TestClass *testclass2 = TestClass::GetInstance();
    qDebug() << "temp thread " << testclass2;

    testclass2->myserialport->write("1");
}

myserialport is TestClass's member var.

[J.Hilk]

hi @Crawl.W

it's not a warning, its an error and not really confusing.

What is the issue exactly ?

Chances are, the the function is executed in the thread of the function caller. If you inside the function create a new QObject with for example this as parent, then you're trying to parent a Object to a parent that lives in a different thread compared to the creating thread.

[Crawl.W]

This post is deleted!

[Crawl.W]

@J.Hilk But If I just call a funcation like QSerialPort::write(), there is no qobject created in the whole process.That's your a assumption, and sometimes it's not tenable.

[J.Hilk]

@Crawl-W
of course, that's my assumption, you haven't shown any code. What else can I do but assume ?

[Crawl.W]

@J.Hilk About QSerialPort::write() or QSerialPort::open()? I had tried to seach the source, but no object created seemingly.

[jsulm]

@Crawl.W What else do you do in that other thread?

[Crawl.W]

@jsulm noting.

[jsulm]

@Crawl.W Well, without source code others can only guess...

[KroMignon]

@Crawl.W said in Why cross-thread invoke will report “QObject: Cannot create children for a parent that is in a different thread.”？:

noting.

You are doing something or you would not have this error message.
If you don't want to show your code, then you will have to find yourself where you create a QObject instance with a parent in a different thread.

[Crawl.W]

I had assumed that the question only need simple description.Code has supplymented.

[J.Hilk]

@Crawl.W

now it's obvious.

Your singleton is created in the main thread. you write to it inside the worker thread. during write process, a QTimer is created and set, to monitor timeouts. That is created from the wrong thread of course. -> Therefore the error

[Crawl.W]

@J.Hilk So it is,You rocks!But I did not find where QTimer created, can you post those source?

[kuzulis]

https://github.com/qt/qtserialport/blob/5.12/src/serialport/qserialport_win.cpp#L625

[Crawl.W]

@kuzulis @J-Hilk Thanks for everyone,I saw.

[Crawl.W]

@J.Hilk As show in source,the QTimer is very strange, which is single shot and no interval set.Why?Why do not call his timeout's slot function directly?

[jsulm]

@Crawl.W said in Why cross-thread invoke will report “QObject: Cannot create children for a parent that is in a different thread.”？:

Why do not call his timeout's slot function directly?

Because then it would be a synchronous call - write() would block until it's finished. But since it is an asynchronous API it should not block the caller.

[KroMignon]

@Crawl.W said in Why cross-thread invoke will report “QObject: Cannot create children for a parent that is in a different thread.”？:

Why do not call his timeout's slot function directly?

This is done to call the timeout function after all events in thread queue have been processed.
Here the extract for QTimer::interval:

The default value for this property is 0. A QTimer with a timeout interval of 0 will time out as soon as all the events in the window system's event queue have been processed

[Crawl.W]

@jsulm Great,I got it!Thanks.