A few design questions...

mzimmers

Hey, Zap...if you're still getting alerts on this thread:

I'm trying to move the Qt logic we implemented in this thread from one class (Soc) to another (Filter).

I commented out most of the Qt code in the Soc class, but I'm getting a build error that a particular routine isn't declared in the scope of the SoC class. The problem is, it's coming from the moc_Soc.cpp file. Is this enough information for you to tell me what I might have missed?

Thanks.

ZapB

Can you show me your header files and the snippet of code that the compiler is complaining about please? Plus the entire compiler message would be useful too.

mzimmers

Here's the error message:

bq. moc_Soc.cpp: In member function 'virtual int Soc::qt_metacall(QMetaObject::Call, int, void**)':
moc_Soc.cpp:98: error: 'shaperOutIString' was not declared in this scope
moc_Soc.cpp:104: error: 'setShaperOutI' was not declared in this scope

Here's the code snippet from the moc_Soc file:

@#ifndef QT_NO_PROPERTIES
else if (_c == QMetaObject::ReadProperty) {
void *_v = _a[0];
switch (_id) {
case 0: reinterpret_cast< long>(_v) = getShaperOutI(); break;
case 1: reinterpret_cast< QString>(_v) = shaperOutIString(); break;
}
@

(It's complaining about the case 1 line.)

Header files: I'm trying to keep this post brief, but here's the header for the filter class:
@class DemodShaperFilter : public QObject
{
Q_OBJECT
Q_PROPERTY (long shaperOutI
READ getShaperOutI WRITE setShaperOutI NOTIFY shaperOutIChanged)
Q_PROPERTY (QString shaperOutIString
READ shaperOutIString NOTIFY shaperOutIStringChanged)
private:
vector<Cell> cellArrayI;
vector<Cell> cellArrayQ;
long shaperOutI; // for Qt display purposes
public:
DemodShaperFilter(QObject *parent = 0,
long rv = 0); // constructor w/ reset param
DemodShaperFilter(QObject *parent = 0,
const DemodShaperFilter &dsf = 0); // copy constructor
~DemodShaperFilter(); // destructor
void cycle(long combGainI,
long *shaperCoeffI,
long combGainQ,
long *shaperCoeffQ,
bool clockEnable,
bool resetState);
// void testCycle();
void reset();
long getCoeffs(long *aI, long *aQ);
void display();
void setFilterClockEnable(bool n);
long getDemShpIOut();
long getDemShpQOut();
long getShaperOutI() ;
void setShaperOutI(long i);
QString shaperOutIString();

public slots:
void testCycle();

signals:
void shaperOutIChanged ();
void shaperOutIStringChanged ();
};@

Let me know what else you might need. Thanks...

ZapB

It looks as if you still have the Q_PROPERTY() declaration in your soc.h file but that you have already removed all of the other related functionality - the setter, getter and notifier signal. Is that correct?

Make sure you rhave no Q_PROPERTY() stuff left in the soc.h file.

mzimmers

Good eye. I removed them, and got rid of that error. Now, I'm getting:
@Undefined symbols:
"vtable for DemodShaperFilter", referenced from:
__ZTV17DemodShaperFilter$non_lazy_ptr in DemodShaperFilter.o
(maybe you meant: __ZTV17DemodShaperFilter$non_lazy_ptr)
"DemodShaperFilter::shaperOutIChanged()", referenced from:
DemodShaperFilter::setShaperOutI(long) in DemodShaperFilter.o
@

This is because I didn't change my connect commands in the widget, isn't it? Now, I have to think about this...the filter object isn't visible to the widget.

ZapB

That type of error often occurs when you forget to:

include the Q_OBJECT macro (which I see you have) or
forget to add the header file to the HEADERS section of the .pro file or
forget to re-run qmake after doing so.

Look in your build dir and see if you have a moc_demodshaperfilter.cpp being generated as part of the build process.

mzimmers

The header file is in the .pro file.

I'm pretty sure qmake is run automatically as part of my build.

And no, the mod_demodshaperfilter.cpp file isn't there.

But, I think my problem is a bit more fundamental, isn't it? When we configured this originally, we set it up so that the Soc class was the "interface" to the UI. Now, though, I want to move the UI logic into the filter class, but...I don't create a new instance of the filter in widget like I do the Soc.

I'd like the Soc class to still contain the filter (and other) class, but I'd prefer to move the UI part of the exercise closer to the actual data. The element we chose for this demonstration is part of the filter class, not the Soc.

ZapB

No, the lack of moc_demodshaperfiler.cpp is the entire problem here (well the linker unresolved symbols error anyway). Can you post your .pro file please and try doing

@
make distclean
qmake -r
make
@

and post the output of the qmake and make steps please.

With respect to exposing your DemodShaperFilter object and it's properties, that is simple. Just provide a function on your Soc class that returns a pointer to the contained DemodShaperFilter. Once you have the pointer available to your widget or qml scene then you can proceed just like we did before.

mzimmers

OK, here's the .pro file:

@######################################################################

Automatically generated by qmake (2.01a) Mon Mar 28 17:09:16 2011

######################################################################

TEMPLATE = app
TARGET =
DEPENDPATH += . headers src
INCLUDEPATH += . headers

APP_QML_FILES.files = DemodShaperFilter.qml
APP_QML_FILES.path = Contents/MacOS
QMAKE_BUNDLE_DATA += APP_QML_FILES

QT += core gui declarative

Input

HEADERS +=
headers/clock.h
headers/DemodShaperFilter.h
headers/globals.h
headers/register_offsets.h
headers/Soc.h
headers/SocReg.h
headers/widget.h
headers/GenericCell.h
headers/DemodCicTuner.h
headers/SystolicFilter.h
headers/modpredist.h
headers/Nco.h
headers/nyquist.h
headers/nyquistcell.h
headers/modshaperfilter.h
headers/modciccomb.h
headers/modciccombstage.h
headers/socreg64.h
SOURCES +=
src/clock.cpp
src/DemodShaperFilter.cpp
src/filestuff.cpp
src/globals.cpp
src/main.cpp
src/Soc.cpp
src/SocReg.cpp
src/widget.cpp
src/GenericCell.cpp
src/DemodCicTuner.cpp
src/SystolicFilter.cpp
src/modpredist.cpp
src/nco.cpp
src/nyquist.cpp
src/nyquistcell.cpp
src/modshaperfilter.cpp
src/modciccomb.cpp
src/modciccombstage.cpp
src/socreg64.cpp

FORMS +=
widget.ui

OTHER_FILES +=
DemodShaperFilter.qml

RESOURCES +=
simple.qrc
@

Those commands you posted are from the shell, right? I got this error on the make command:

bq. make: *** No rule to make target `distclean'. Stop.

ZapB

OK just try

@
make clean
qmake -r
make
@

You can do it from within qt-creator via the project context menu "Clean project", "Run qmake", and "Build project" I htink are the entries.

mzimmers

OK, I did it from Creator. "Run qmake" returned this:

@Running build steps for project simulatorGUI...
Starting: "/usr/bin/qmake" /Users/mzimmers/wideband/SoC simulator/simulatorGUI/simulatorGUI.pro -r -spec macx-g++ QMLJSDEBUGGER_PATH=/Developer/Applications/Qt/Qt Creator.app/Contents/Resources/qml/qmljsdebugger
The process "/usr/bin/qmake" exited normally.@

And the build returned a whole bunch of stuff that I won't bother putting here (unless you really want it), but it did build successfully this time. And I checked the build directory, and I now have files for the filter there.

Now, in the UI, the value displays as "undefined." And, I'm getting a couple run-time errors about "no such signal." One is on this line (in soc.cpp):

@ connect (this, SIGNAL(shaperOutIChanged()), this, SIGNAL(shaperOutIStringChanged()));
@

And the other is (in widget.cpp):
@ connect (soc, SIGNAL(shaperOutIChanged()), this, SLOT(updateShaperOutI()));
@

ZapB

OK. For some reason then the build system had not noticed that qmake needed to be re-run. But at least it is fixed now.

For the signals...

The first connect statement should now be moved into the DemodShaperFilter class since that is where we have all of the Qt property stuff now.

The second statement should be changed to something like this:

@
connect (soc->demodShaperFilter(), SIGNAL(shaperOutIChanged()), this, SLOT(updateShaperOutI()));
@

where you need to add:

@
DemodShaperFilter* demodShaperFilter() const { return m_demodShaperFilter; }
@

to your Soc class. Note that I have used "m_demodShaperFilter" but I have not seen your Soc.h header file so you'll have to replace that with whatever you called your pointer to the DemodShaperFilter object.

That should remove those runtime warnings.

Incidentally, I find it useful to run with the environment variable QT_FATAL_WARNINGS=1 set. With that in place any runtiem warnings form Qt will cause your app to abort at that point which the debugger will catch so that you can inspect the stack trace. You can set the above in the Qt-Creator project settings under the RunTime Configuration tab.

mzimmers

OK. I'd already copied the first connect into the DSF, but hadn't removed it from the Soc. Now done.

About the second one: something doesn't look right with that function definition. Either the type or the return value needs to be changed to agree with the other...

EDIT: also, the "const" was causing the compiler to beef, so I removed it.

And, at runtime, I now get this error:

@qrc:/DemodShaperFilter.qml:15:2: QML Connections: Cannot assign to non-existent property "onShaperOutIChanged"@

I didn't change my qml file; here it is:

@import QtQuick 1.0

Rectangle {
id: myRect
width: 300
height: 100
color: "#808080"

Text {
text: "shaperOutI = " + soc.shaperOutIString;
font.pointSize: 20
anchors.centerIn: parent
}

Connections {
target: soc
onShaperOutIChanged: {
if (myRect.color == "#808080")
myRect.color = "#c0c0c0"
else
myRect.color = "#808080"
}
}
}

@

Do I change the target from soc to something else (like the DSF)?

mzimmers

I cleaned up some stuff, but I'm still getting this error message:

bq. qrc:/DemodShaperFilter.qml:15:2: QML Connections: Cannot assign to non-existent property "onShaperOutIChanged"

Any suggestions?

ZapB

Can you post he header file of your DemonShaperFilter class, the place where you expose that object to the qml context and the QML file please?

mzimmers

Hi, Zap -

Apart from some include files, and constant definitions, what I posted above is my complete header file for that class. I thought I copied everything necessary over from the original Soc class; did I miss something?

ZapB

What about the part where you expose the object to the QML context? Also can you show how you get the pointer to the DemodShaperFilter object from the Soc object please? You mentioned something about not being able to use const or a pointer or something there?

mzimmers

The Soc class has a public function to return the address of the DSF object:

@ DemodShaperFilter* demodShaperFilter() { return &filter; }
@

I'm not sure I remember "exposing" the DSF to QML. In my .qml file, there's a Connections block:

@ Connections {
target: soc
onShaperOutIChanged: {
if (myRect.color == "#808080")
myRect.color = "#c0c0c0"
else
myRect.color = "#808080"
}
}
@

But I didn't see any code in my Soc class that tied the object to QML.

ZapB

Somewhere we had something like:

@
view->rootContext->setContextProperty( m_soc, "soc" );
@

which should now become something like:

@
view->rootContext->setContextProperty( m_soc->demodSHaperFilter, "dsf" );
@

then in your QML scene replace all references of "soc" to "dsf".

mzimmers

Oh! That's in the widget constructor:
@Widget::Widget(QWidget *parent) :
QWidget(parent),
ui(new Ui::Widget),
m_timer(new QTimer(this)),
soc(new Soc(this))
{
ui->setupUi(this);

connect (m_timer, SIGNAL(timeout()), soc, SLOT(runOneCycle()));

connect (soc->demodShaperFilter(), SIGNAL(shaperOutIChanged()), this, SLOT(updateShaperOutI()));

QDeclarativeView* view = ui->declarativeView;

view->rootContext()->setContextProperty("soc", soc);
view->setSource(QUrl("qrc:/DemodShaperFilter.qml"));

m_timer->start(200); // 200 ms delay between cycles (for now)
}
@

And, by "QML scene," you're referring to the .qml file?