ListView delegate isnt able to access model properties after inserting into QAbstractItemModel

[Christian Ehrlicher]

@Creaperdown said in ListView delegate isnt able to access model properties after inserting into QAbstractItemModel:

it here since the issue might be on the c++ side of QAbstractItemModel

If so why don't you show us your model implementation?

[Creaperdown]

@Christian-Ehrlicher good point, here it is:

class ADAPTERS_EXPORT BookmarksModel : public QAbstractListModel
{
    Q_OBJECT

public:
    enum Roles
    {
        UuidRole = Qt::UserRole,
        NameRole,
        PageNumberRole,
        YOffsetRole
    };

    BookmarksModel(const QList<domain::entities::Bookmark>& data);

    int rowCount(const QModelIndex& parent) const override;
    QVariant data(const QModelIndex& index, int role) const override;
    QHash<int, QByteArray> roleNames() const override;

public slots:
    void startInsertingBookmark(int index);
    void endInsertingBookmark();
    void startDeletingBookmark(int index);
    void endDeletingBookmark();
    void bookmarkNameChanged(int row);

private:
    const QList<domain::entities::Bookmark> m_data;
};

cpp:

BookmarksModel::BookmarksModel(const QList<domain::entities::Bookmark>& data) :
    m_data(data)
{
}

int BookmarksModel::rowCount(const QModelIndex& parent) const
{
    if(parent.isValid())
        return 0;

    return m_data.size();
}

QVariant BookmarksModel::data(const QModelIndex& index, int role) const
{
    if(!index.isValid())
        return QVariant();

    const Bookmark& bookmark = m_data.at(index.row());
    switch(role)
    {
    case UuidRole:
        return bookmark.getUuid();
    case NameRole:
        return bookmark.getName();
    case PageNumberRole:
        return bookmark.getPageNumber();
    case YOffsetRole:
        return bookmark.getYOffset();
    default:
        return QVariant();
    }
}

QHash<int, QByteArray> BookmarksModel::roleNames() const
{
    static QHash<int, QByteArray> roles {

        { UuidRole, "uuid" },
        { NameRole, "name" },
        { PageNumberRole, "pageNumber" },
        { YOffsetRole, "yOffset" },
    };

    return roles;
}

void BookmarksModel::startInsertingBookmark(int index)
{
    beginInsertRows(QModelIndex(), index, index);
}

void BookmarksModel::endInsertingBookmark()
{
    endInsertRows();
}

void BookmarksModel::startDeletingBookmark(int index)
{
    beginRemoveRows(QModelIndex(), index, index);
}

void BookmarksModel::endDeletingBookmark()
{
    endRemoveRows();
}

void BookmarksModel::bookmarkNameChanged(int row)
{
    emit dataChanged(index(row, 0), index(row, 0), { NameRole });
}

The bookmarks are added from another class, that is emitting signals that are connected to the public slots like startInsertingRow, ... I have checked the connections and they are triggered correctly.

[Creaperdown]

This is how a bookmark is added:

   auto book = getBook();

    emit bookmarkInsertionStarted(book->getBookmarks().count());
    book->addBookmark(bookmark);
    emit bookmarkInsertionEnded();

and here you can see that these signals are connected to the slots:

connect(m_bookService, &application::IBookService::bookmarkInsertionStarted,
            m_bookmarksModel.get(),
            &data_models::BookmarksModel::startInsertingBookmark);

    connect(m_bookService, &application::IBookService::bookmarkInsertionEnded,
            m_bookmarksModel.get(),
            &data_models::BookmarksModel::endInsertingBookmark);

[Creaperdown]

I am exposing a SortFilterProxyModel with my BookmarksModel set as the source, but I do not think that this should cause any problems.

[Christian Ehrlicher]

@Creaperdown said in ListView delegate isnt able to access model properties after inserting into QAbstractItemModel:

void BookmarksModel::startInsertingBookmark(int index)
{
beginInsertRows(QModelIndex(), index, index);
}

void BookmarksModel::endInsertingBookmark()
{
endInsertRows();
}

void BookmarksModel::startDeletingBookmark(int index)
{
beginRemoveRows(QModelIndex(), index, index);
}

void BookmarksModel::endDeletingBookmark()
{
endRemoveRows();
}

Imo this should not be exposed to the outside. Write a custom function in your model which adds/removes a bookmark and call begin/endFoo() in there. Otherwise the user of your model must know that he needs to call startInsertingBookmark() / endInsertBookmark() for every inserted bookmark. Also I don't see a function which really adds something to the model.

[Creaperdown]

@Christian-Ehrlicher I have written a second reply, containing the function that adds the bookmark.

Does moving the functions into the model make a difference functionality wise? Using the signal-approach should be doing exactly the same, shouldn't it?
I am using this approach throughout my application to separate the code responsible for the qml representation from the actual logic.

I'll consider moving it into the models, but for now I'd prefer to solve it this way, if it isn't the root of the problem.

[Christian Ehrlicher]

@Creaperdown said in ListView delegate isnt able to access model properties after inserting into QAbstractItemModel:

oes moving the functions into the model make a difference functionality wise? Using the signal-approach should be doing exactly the same, shouldn't it?

Yes, but the user of your model must know to call begin/endFoo() for no reason - can be done directly in addBookmark() and nothing can go wrong then like e.g.:

emit bookmarkInsertionStarted(book->getBookmarks().count());
book->addBookmark(bookmark);
book->addBookmark(bookmark);
emit bookmarkInsertionEnded();

or

emit bookmarkInsertionStarted(book->getBookmarks().count());
emit bookmarkInsertionEnded();

which can be easily avoided.

But that's not the your current issue, just a bad desgin (imo).

[Creaperdown]

@Christian-Ehrlicher thanks for the recommendation, I'll be looking into that but I'm still not sure what causes me actual issue

[Christian Ehrlicher]

@Creaperdown There I can't help - don't use QML

[Creaperdown]

@Christian-Ehrlicher So you think this is a qml related problem?

[Christian Ehrlicher]

I would create a single/atomar add function to really make sure the add is correct but the rest looks good.

[JonB]

@Creaperdown
Yes indeed it is, which is why I suggested this thread might be better moved to QML forum in the first place, though never mind now.

[Creaperdown]

@JonB I'll be closing this here then and moving it to the Qml section

[Christian Ehrlicher]

Why do you delete this thread? To start over the same discussion about the possible wrong usage of begin/endInsertRows again?

[JoeCFD]

@Creaperdown in your model, do the following:

    beginResetModel();
     add new row()
    endResetModel();

[SGaist]

@JoeCFD said in ListView delegate isnt able to access model properties after inserting into QAbstractItemModel:

@Creaperdown in your model, do the following:

    beginResetModel();
     add new row()
    endResetModel();

If you need to reset the whole model because you insert one row, there's likely a design issue.

[JoeCFD]

@SGaist It is an option. I am not sure if everything is redone.

[SGaist]

@JoeCFD basically, it tells the view that everything has changed so it should reload everything as a consequence.

[JoeCFD]

@SGaist True. kind of global update. It is better to use
beginInsertRows() and endInsertRows().

[Creaperdown]

The problem was a missing reference on the container. It should have been QList<Bookmark>&, thus it didnt update the container when I add a book.