QTableView clicked() versus doubleClicked()

Perdrix

I added an entry to public slots in addition to the customContextMenuRequested one:

public slots:
		void on_tableView_customContextMenuRequested(const QPoint& pos);
		void on_tableView_currentChanged(const QModelIndex& index, const QModelIndex& last);

and added an implementation for it

But when I run the code I get:

QMetaObject::connectSlotsByName: No matching signal for on_tableView_currentChanged(QModelIndex,QModelIndex)

I don't think I got the signature wrong as the docs for QItemSelectionModel::currentChanged signal says:

void currentChanged(const QModelIndex &current, const QModelIndex &previous)

However connectSlotsByName() seems to disagree!

Puzzled
David

JonB

@Perdrix
void QTableView::currentChanged(const QModelIndex &current, const QModelIndex &previous) is [override virtual protected], it is not a signal!

@SGaist referred you to void QItemSelectionModel::currentChanged(const QModelIndex &current, const QModelIndex &previous), which is a signal, but on the QItemSelectionModel, not the QTableView. Hence void on_tableView_currentChanged(...) is not going to work.

BTW, most (advanced) people here do not use connectSlotsByName(), it has too many potential issues. Consider changing over to explicit connect() calls (using new-style syntax), then you would not have been stymied!

Perdrix

@JonB Thanks yet again!

I'm now doing this:

QItemSelectionModel* qsm = ui->tableView->selectionModel();
connect(qsm, SIGNAL(currentChanged(const QModelIndex&, const QModelIndex&)),
			this, SLOT(tableView_currentChanged(const QModelIndex&, const QModelIndex&)));

and that works fine, but there's a small puzzle.

When I click on a table row for the FIRST time, the slot is invoked just fine, and it executes this code:

qDebug() << "Table View selected item changed to row " << index.row();

QItemSelectionModel * qsm = ui->tableView->selectionModel();
		QModelIndexList selectedRows = qsm->selectedRows();
qDebug() << "Number of selected rows is " << selectedRows.count();

which produces the somewhat unexpected output:

Table View selected item changed to row  3
Number of selected rows is  0

Yet the row in question is highlighted to tell me it's selected!!!

Please can you explain for me?

And it gets wierder when I click on another row, the index of the selected item I get is the one that WAS selected!????

Should I instead of the currentChanged signal be using the selectionChanged signal???

Thank you
David

JonB

@Perdrix said in QTableView clicked() versus doubleClicked():

connect(qsm, SIGNAL(currentChanged(const QModelIndex&, const QModelIndex&)),
this, SLOT(tableView_currentChanged(const QModelIndex&, const QModelIndex&)));

Do yourself a one-time nice favor: change over to connect() "new" style syntax (yours is now really old) for ever, and don't look back :)

You are not the first person to struggle with the difference between "current" and "selected", myself included! @SGaist may know better, as he made the suggestion. If you find selectionChanged() a better/more intelligible signal, I would try that :)

Perdrix

To answer my own question! This seems to work:

	void StackingDlg::tableView_selectionChanged([[maybe_unused]] const QItemSelection& selected, [[maybe_unused]] const QItemSelection& deselected)
	{

		QItemSelectionModel * qsm = ui->tableView->selectionModel();
		QModelIndexList selectedRows = qsm->selectedRows();
		qDebug() << "Number of selected rows: " << selectedRows.count();
		//
		// If only one row is selected, we want to know the filename
		//
		if (1 == selectedRows.count())
		{
			QModelIndex& ndx = selectedRows[0];
			qDebug() << "  Selected row: " << ndx.row();

though there's one remaining oddity.

When I click on the single row, the row is highlighted to show it's selected, and the image loading is started in another thread, and the table view is disabled.

On completion of the loading, the table view is enabled again, but the highlight is lost until I click on somewhere else in the window (not the rows of the tableview).

I changed that code to NOT disable the table view and the highlight did not go away.

Is there a way to prevent USER interaction with a control but allow internal events to continue processing?

mpergand

@Perdrix said in QTableView clicked() versus doubleClicked():

the table view is enabled again, but the highlight is lost

Because the table lost the focus, set it again with:

tableView->setFocus(Qt::OtherFocusReason);

JonB

@Perdrix said in QTableView clicked() versus doubleClicked():

and the image loading is started in another thread, and the table view is disabled.

Just asking: do you really need a separate thread for this "image loading" and having this "disabling" and consequent "focus losing"? Maybe you do, but have you tried without bothering?

Perdrix

@JonB Separate thread? Yes - it can take quite a while for some of these images.

Perdrix

@mpergand said in QTableView clicked() versus doubleClicked():

tableView->setFocus(Qt::OtherFocusReason);

Woohoo! That worked a treat.

Thanks
David

JonB

@Perdrix said in QTableView clicked() versus doubleClicked():

it can take quite a while for some of these images.

Just because I am interested: do you mean (it takes much time) to load the image (once generated if that is what you are doing) into the UI, or do you mean to generate an image to load?

Perdrix

Large images that take a while to load from file.

SGaist

Do you want to show the full image size ?
Otherwise creating a cache with small versions of them might be a better solution in terms of speed and only load the real version when really needed.

Perdrix

Still need to load them - I am caching once loaded.

SGaist

Hence my suggestion, have a "pre-processing" phase where you create thumbnails to show quickly and load the complete file in the background. Once it's done notify your application and do what you need with it.

Perdrix

No I can't do thumbnails as I don't know a-priori what files are involved and there might be 100s of them.

Now back to the problem - selectionChanged works fine to detect the newly selected row to trigger image loading.

Unfortunately, double clicking on a editable cell still results in selectionChanged driving the image loading to start.

What it doesn't do is open the editor on the cell that was double clicked!

I had a quick look at the code of mouseDoubleClickEvent in QAbstractItemView.cpp, and I think it is written so that it should always open the editor. I suspect that the way mousePressedEvent() is written means that the double click event isn't generated if the selection change is driven from there (I don't think it should be driven from there - rather it should be driven from a mouseClickedEvent()) which isn't present. I do see code in mousPressedEvent() that is intended to open the editor, but don't quite "get" why that wasn't invoked.

David

mpergand

@Perdrix said in QTableView clicked() versus doubleClicked():

What it doesn't do is open the editor on the cell that was double clicked!

Check editTriggers is set to QAbstractItemView::DoubleClicked

Perdrix

It must be set because I can d-click the cell later (after the image has loaded) and it opens the editor just fine

SGaist

Did you keep any custom code / event filter after changing to use the selection model ?

Perdrix

@SGaist No Sir

SGaist

Then please share a minimal compilable example that shows this behaviour.