Show live data into a table

SGaist

On addition to @kshegunov you also need to re-implement setData so that you can properly notify when data changes.

makopo

I did not understand how to implement insertRows() correctly and it also looks like that the function is not called. Because the QAbstractTableModel did not work, I rebuild the Qt tutorial which uses the QAbstractListModel.

In insertRows() I call beginInsertRows(), than I run the loop and than I call endInsertRows().

bool DataTableModel::insertRows(int position, int rows, const QModelIndex& parent)
{
    beginInsertRows(QModelIndex(), position, position + rows - 1);
    for (int x = 1; x <= 10; ++x) {
        m_stringList.push_back(QString::number(x));
    }
    endInsertRows();
    qDebug() << "insertRows is called.";

    return true;
}

As result I get an empty List. On console I can also see that the function is not called. So my question is, how to handle insertRows() function? Did stringList.insert(position, ""); from the Model/View Programming tutorial only reservs an empty line? I thought that there is the entry-point where I have to insert the data.

JonB

@makopo
Your insertRows() is called with a position to start the insert from and a number of rows to insert there. But all you do is ignore these and append 10 rows. You need to respect and act on the parameters. (Same btw for deleteRows().) The newly inserted rows should be blank for this call.

makopo

@JonB
Thank you. I rewrote the loop as recommended in the Model/View Programming tutorial.

beginInsertRows(QModelIndex(), position, position + rows - 1);
for (int row = 0; row < rows; ++row) {
    m_stringList.insert(position, "");
}
endInsertRows();
qDebug() << "insertRows is called.";

As I can see on the console insertRows() is not called.

JonB

@makopo
? Why/when do you expect it to be called? You have to call it if you wish to insert some rows. (And again for deleteRows().)

makopo

@JonB

insertRows(int row, int count, const QModelIndex &parent = QModelIndex()) is virtual. I thought it is called automatically?

As I understand now m_stringList.insert(position, ""); only reservs an empty row and I have to add data to the table outside the model class?

JonB

@makopo
The virtual just means that if anything calls QAbstractTableModel::insertRows() --- even if it knows nothing about your derived class --- the implementation code you have written will be called.

The outside world will call insertRows() when it wants/needs to. The outside world will do that with no knowledge that you have implemented it via m_stringList.insert(). The outside world will call setData() for the desired column values on newly inserted row(s) after it has called insertRows().

makopo

@JonB
That was not clear for me. I did not call the headerData(...) and data(...) function. I only generate a instance of the model class, set the model to the view and get a table. Thought that setData(...) and insertRows(...) works on the same way.

So as I understand from your last post, I have to do something like this:

//QMainClass.cpp
m_tableDataModel->insertRows(0, 1, QModelIndex());
m_tableDataModel->setData(QModelIndex(), QParameterList(), QValueList(), 2); //valuelist is a vector and stores data that should be overwritten in the view
m_tableView->setModel(m_tableDataModel);

I'am sry. As a beginner the principle of table view is hard to understand.

JonB

@makopo
Those are the right calls. But you'll have to work a bit on all your parameters to setData(). If you have multiple columns (I don't know if you do) you'll have to call setData() for each one.

SGaist

A QTableView is just a widget showing your model as a table. Nothing more.

From the looks of it, you did not understand that the model is a wrapper on top of your data structure. From what you wrote it's a QStringList. So you have a model with a single column and as many rows as your string list.

The setData method shall be called to modify the data of one element of your data structure.

If you want to initialise your model with a ready made list, add a method for that.

Note that if your data structure is a QStringList you might as well use the QStringListModel class.

makopo

I think I understand the principle of a model. Because of this I didn't understand why in this example an empty string is inserted. I think this little for loop is my problem. Why they insert data here?

bool StringListModel::insertRows(int position, int rows, const QModelIndex &parent)
{
    beginInsertRows(QModelIndex(), position, position+rows-1);

    for (int row = 0; row < rows; ++row) {
        stringList.insert(position, ""); //empty strings are inserted in every row (inserting data alike)?
    }

    endInsertRows();
    return true;
}

In my project I use two columns. Column 0 includes labels and is fixed, so I think I didn't need SetData() for the first column. Column 1 gets values of different types and this values should be constantly updated. For both columns I use a QVector<QString>. To add data to the vector I wrote two functions: QParameterList() and QValueList(). I also implement a function AddData() that has a QVector<QString> type as parameter.

void DataTableModel::AddData(const QVector<QString>& parameter)
{
    m_parameter = parameter;
}

In my QMainClass I call AddData() and with this I generate the first column (column with the fixed values). Now I call the reimplemented SetData() function and insert (only for test purposes) data to one cell. I got an empty cell. I can fill all cells in column 1 manually, I get an empty column. I think this happens because the empty string overrides the value, I inserted with SetData(...)?

QVariant DataTableModel::SetData(const QModelIndex& index, const QVariant& value, int role)
{
    if (role == Qt::DisplayRole && index.row() == 0 && index.column() == 1) {
        return QString(value.toString());

    }
    return QVariant();
}

// QMainClass.cpp
QVariant value = QString("Test");
m_tableDataModel->InsertRows(QModelIndex(), 0, 3);
m_tableDataModel->AddData(QParameterList());
m_tableDataModel->SetData(QModelIndex(), value, 2);
m_tableView->setModel(m_tableDataModel);

SGaist

When you add rows, your data structure should contain something that can be returned to the view. Still in the case of your string list, you shall adjust the size of the list and then put some meaningful default data in the new empty spots. In this case empty strings.

Your SetData method does not make sense. By the way, the correct name is setData. Casing is important.

makopo

Thank you. I will do a next try...:

//DataTableModel.cpp
bool DataTableModel::setData(const QModelIndex& index, const QVariant& value, int role)
{
    if (!index.isValid() && role != Qt::EditRole) {
        return false;
    }
    //change only values in column 1
    if (index.column() == 1) {
        m_value.replace(index.row(), value.toString());
        emit dataChanged(index, index, { role });
        return true;
    }
}

bool DataTableModel::insertRows(int row, int count, const QModelIndex& parent)
{
    beginInsertRows(QModelIndex(), row, row + count - 1);
    for (int i = 0; i < count; ++i) {
        m_value.insert(row, "");
    }
    endInsertRows();
    return true;
}

//QMainClass.cpp - called when button is clicked.
void QMainClass:QAddTableContent()
{
    QVariant values(QValueList()); //convert QList to QVariant

    m_tableDataModel->insertRows(0, 5, QModelIndex()); //insert 5 rows
    m_tableDataModel->AddData(QParameterList());
    m_tableDataModel->setData(QModelIndex(), values, 2);
}

With this I get a table with 5 rows and 2 columns. The left column shows a list of parameters. The right column is empty.
In the model I set the Qt::ItemIsEditable flag. With this I can edit the right column. I can write into the cells and the new values are stored temporary. Because of this I think the setData() function should work correct. Unfortunatly, when the program runs, the right column remains empty (because of the inserted empty string in insertRows?). Are the data inserted on a wrong way?

SGaist

How is your data method implemented currently ?

makopo

@SGaist

This is my data method:

QVariant DataTableModel::data(const QModelIndex& index, int role) const
{
    if (!index.isValid()) {
        return QVariant();
    }

    if (index.row() >= m_parameter.size() && index.row() >= m_value.size()) {
        return QVariant();
    }

    if (role == Qt::DisplayRole || role == Qt::EditRole) {
        switch (index.column()) {
        case 0:
            return m_parameter.at(index.row());
            break;
        case 1:
            return m_value.at(index.row());
            break;
        default:
            Q_ASSERT(false);
        }
    }
    return QVariant();
}

JonB

@makopo
One logic fault I see is: In your insertRows() you increase the length of m_value (inserting "" into it in the new row), but you do nothing to increase the length of m_parameter correspondingly. That should mean that your data()'s return m_parameter.at(index.row()); can go wrong/crash after an insertion.

Another issue is that as you show your latest setData() it has no final, unconditional return statement at the end. This should have generated a compiler error or warning?

makopo

@JonB

Correcting this does not bring a change.

When I debug the setData() method I with the index and the values for r, c, i and m (does it mean, row, column, internal pointer and model of QmodelIndex class?) are undefined. The detailed message for r, c, i, m is "Can not read memory".

SGaist

@makopo said in Show live data into a table:

When I debug the setData() method I with the index and the values for r, c, i and m (does it mean, row, column, internal pointer and model of QmodelIndex class?) are undefined.

What are r, c, i and m ?

You should post the complete code of your model class.

By the way, you should use QAbstractModelTester to validate your implementation.

makopo

@SGaist said in Show live data into a table:

What are r, c, i and m ?

Screenshot VS

Can not recognize this error, it did not happen again...

I rewrote my model class. The values are shown in the view, but the view did not update automatically. This is the whole code:

#pragma once
#include <QAbstractTableModel>
#include <QDebug>


struct DataTableItem {

	QString m_parameter;
	QString m_value;
};

class DataTableModel : public QAbstractTableModel {

	Q_OBJECT

public:
	DataTableModel(QObject* parent = nullptr);
	DataTableModel(const QList<DataTableItem>& tableItem, QObject* parent = nullptr);

	//functions of QAbstractItemModel
	Qt::ItemFlags flags(const QModelIndex& index) const override;
	QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
	QVariant data(const QModelIndex& index, int role) const override;
	bool insertRows(int rows, int count, const QModelIndex& parent) override;
	bool setData(const QModelIndex& index, const QVariant& value, int role = Qt::EditRole) override;
	int rowCount(const QModelIndex& parent) const override;
	int columnCount(const QModelIndex& parent) const override;
	const QList<DataTableItem>& GetTableItem() const;

private:
	QList<DataTableItem> m_tableItem;
};

#include "DataTableModel.h"

//Ctor
DataTableModel::DataTableModel(QObject* parent)
	: QAbstractTableModel(parent) 
{}


DataTableModel::DataTableModel(const QList<DataTableItem>& tableItem, QObject* parent)
    : QAbstractTableModel(parent),
    m_tableItem(tableItem) 
{}


const QList<DataTableItem>& DataTableModel::GetTableItem() const
{
    return m_tableItem;
}


/**
* Returns the item flags for the given index. Sets the cells to editable
*/
Qt::ItemFlags DataTableModel::flags(const QModelIndex& index) const
{
    if (index.isValid())
        return Qt::ItemIsSelectable | Qt::ItemIsEnabled | Qt::ItemIsEditable;
    
    return QAbstractItemModel::flags(index);
}


/**
* Defines the header label of the table
*/
QVariant DataTableModel::headerData(int section, Qt::Orientation orientation, int role) const
{
    if (role != Qt::DisplayRole)
        return QVariant();

    if (role == Qt::DisplayRole && orientation == Qt::Horizontal) {
        switch (section) {
        case 0:
            return QString("Parameter");
            break;
        case 1:
            return QString("Wert");
            break;
        default:
            break;
        }
    }
    return QVariant();
}


/**
* Counts the number of rows which depends from the QStringList that is defined in QVideoMeter.cpp
*/
int DataTableModel::rowCount(const QModelIndex& parent) const
{
    return m_tableItem.count();
}


/**
* Defines the number of columns. This table only have two columns
*/
int DataTableModel::columnCount(const QModelIndex& parent) const
{
    return 2;
}


bool DataTableModel::insertRows(int row, int count, const QModelIndex& parent)
{
    //the following two methods emits signals that tells the view that the data should be changed
    beginInsertRows(QModelIndex(), row, row + count - 1);
    for (int i = 0; i < count; ++i)
        m_tableItem.insert(row, { QString(), QString() });
    endInsertRows();
    return true;
}


/**
* Defines the data that should be rendered to a table cell
* The QModelIndex class is used to locate data in a data model.
*/
QVariant DataTableModel::data(const QModelIndex& index, int role) const
{
    if (!index.isValid()) {
        return QVariant();
    }

    if (index.row() <0 || index.row() >= m_tableItem.count()) {
        return QVariant();
    }

    const DataTableItem& item = m_tableItem.at(index.row());
    if (role == Qt::DisplayRole || role == Qt::EditRole) {
        switch (index.column()) {
        case 0:
            return item.m_parameter;
            break;
        case 1:
            return item.m_value;
            break;
        default:
            break;
        }
    }
    return QVariant();
}


/*
* Sets the role data for the item at index to value.
*/
bool DataTableModel::setData(const QModelIndex& index, const QVariant& value, int role)
{
    if (index.isValid() && role == Qt::EditRole) {
        const int row = index.row();
        DataTableItem item = m_tableItem.value(row);

        switch (index.column()) {
        case 0:
            item.m_parameter = value.toString();
            break;
        case 1:
            item.m_value = value.toString();
            break;
        default:
            return false;
        }
        m_tableItem.replace(row, item);
        emit dataChanged(index, index, { Qt::DisplayRole, Qt::EditRole });

        return true;
    }
    return false;
}

/**
* Called when start button is clicked. Call functions of QAbstractItemModel
*/
void QVideoMeter::QAddTableContent()
{
    BSTR displayModeName; //COM data type
    QString parameters = "Framerate";
    QString values = QVariant(m_displayMode->GetWidth()).toString();

    m_tableDataModel->insertRows(0, 3, QModelIndex());
    QModelIndex index = m_tableDataModel->index(0, 0, QModelIndex());
    m_tableDataModel->setData(index, parameters, Qt::EditRole);
    index = m_tableDataModel->index(0, 1 , QModelIndex());
    m_tableDataModel->setData(index, values, Qt::EditRole);
}

It will be very friendly if someone of you can give my feedback.

JonB

@makopo
Glancing through your code looks reasonable to me. So what exactly does not work when? You say "but the view did not update automatically.". What does not happen when you do what? I assume you have checked your view is connected to this data model? Have you stepped through in debugger? Put in qDebug()s, like to ensure your emit dataChanged() is being hit?