QGroupBox, QScrollArea, QFormLayout

[mchinand]

@SPlatten said in QGroupBox, QScrollArea, QFormLayout:

Later in the project I want to get the form so I can add content to it:
QFormLayout* pfrmloErrors(qobject_cast<QFormLayout*>(pgrpErrors->layout()));

Shouldn't this be:
QFormLayout* pfrmloErrors = qobject_cast<QFormLayout*>(pgrpErrors->layout());

[SPlatten]

@mchinand , I really don't know, should it?

I've modified the code to:

psaErrors = new QScrollArea(this);
pgrpErrors = new QGroupBox(this);
QFormLayout* pfrmloErrors(new QFormLayout);
pgrpErrors->setLayout(pfrmloErrors);
psaErrors->setWidget(pgrpErrors);

A box appears but no content displayed.

[JonB]

@SPlatten
The QFormLayout is on psaErrors (QScrollArea*). So why do you try to obtain it from pgrpErrors (QGroupBox*)?

[mchinand]

Yes, if you're just getting a reference to the existing layout (see @JonB 's comment on whether that's the correct layout that you want).

[SPlatten]

@JonB See post I made whilst you posted yours...

[JonB]

@SPlatten
I could easily be wrong, so don't push me too much, but both QScrollArea and QGroupBox are containers, I thought you add widgets to these but not layouts? Maybe first design this in Designer so it looks like what you want, and then look at the code that generates? Or, ignore this if my post is off-target.

[SPlatten]

@JonB , thank you, I will have a go in Qt Creator.

[SPlatten]

@JonB , @mchinand , a little better...

psaErrors = new QScrollArea(this);
pfrmloErrors = new QFormLayout;
psaErrors->setLayout(pfrmloErrors);

This works now, however its still not quite right...if the number of rows in the form is greater than 4 then the row height of each item is squashed, whats happening?

The QScrollArea widget doesn't appear around the content that can be scrolled, the QScrollArea appears top left on the display, very small, is this a default, do I have to set the geometry of the QScrollArea manually?

Also, how do I set the maximum height of the scrollable area?

[JonB]

@SPlatten
Does not sound right. I am not the right person to ask about this, but....

... That does not sound at all like I understood QScrollArea to work. Look at https://doc.qt.io/qt-5/qscrollarea.html#details and examples elsewhere. My understanding is:

QWidget *yourWidget;
// put whatever you like on your widget, set your `QFormLayout` there
QScrollArea *scrollArea;
scrollArea->setWidget(yourWidget);

[SPlatten]

@JonB , I think the problem is I want to scroll a QVBoxLayout which isn't a widget. Here is the code and a screenshot of the results:

        mpvbloErrors = new QVBoxLayout(this);
        QWidget* pobjErrorPadding(new QWidget(this));
        mpsaErrors = new QScrollArea(this);
        mpsaErrors->setWidget(pobjErrorPadding);
        mpfrmloErrors = new QFormLayout(pobjErrorPadding);
        mpvbloErrors->addWidget(pobjErrorPadding);
        pobjErrorPadding->setLayout(mpfrmloErrors);
        mpsaErrors->setFixedHeight(100); // Just a fiddle to see what happens
        QPushButton* pbtnAck(new QPushButton(tr("&Clear Errors")));
        QObject::connect(pbtnAck, &QPushButton::clicked,
            [this, pbtnAck, pobjErrorPadding]
            {
                pbtnAck->setVisible(false);
                pobjErrorPadding->setVisible(false);
            }
        );
        mpvbloErrors->addWidget(pbtnAck, 1);

cid:ii_kvb2bvn50
The empty box at the top left is the scroll area and using the scroll bars does move the image under it. I also want to limit the height of the text rows under to say two rows and scroll vertically to the rest.

[Christian Ehrlicher]

@SPlatten said in QGroupBox, QScrollArea, QFormLayout:

    mpsaErrors->setWidget(pobjErrorPadding);

...

    mpvbloErrors->addWidget(pobjErrorPadding);

It's only doing what you ask for - pobjErrorPadding is a child of mpvbloErrors and not mpsaErrors after this.

[SPlatten]

@Christian-Ehrlicher , thank you, I will look again.

[SPlatten]

More edits, still not right:

        mpvbloErrors = new QVBoxLayout(this);
        mpsaErrors = new QScrollArea;       
        mpvbloErrors->addWidget(mpsaErrors);
        mpfrmloErrors = new QFormLayout;
        mpvbloErrors->addItem(mpfrmloErrors);
        int intFixedHeight(fontMetrics().height() * MainWindow::mscuintErrorRows);
        mpsaErrors->setFixedHeight(intFixedHeight);
        QPushButton* pbtnAck(new QPushButton(tr("&Clear Errors")));
        QObject::connect(pbtnAck, &QPushButton::clicked,
            [this, pbtnAck]
            {
                mpsaErrors->setVisible(false);
                pbtnAck->setVisible(false);
            }
        );
        mpvbloErrors->addWidget(pbtnAck, 1);
        QWidget* pobjErrorWrapper(this);
        pobjErrorWrapper->setLayout(mpvbloErrors);

Now there should be red rows shown, expecting 3 but nothing...

[SGaist]

Hi,

As @JonB already wrote, QScrollArea is a container widget so 99% of the time you do not set a layout on it. You are in these 99%.

As already suggested, use a QWidget on which you apply the QFormLayout and set that widget on the QScrollArea.

You will then have the result you expect.

[SPlatten]

@SGaist , latest code:

        mpobjErrors = new QWidget(this);      //Wrapper/container for everything
        mpvbloErrors = new QVBoxLayout;       //Vertical layout for error messages
        mpsaErrors = new QScrollArea;         //Vertical layout to be scrollable
        mpsaErrors->setWidget(mpobjErrors);   //Add scroll area to container
        mpobjErrors->setLayout(mpvbloErrors); //Add vertical layout to container
        int intFixedHeight(fontMetrics().height() * MainWindow::mscuintErrorRows);
        mpsaErrors->setFixedHeight(intFixedHeight);  //Large enough for 3 rows of errors
        mpvbloErrors->addStretch(1);          
        QPushButton* pbtnAck(new QPushButton(tr("&Clear Errors")));
        QObject::connect(pbtnAck, &QPushButton::clicked,
            [this, pbtnAck]
            {
                mpobjErrors->setVisible(false);
            }
        );
        mpfrmloErrors = new QFormLayout;       //Layout for errors, time and cause
        mpvbloErrors->addLayout(mpfrmloErrors, 1); //Add form to vertical layout
        mpvbloErrors->addWidget(pbtnAck, 1, Qt::AlignHCenter); //Add button to container

The result from is:

I only want 3 lines to be displayed and the rest to be accessed using the scroll bar, but there is no scroll bar.

Its the QFormLayout that is used to display the error lines, the QVBoxLayout is used to contain the QFormLayout and the Clear Errors button at the bottom. I want the QFormLayout to be scrollable.

[edit]...:

    //Create container for errors panel
        mpobjErrors = new QWidget(this);
        mpvbloErrors = new QVBoxLayout;
        mpobjErrors->setLayout(mpvbloErrors);
    //Create a widget that contains the scrollable errors form
        QWidget* pobjFormErrorsContr(new QWidget(mpobjErrors));
        mpfrmloErrors = new QFormLayout;
        pobjFormErrorsContr->setLayout(mpfrmloErrors);
        int intFixedHeight(fontMetrics().height() * MainWindow::mscuintErrorRows);
        mpsaErrors = new QScrollArea;
        mpsaErrors->setWidget(pobjFormErrorsContr);
        mpsaErrors->setFixedHeight(intFixedHeight);
        mpvbloErrors->addWidget(pobjFormErrorsContr, 1, Qt::AlignHCenter);
    //Create a push button for acknowledging and clearing errors panel
        QPushButton* pbtnAck(new QPushButton(tr("&Clear Errors")));
        mpvbloErrors->addWidget(pbtnAck, 1, Qt::AlignHCenter);
        QObject::connect(pbtnAck, &QPushButton::clicked,
            [this, pbtnAck]
            {
                mpobjErrors->setVisible(false);
            }
        );
    //Default to hidden until errors are available to display
        mpobjErrors->setVisible(false);

I thought perhaps an additional widget container would be required for the QFormLayout, didn't help.

[SGaist]

Why do you have a QVBoxLayou and a QFormLayout in mpobjErrors on the widget in your QScrollArea ?

The logic would rather be

-- QWidget ("this" in your sample code)
--- QVBoxLayout
---- QScrollArea (fixed height)
----- QWidget
------ QFormLayout
------- Dynamic number of widgets
---- QPushButton -> clear button

So you don't have to hunt for the clear button if you have lots of errors.

Note that depending on how many errors there might be limiting to three lines may not be the best user experience.

[SPlatten]

@SGaist , its supposed to be like this:

QWidget( mpobjErrors )
-- QVBoxLayout( mpvbloErrors )
----- QWidget( pobjFormErrorsContr )
-------- QScrollArea( fixed height )
-------- QFormLayout( mpfrmloErrors  )
----- QPushButton( pbtnAck )

Where only the QFormLayout is scrollable, but it isn't.

[JonB]

@SPlatten

----- QWidget( pobjFormErrorsContr )
-------- QScrollArea( fixed height )
-------- QFormLayout( mpfrmloErrors  )

But I/we already said that QScrollArea takes a setWidget(someWidget) for the thing it wants to scroll, which has to be a QWidget not a QLayout.

Also your QFormLayout is not anywhere descended from QScrollArea, it's a sibling, so it's not inside it, so it won't be subject to scrollability.

[SPlatten]

@JonB , see code above:

mpsaErrors = new QScrollArea;
mpsaErrors->setWidget(pobjFormErrorsContr);

[JonB]

@SPlatten
I see your code, my two comments apply to your "diagram", and comparing it to @SGaist's "diagram".