Include 2 more OpenFile buttons next to an already exist

JonB

@john_hobbyist
If you're saying the original code you show with QAction works fine, compare how you have used QAction to that.

Have you put yours in that same third-party file, or in another file of your own?

john_hobbyist

I have took the code from the github that I have posted above and I put:

open_btn = QAction("Open Image File", self, triggered=self.openFile)
open_btn.setIcon(QIcon.fromTheme("document-open"))
self.tb.addAction(open_btn)

open_btn2 = QAction("Open Image File 2", self, triggered=self.openFile2)
open_btn2.setIcon(QIcon.fromTheme("document-open"))
self.tb.addAction(open_btn2)

and I got this error:

NameError: name 'QAction' is not defined

and I am trying to fix it... Thank you!

JonB

@john_hobbyist
Answer the two questions I wrote above:

Did the code with QAction in it as fetched from github, without you making any changes, work or give that error?
Have you put the new code you have written in the OrthoViewLite.py as fetched from github, or have you put it in a file of your own?

john_hobbyist

@JonB :

Yes the code from github (without any changes) works fine
Yes I put the code you suggested:

open_btn = QAction("Open Image File", self, triggered=self.openFile)
open_btn.setIcon(QIcon.fromTheme("document-open"))
self.tb.addAction(open_btn)

open_btn2 = QAction("Open Image File 2", self, triggered=self.openFile2)
open_btn2.setIcon(QIcon.fromTheme("document-open"))
self.tb.addAction(open_btn2)

to the github code, and I face the error:

NameError: name 'QAction' is not defined

JonB

@john_hobbyist said in Include 2 more OpenFile buttons next to an already exist:

Yes I put the code you suggested:

I did not suggest any code to you.

I have now asked you twice:

Have you put the new code you have written in the OrthoViewLite.py as fetched from github, or have you put it in a file of your own?

If you can't or won't answer that question, I can't help you.

john_hobbyist

@JonB: I have downloaded the code from the github: https://github.com/Axel-Erfurt/OrthoViewLite/blob/main/OrthoViewLite.py (which is not my account) and put it in a file on my own.

SGaist

Hi,

From the looks of it, your imports are missing the required class.

JonB

@john_hobbyist

@SGaist said in Include 2 more OpenFile buttons next to an already exist:

Hi,

From the looks of it, your imports are missing the required class.

That is why I asked. When you now say

and put it in a file on my own.

what did you do about the import statements in the code you were copying from?

john_hobbyist

@JonB: What do I need to import?

JonB

@john_hobbyist
You need to look at the code you are copying from which works, and read the error message.

john_hobbyist

Ok, I fixed it, it runs, but I do not see the other two open file buttons... What does this line do?

self.beamPosRectified = [0,0]

I am trying to display totally 3 open file buttons one next to others. The original and the 2 new....

jsulm

@john_hobbyist said in Include 2 more OpenFile buttons next to an already exist:

What does this line do?

It assigns a list with two 0 to a member variable...

Post your code if it doesn't work.

john_hobbyist

# -*- coding: utf-8 -*-
"""
OrthoViewLite.py
based on https://github.com/kklmn/OrthoView by Konstantin Klementiev
modified by Axel Schneider (added File Selector)
https://github.com/Axel-Erfurt
"""

__author__ = "Konstantin Klementiev"
__versioninfo__ = (1, 0, 2)
__version__ = '.'.join(map(str, __versioninfo__))
__date__ = "8 Feb 2020"
__license__ = "MIT license"

import os
import sys
import cv2
from matplotlib.figure import Figure
import numpy as np
from PyQt5 import QtGui as qtcore
from PyQt5 import QtWidgets as qtwidgets
from PyQt5 import Qt as qt
import matplotlib.backends.backend_qt5agg as mpl_qt

try:
    from ConfigParser import ConfigParser
except ImportError:
    from configparser import ConfigParser

isTest = True

selfDir = os.path.dirname(__file__)
iniApp = (os.path.join(selfDir, 'OrthoViewList.ini'))
config = ConfigParser(
    dict(pos='[0, 0]', corners='[None]*4', scalex=0, scaley=0))
config.add_section('window')
config.read(iniApp)


def write_config():
    with open(iniApp, 'w+') as cf:
        config.write(cf)


class MyToolBar(mpl_qt.NavigationToolbar2QT):
    def set_message(self, s):
        try:
            parent = self.parent()
        except TypeError:
            parent = self.parent

        try:
            sstr = s.split()

            while len(sstr) > 5:
                del sstr[0]
            x, y = float(sstr[0][2:]), float(sstr[1][2:])
            s = f'x = {x:.2f}\ny = {y:.2f}'
        except Exception as e:
            pass
            #print(e)

        if self.coordinates:
            self.locLabel.setText(s)


class MyMplCanvas(mpl_qt.FigureCanvasQTAgg):
    def __init__(self, parent=None):
        self.fig = Figure()
        self.fig.patch.set_facecolor('None')
        super(MyMplCanvas, self).__init__(self.fig)
        self.setParent(parent)
        self.updateGeometry()
        self.setupPlot()
        self.mpl_connect('button_press_event', self.onPress)
        self.img = None
        self.setContextMenuPolicy(qt.Qt.CustomContextMenu)
        self.mouseClickPos = None

        self.menu = qt.QMenu()


    def setupPlot(self):
        rect = [0., 0., 1., 1.]
        self.axes = self.fig.add_axes(rect)
        self.axes.axis("off")

    def imshow(self, img):
        if self.img is None:
            self.img = self.axes.imshow(img)
        else:
            prev = self.img.get_array()
            self.img.set_data(img)
            if prev.shape != img.shape:
                self.img.set_extent(
                    [-0.5, img.shape[1]-0.5, img.shape[0]-0.5, -0.5])
                self.axes.set_xlim((0, img.shape[1]))
                self.axes.set_ylim((img.shape[0], 0))
                self.toolbar.update()
        self.draw()

    def onPress(self, event):
        if (event.xdata is None) or (event.ydata is None):
            self.mouseClickPos = None
            return
        self.mouseClickPos = int(round(event.xdata)), int(round(event.ydata))


class OrthoView(qt.QMainWindow):
    def __init__(self, parent=None):
        super(OrthoView, self).__init__(parent)

        self.setWindowTitle('OrthoViewLite')
        self.setStyleSheet("QMainWindow {background: #e9e9e9;} QHBoxLayout {background: #e9e9e9;} QTreeView {background: #e9e9e9;}  FigureCanvasQTAgg {background: #e9e9e9;}")
        self.setMinimumSize(500, 350)
        self.image_file_path = ""   
        if config.has_option('window', 'win_left') and config.has_option('window', 'win_top') \
            and config.has_option('window', 'win_width') and config.has_option('window', 'win_height'):
            left = int(config.get('window', 'win_left'))
            top = int(config.get('window', 'win_top'))
            width = int(config.get('window', 'win_width'))
            height = int(config.get('window', 'win_height'))
            self.setGeometry (left, top, width, height)

        self.tb = qtwidgets.QToolBar("File")
        open_btn = qtwidgets.QAction("Open Image File", self, triggered=self.openFile)
        open_btn.setIcon(qtcore.QIcon.fromTheme("document-open"))
        self.tb.addAction(open_btn)
        self.beamPosRectified = [0, 0]
######################################################################################  
        self.tb = qtwidgets.QToolBar("File1")   
        open_btn = qtwidgets.QAction("Open Image File", self, triggered=self.openFile)
        open_btn.setIcon(qtcore.QIcon.fromTheme("document-open"))
        self.tb.addAction(open_btn)
        
        self.tb = qtwidgets.QToolBar("File2") 
        open_btn2 = qtwidgets.QAction("Open Image File 2", self, triggered=self.openFile)
        open_btn2.setIcon(qtcore.QIcon.fromTheme("document-open"))
        self.tb.addAction(open_btn2)
#######################################################################################
        self.plotCanvas = MyMplCanvas(self)
        self.plotCanvas.setSizePolicy(
            qt.QSizePolicy.Expanding, qt.QSizePolicy.Expanding)
        self.toolbar = MyToolBar(self.plotCanvas, self)
        for action in self.toolbar.findChildren(qtwidgets.QAction):
            if action.text() in ['Customize', 'Subplots']:
                action.setVisible(False)
        self.toolbar.locLabel.setAlignment(qt.Qt.AlignCenter)

        self.tb.setContextMenuPolicy(qt.Qt.PreventContextMenu)
        self.tb.setMovable(False)
        self.tb.setAllowedAreas(qt.Qt.TopToolBarArea)
        self.toolbar.setContextMenuPolicy(qt.Qt.PreventContextMenu)
        self.toolbar.setMovable(False)
        self.toolbar.setAllowedAreas(qt.Qt.TopToolBarArea)
        self.addToolBar(self.tb)
        self.addToolBar(self.toolbar)

        mylayout = qtwidgets.QHBoxLayout()
        mylayout.addWidget(self.plotCanvas)
        
        self.mylistwidget = qtwidgets.QTreeView()
        self.mylistwidget.setFixedWidth(300)
        mylayout.addWidget(self.mylistwidget)
        
        self.fileModel = qtwidgets.QFileSystemModel()
        self.fileModel.setFilter(qt.QDir.NoDotAndDotDot | qt.QDir.Files | qt.QDir.AllDirs)
        self.fileModel.setRootPath(qt.QDir.homePath())
        
        self.mylistwidget.setModel(self.fileModel)
        self.mylistwidget.setRootIndex(self.fileModel.index(qt.QStandardPaths.standardLocations(qt.QStandardPaths.PicturesLocation)[0]))
        
        self.mylistwidget.selectionModel().selectionChanged.connect(self.on_clicked)
        self.mylistwidget.clicked.connect(self.tree_clicked)
        col = [1, 2, 3, 4]
        for c in col:
            self.mylistwidget.hideColumn(c)
        
        mywidget = qtwidgets.QWidget()
        mywidget.setLayout(mylayout)
        self.setCentralWidget(mywidget)
        
        self.myfilter = ["tif", "tiff", "png", "jpg"]
        self.treefilter = ["*.tif", "*.tiff", "*.png", "*.jpg"]
        
        self.fileModel.setNameFilters(self.treefilter)
        self.fileModel.setNameFilterDisables(False)

        self.mylistwidget.setFocus()        
        self.mylistwidget.resizeColumnToContents(1)

    def on_clicked(self):
        index = self.mylistwidget.currentIndex()
        path = self.fileModel.fileInfo(self.mylistwidget.currentIndex()).absoluteFilePath()
        if qt.QDir.exists(qt.QDir(path)):
            print(path, "is folder")
        else:
            if path.rpartition(".")[2] in self.myfilter:
                print(path)
                self.image_file_path = path
                isTest = True
                self.updateFrame()
        
    def tree_clicked(self):
        index = self.mylistwidget.currentIndex()
        if not self.mylistwidget.isExpanded(index):
            self.mylistwidget.setExpanded(index, True) 
            self.mylistwidget.resizeColumnToContents(0)
        else:
            self.mylistwidget.setExpanded(index, False) 
            self.mylistwidget.resizeColumnToContents(0)
        
    def openFile(self):
        print("open File Dialog")
        path, _ = qt.QFileDialog.getOpenFileName(self, "Open File", self.image_file_path,"Image Files (*.tif *.tiff *.png *.jpg)")
        if path:
            if os.path.isfile(path):
                self.image_file_path = path
                print("file exists:",self.image_file_path)
                isTest = True
                self.updateFrame()
            else:
                print("file not exists")        

    def getFrame(self, path):
        if isTest:
            if os.path.isfile(path):
                frame = cv2.imread(path, 1)
                if not np.shape(frame) == ():
                    # OpenCV uses BGR as its default colour order for images
                    self.img = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB)
                else:
                    print("no image!")
            else:
                self.openFile()

    def updateFrame(self):
        self.getFrame(self.image_file_path)
        overlay = self.img.copy()
        alpha = 0.75  # transparency factor
        imageNew = cv2.addWeighted(overlay, alpha, self.img, 1-alpha, 0)
        self.plotCanvas.imshow(imageNew)
        
    def closeEvent(self, e):
        config.set('window', 'win_left', str(self.geometry().x()))
        config.set('window', 'win_top', str(self.geometry().y()))
        config.set('window', 'win_width', str(self.geometry().width()))
        config.set('window', 'win_height', str(self.geometry().height()))
        
        with open(iniApp, 'w+') as cf:
            config.write(cf)


if __name__ == "__main__":
    app = qt.QApplication(sys.argv)
    icon = qt.QIcon(os.path.join(selfDir, '_static', 'orthoview.ico'))
    app.setWindowIcon(icon)

    window = OrthoView()
    window.show()
    sys.exit(app.exec_())

jsulm

@john_hobbyist said in Include 2 more OpenFile buttons next to an already exist:

self.tb = qtwidgets.QToolBar("File1")
self.tb = qtwidgets.QToolBar("File2")

Why do you create 3 tool bars now?! You can use the one from the code you're using and simply add additional QAction for your additional buttons to it.
You really should read the code more carefully and try to understand what it is actually doing...

john_hobbyist

Ok thanks, I changed it.
The open_btn and open_btn2 are where it stores the path of the file that I choose, right?

jsulm

@john_hobbyist said in Include 2 more OpenFile buttons next to an already exist:

The open_btn and open_btn2 are where it stores the path of the file that I choose, right?

These buttons will do what YOU tell them to do.
In this line:

open_btn2 = qtwidgets.QAction("Open Image File 2", self, triggered=self.openFile)

you see self.openFile, this is a method which will be called when the user clicks the button. You have to write it and do what ever you want/need to do.

john_hobbyist

This post is deleted!