Correct syntax to register object reference using qRegisterMetaType?

SGaist

Hi,

Don't pass references in parameters. As @JKSH wrote earlier, most of Qt datatypes are implicitly shared so there's really no need to try to go that way.

If you are forcing the Qt::DirectConnection because of that then it means you have a design issue. It's currently pretty rare to have to do that and it also has consequences when doing multithreading.

SPlatten

@SGaist , I want to pass by reference because my understanding of passing by reference is that it is far less costly on stack space. A QJsonObject can be very large.

kshegunov

@SPlatten said in Correct syntax to register object reference using qRegisterMetaType?:

I want to pass by reference because my understanding of passing by reference is that it is far less costly on stack space. A QJsonObject can be very large.

Your understanding is irrelevant in this case. You were told it isn't possible with a queued connection, and it still isn't, and it is not going to be, no matter how much we argue about it. The warning is there for a reason - to warn you that you have a serious bug in your code. You can either use a direct connection and suffer the inevitable consequences of that, or use const QJsonObject &/QJsonObject for your signal arguments.

SPlatten

@kshegunov , I am using const QJsonObject& for my signal arguments, these are working, the only thing that is displayed in the Application Output is the message I've raised. I'm not experience any other problems, crashes or bugs.

JonB

@SPlatten
The signal argument type is "OK", insofar as it would work OK with non-cross-thread direct connection connect()s. But the problem is that you are trying to use it when you need a queued connection. That is why you get the error message on the QObject::connect statement.

SPlatten

@JonB , thank you, I'll take a look.

SGaist

@SPlatten said in Correct syntax to register object reference using qRegisterMetaType?:

@kshegunov , I am using const QJsonObject& for my signal arguments, these are working, the only thing that is displayed in the Application Output is the message I've raised. I'm not experience any other problems, crashes or bugs.

For the slots as well ?

SPlatten

@SGaist Of course.

SPlatten

Ok, I've now got rid of the warning, by going through all the QObject::connect calls and only using Qt::DirectionConnection where the signal and slot pointers are the same.

JonB

@SPlatten
A lot of your questions are about threads. Are your connect()s' senders/receivers never in separate threads?

SPlatten

@JonB , not for the ones where I've used Qt::DirectConnection

Christian Ehrlicher

@SPlatten said in Correct syntax to register object reference using qRegisterMetaType?:

not for the ones where I've used Qt::DirectConnection

Then it's useless since then Qt::AutoConnection evaluates to Qt::DirectConnection. Specifying a connection type is not needed in most of the cases.

SPlatten

@Christian-Ehrlicher , Well that's the only change I'm implemented and now there is no message, so perhaps this is something that needs looking at?

SGaist

@SPlatten said in Correct syntax to register object reference using qRegisterMetaType?:

@Christian-Ehrlicher , Well that's the only change I'm implemented and now there is no message, so perhaps this is something that needs looking at?

For that a minimal compilable example would be needed.

Christian Ehrlicher

@SPlatten said in Correct syntax to register object reference using qRegisterMetaType?:

so perhaps this is something that needs looking at?

This means that there is a thread context switch somewhere even you tell us it isn't.

kshegunov

@SPlatten said in Correct syntax to register object reference using qRegisterMetaType?:

@Christian-Ehrlicher , Well that's the only change I'm implemented and now there is no message, so perhaps this is something that needs looking at?

Run with QT_FATAL_WARNINGS=1 as an environment variable and extract the stack trace, then you will have leveraged your debugger to show you exactly where you're passing a reference between threads.

SPlatten

@kshegunov said in Correct syntax to register object reference using qRegisterMetaType?:

QT_FATAL_WARNINGS=1

I've opened both .pro files and added that line, then cleaned and rebuilt, the applications have been running for several minutes, nothing to report, no issues.

SGaist

It's an environnement variable, not a define.

You have to set it in the Run tab of the Project panel.

SPlatten

@SGaist , Yes, just googled it and then added as environment variable:

export QT_FATAL_WARNINGS=1

Then restarted, same, not seeing anything additional.

SGaist

Restarted what ?
How are you currently running your application ?