QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread

[jsulm]

@rktech said in QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread:

Is it only possible to remove this warning?

You should fix the issue instead of removing the warning!
Did you check the example @SGaist gave you?

[rktech]

@jsulm As I have written, I have read it, but I don't know, how to fix my code.

[Christian Ehrlicher]

@rktech said in QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread:

but I don't know, how to fix my code.

As shown in the example pass the socket fd instead the object to your thread. You have to override incomingConnection() as shown there.

[rktech]

@Christian-Ehrlicher I have read the example like three-times, but I still don't know how to fix it. Can you help me?

[Christian Ehrlicher]

@rktech said in QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread:

but I still don't know how to fix it.

You have to override incomingConnection() as shown there.

[rktech]

@Christian-Ehrlicher said in QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread:

@rktech said in QSocketNotifier: Socket notifiers cannot be enabled or disabled from another thread:

but I still don't know how to fix it.

You have to override incomingConnection() as shown there.

I have tried, but I don't know how to implement that into my code.

[SGaist]

What exactly have you tried ?

[rktech]

@SGaist To add override to my code, but I don't know where should I place it...

[rktech]

@SGaist How can I send the connection from incomingConnection() to Pool?

[rktech]

@SGaist I have successfully overrided the incomingconnection(), but I don't know, how to pass it to the Pool.

[SGaist]

You'll have to redesign your pool a bit to ensure that your sockets are created in the context of the run method of your QThread subclass.

[rktech]

@SGaist I know, but how?

[SGaist]

You have to transfer the descriptor to your pool and there in your run method create new sockets when descriptors are added.

[rktech]

@SGaist Should I add this part of code to my Pool::add() method? (Of course with editing it)

QTcpSocket tcpSocket;

    if (!tcpSocket.setSocketDescriptor(socketDescriptor)) {
        emit error(tcpSocket.error());
        return;
    }

[rktech]

@SGaist I have (probably) successfully rewritten the Pool add method, but I have another problem. When I add this:

protected:
    void incomingConnection(qintptr socketDescriptor) override;

to myserver.h I get this error:

...\myserver.h:35: Chyba: only virtual member functions can be marked 'override'

(Chyba is Error in my local)
What I am doing wrong?

[mrjj]

Hi
well it is virtual https://doc.qt.io/qt-5/qtcpserver.html#incomingConnection
so does Pool inherit QTcpServer ?
The error you get says "Hey, i dont see that funtion in base class, so you cant use override"

[rktech]

@mrjj No, the server is build under the myserver class

[rktech]

This post is deleted!

[rktech]

@mrjj the header of server look like:

#ifndef MYSERVER_H
#define MYSERVER_H

#include <QObject>
#include <QDebug>
#include <QTcpServer>
#include <QTcpSocket>
#include <QString>
#include <QFile>
#include <QStandardPaths>
#include <QThread>
#include <QElapsedTimer>
#include <pool.h>
#include <QDateTime>
class MyServer : public QObject
{
    Q_OBJECT
public:
    explicit MyServer(QObject *parent = nullptr);

signals:

public slots:
    void newConnection();
    void onReadyRead();

private:
    QTcpServer *server;
    QList<QTcpSocket*>  _sockets;
    QString a;
    QString com;
    QTcpSocket *socket;
    QList<QTcpSocket*> sl;
/*protected:
    void incomingConnection(qintptr socketDescriptor) override;*/
};

#endif // MYSERVER_H

[Christian Ehrlicher]

Sorry but please learn C++ first. If you want to override a function from a class you should inherit from this class. So inherit from QTcpServer, override the function and do whatever you want to. This is basic c++ stuff...