Cannot output a value using QSerialPort

SGaist

Hi,

You signal specification is still wrong in the connect statement.

In any case, as already requested several times: please post the current code you are using.

jsulm

@jude-bato Why do you post again your old connect() call (which is wrong because the signal is missing brackets - readyRead())?
Please post the code where you call connect() with new syntax (without SIGNAL/SLOT) and not just the connect() call itself but also the surrounding code...

jude.bato

QObject::connect(arduino, &QSerialPort::readyRead, this, &Dialog::readSerial); This is the code line that I have integrated in my current project, I'm just not sure how to convert it to the new syntax. I was using the old code because in the original question I wanted to specify where I was talking about. I know it was wrong and I changed it already. The problem I'm having is with the new syntax.

jsulm

@jude-bato And with that code line you get "no member named 'connect' in 'QDebug'"?

Pablo J. Rogina

@jude-bato said in Cannot output a value using QSerialPort:

This is the code line

If you're looking for some help in the forum please make others' life easier.
Why is so difficult to show some code snippet of yours? not just ONE line.
Come on, some context helps understand what might be going on with your issue.

jude.bato

This is the code snippet, its in my dialog.cpp file

if(arduino_is_available)
    {
        qDebug()<<"Found the port \n";
        arduino->setPortName(arduino_uno_port_name);
        arduino->open(QSerialPort::ReadOnly);
        arduino->setBaudRate(QSerialPort::Baud9600);
        arduino->setDataBits(QSerialPort::Data8);
        arduino->setFlowControl(QSerialPort::NoFlowControl);
        arduino->setParity(QSerialPort::NoParity);
        arduino->setStopBits(QSerialPort::OneStop);
        connect(*arduino, Dialog::readSerial(updateVoltage()),this,readSerial()); //too few arguments to function call, expected 1, have 0
    } else {
        qDebug()<<"Could not find the correct port \n";
        QMessageBox::information(this,"Serial Port Error", "Could not open the serial port");
    }
}

and the read serial code I have:

void Dialog::readSerial()
{
    QStringList buffer_split = serialBuffer.split(",");
    if(buffer_split.length() < 3)
    {
        serialData = arduino->readAll();
        serialBuffer = serialBuffer + QString::fromStdString(serialData.toStdString());
        serialData.clear();
    } else {
        serialBuffer = "";
        qDebug() << buffer_split << "\n";
        parsed_data = buffer_split[1];
        voltage_value = (parsed_data.toDouble()) - 0.1;
        qDebug() << "Voltage: " << voltage_value << "\n";
        parsed_data = QString::number(voltage_value,'g',4);
        Dialog::updateVoltage(parsed_data);
    }
}

SGaist

Hi,

One thing that is missing: you don't check that the open call is successful. You should add that.

Pablo J. Rogina

@jude-bato said in Cannot output a value using QSerialPort:

connect(*arduino, Dialog::readSerial(updateVoltage()),this,readSerial());

Again, please read the documentation regarding signal and slots. You may want to try this article as well.

Tip: a typical connect sentence has 4 elements, try to identify such elements within your code...

Dialog::updateVoltage(parsed_data);

Do you know why you're calling an static method here?

jude.bato

@SGaist I believe I do

bool arduino_is_available = false;
    QString arduino_uno_port_name;
    foreach(const QSerialPortInfo &serialPortInfo, QSerialPortInfo::availablePorts()){
        if(serialPortInfo.hasProductIdentifier() && serialPortInfo.hasVendorIdentifier()){
            if((serialPortInfo.productIdentifier() == arduino_uno_product_id) && (serialPortInfo.vendorIdentifier() == arduino_uno_vendor_id)){
                arduino_is_available = true;
                arduino_uno_port_name = serialPortInfo.portName();
            }
        }
    }

    if(arduino_is_available)
    {
        qDebug()<<"Found the port \n";
        arduino->setPortName(arduino_uno_port_name);
        arduino->open(QSerialPort::ReadOnly);
        arduino->setBaudRate(QSerialPort::Baud9600);
        arduino->setDataBits(QSerialPort::Data8);
        arduino->setFlowControl(QSerialPort::NoFlowControl);
        arduino->setParity(QSerialPort::NoParity);
        arduino->setStopBits(QSerialPort::OneStop);
        QObject::connect(arduino, SIGNAL(readyRead), this, SLOT(readSerial())); //I know this is wrong, this is what I'm trying to fix
    } else {
        qDebug()<<"Could not find the correct port \n";
        QMessageBox::information(this,"Serial Port Error", "Could not open the serial port");
    }
}

Christian Ehrlicher

@jude-bato said in Cannot output a value using QSerialPort:

I believe I do

No, you don't check the value of QSerialPoort::open(). And you should set the parameter before opening the device.

jude.bato

@Pablo-J-Rogina I've already tried with the new syntax and I've tried with different elements and I keep getting the expected 1, have 0 output. As for the parsed_data I personally have never used it but I used Vannevar Morgan code as reference and it worked (https://github.com/vannevar-morgan/Qt-Temperature-Sensor/blob/master/DS18B20_Qt/dialog.cpp)

@Christian-Ehrlicher Then I'm not sure how to go about doing so, I thought that mean to check if the port on the Arduino is open. When debugging I tested throughout my code and was open the Serial Port and read an open port on the Arduino, the only issue is I can't read anything from it

SGaist

How did you test that ?

As for the call to open: again, always check that it succeeded. You might be trying to use an already opened device or you don't have the rights to open said device. Therefore, add that check before going further.

jude.bato

@SGaist I have

Dialog::~Dialog()
{
    if(arduino->isOpen())
    {
        arduino->close();
    }
    delete ui;
}

Would this satisfy the QSerialPort::open()?

Also would I need to use connect? I change that line to just readSerial(); but I'm not able to implement void Dialog::updateVoltage(QString sensor_reading) into if(arduino_is_available)

jsulm

@jude-bato said in Cannot output a value using QSerialPort:

Would this satisfy the QSerialPort::open()?

Of course not, it does not have anything to do with open().

if(!arduino->open(QSerialPort::ReadOnly)) {
    qDebug() << "Opening serial port failed";
    qDebug() << arduino->error() << arduino->errorString();
}

jude.bato

@jsulm Thank you for your suggestion, I put in your code and I ran it again. This is what I got: I'm so confused why my program isn't working correctly. I have a feeling that my problem has to do with reading from or something with making a connection with Arduino rather than the Serial Port itself.

Pablo J. Rogina

@jude-bato

First: please don't post screenshots, paste the text itself. It's easier for others to copy/paste/reply to that!

Device is already open

Have you seen this message?
What do you think about that? My bet is that you also have other program (i.e. Arduino IDE) connected to your device...

jsulm

@jude-bato Exactly what @SGaist was suggesting

jude.bato

@Pablo-J-Rogina I have an Arduino Uno connected via USB, that's my original point in making the forum post is because I am unable to capture a voltage in Qt from it. I have it stated in my original post.

Pablo J. Rogina

@jude-bato said in Cannot output a value using QSerialPort:

I have an Arduino Uno connected via USB,

Yes, I assumed that. What you should know, if not aware yet, is that you cannot have two applications (i.e. your Qt app and the Arduino IDE) using the same port simultaneously

jude.bato

@Pablo-J-Rogina So how can I just read voltage from my Arduino Uno in Qt