Application with plugin crashes after calling macdeployqt.

dokif

@SGaist Another thing i've just noticed. The app only crash if i open the "*.app", but if i navigate to the Contents/MacOS/myexecutable file from temrinal and run it from there, it works.

SGaist

You should get a report automatically as macOS generates it for you on application crash.

If you don't get one it's maybe because your app ended properly although not the way you wanted.

dokif

@SGaist Thanks again for the quick answer! But where should that report be? I don't think the app is exiting correctly, as running it before macdeployqt works fine. Also, i did not include another way to end de application myself, but pressing the close button. So if its ending without pressing that button, something is wrong, right? The application only crash when i run the *.app AFTER macdeployqt and loading a custom plugin. If i run it without macdeployqt, it works with or without plugin... if i run it without plugin, it also works. Only the combination of having used macdeployqt and loading the plugin makes the app crash.

dokif

Also, both windows and linux are working flawlessly.

SGaist

What plugins are you using ?

As for the crash report, you should get a dialog automatically after the crash.

What happens if you call "open your_app.app" on the command line ?

dokif

@SGaist It's a plugin i wrote myself for my application.
I'm actually calling open <path_to_app> and nothing is printed out to the console.
If i load the plugin, the application just closes.

SGaist

Start your application with the QT_DEBUG_PLUGINS environment variable set to 1. It will show you what is happening with your plugin.

dokif

@SGaist Hey, nothing appears aswell :(

SGaist

Ça you show the code dealing with your plugin ?

dokif

@SGaist Hi! yes, i can show all my code. In fact, both plugin and application are open source:

https://github.com/azagaya/laigter
https://github.com/azagaya/LaigterNormalBrushPlugin

The revelant part of the app that loads the plugin, is on mainwindow.cpp:

void MainWindow::on_actionLoadPlugins_triggered()
{
  QString appData =
    QStandardPaths::writableLocation(QStandardPaths::AppDataLocation);
  QDir dir(appData);
  dir.cd("plugins");
  const auto entryList = dir.entryList(QDir::Files);
  foreach (QDockWidget *dock, plugin_docks_list){
    plugin_docks_list.removeOne(dock);
    delete dock;
  }
  foreach (QAction *action, ui->pluginToolBar->actions()){
    if (action->text() == tr("Load Plugins") || (action->text() == tr("Install Plugin"))) continue;
    ui->pluginToolBar->removeAction(action);
  }
  for (const QString &fileName : entryList) {
    QPluginLoader pl(dir.absoluteFilePath(fileName));
    BrushInterface *b = qobject_cast<BrushInterface *>( pl.instance());
    qDebug() << pl.errorString();
    if(b != nullptr){
      ui->openGLPreviewWidget->currentBrush = b;
      b->setProcessor(&processor);
      QAction *action = new QAction(b->getIcon(),b->getName());
      action->setCheckable(true);
      QDockWidget *pluginDock = new QDockWidget(b->getName(),this);
      QWidget *pluginGui = b->loadGUI();

      addDockWidget(Qt::LeftDockWidgetArea,pluginDock);
      pluginDock->setFloating(true);
      pluginDock->setFeatures(QDockWidget::DockWidgetMovable | QDockWidget::DockWidgetFloatable);

      pluginDock->setWidget(pluginGui);

      pluginDock->setVisible(false);
      connect(action,SIGNAL(toggled(bool)),pluginDock,SLOT(setVisible(bool)));

      ui->pluginToolBar->addAction(action);

      plugin_docks_list.append(pluginDock);

    }
  }
}

This is the first time i make plugins for my apps. I save then in the appdata location, and then load from there.

dokif

Also, this is the interface:

#ifndef BRUSHINTERFACE_H
#define BRUSHINTERFACE_H

#include <QtPlugin>

QT_BEGIN_NAMESPACE
class QImage;
class QPainter;
class QWidget;
class QPainterPath;
class QPoint;
class QRect;
class ImageProcessor;
QT_END_NAMESPACE

class BrushInterface
{
  public:
  virtual void mousePress(const QPoint &pos) = 0;
  virtual void mouseMove(const QPoint &oldPos, const QPoint &newPos) = 0;
  virtual void mouseRelease(const QPoint &pos) = 0;
  virtual bool get_selected() = 0;
  virtual void set_selected(bool s) = 0;
  virtual QWidget *loadGUI(QWidget *parent = nullptr) = 0;
  virtual void setProcessor(ImageProcessor **processor) = 0;
  virtual QIcon getIcon() = 0;
  virtual QString getName() = 0;
  virtual QImage getBrushSprite() = 0;
  signals:
      void selected(BrushInterface *brush);
};

#define BrushInterface_iid "org.azagaya.laigter.plugins.BrushInterface/1.0"

Q_DECLARE_INTERFACE(BrushInterface, BrushInterface_iid)

#endif // BRUSHINTERFACE_H

SGaist

Your plugins path is a bit surprising. On macOS they should be in your app bundle but your are looking for them in your system. Is that really the case ?

Did you already check the Plug and Paint example ?

dokif

@SGaist Yes, i checked it while i was working on the plugin in linux. The thing is that i want users to be able to "install/remove" plugins, and that when they download a new release, that plugins remain. So i tried using the appdata location in the system, and worked both in linux and windows. I don't want to include every single plugin in the bundle, because may be some plugins are only meant for contributors/patreons/etc. Is this possible with mac?
Also, a friend of mine tried the app generated without using macdeployqt, and with all dependencies installed, and both the app and the plugin worked fine. The problem is that others users cannot use the app if i don't deploy with macdeployqt.

dokif

So, in mac i should try using like in plug & paint, and that the user reinstalls the plugins if they download a newer app, right? I could try that.

SGaist

Check your plugin with otool -L you'll see that the libraries it depends on are searched into your application bundle. Hence they will fail to load if you moved them around.

dokif

@SGaist thanks! otool -l libNormalBrush.dylib gives me this output:
https://pastebin.com/9uk06Dqi
It doesn't seem to look for them in the application bundle, but on the system, right? So that's what making it crash? it doesn't find the libs?

dokif

@SGaist Well, i finally managed to get an error, running the executable inside the .app directly from console:


"/Users/mac/Library/Application Support/laigter"
objc[95815]: Class CaptureDelegate is implemented in both /Users/mac/laigter-1.8/laigter.app/Contents/Frameworks/libopencv_videoio.4.1.dylib (0x1046d1ae0) and /usr/local/opt/opencv/lib/libopencv_videoio.4.1.dylib (0x12745aae0). One of the two will be used. Which one is undefined.
objc[95815]: Class CVWindow is implemented in both /Users/mac/laigter-1.8/laigter.app/Contents/Frameworks/libopencv_highgui.4.1.dylib (0x104699330) and /usr/local/opt/opencv/lib/libopencv_highgui.4.1.dylib (0x127420330). One of the two will be used. Which one is undefined.
objc[95815]: Class CVView is implemented in both /Users/mac/laigter-1.8/laigter.app/Contents/Frameworks/libopencv_highgui.4.1.dylib (0x104699358) and /usr/local/opt/opencv/lib/libopencv_highgui.4.1.dylib (0x127420358). One of the two will be used. Which one is undefined.
objc[95815]: Class CVSlider is implemented in both /Users/mac/laigter-1.8/laigter.app/Contents/Frameworks/libopencv_highgui.4.1.dylib (0x104699380) and /usr/local/opt/opencv/lib/libopencv_highgui.4.1.dylib (0x127420380). One of the two will be used. Which one is undefined.
ERROR: something wrong with flag 'flagfile' in file '/tmp/gflags-20190105-77846-1pdnfpc/gflags-2.2.2/src/gflags.cc'.  One possibility: file '/tmp/gflags-20190105-77846-1pdnfpc/gflags-2.2.2/src/gflags.cc' is being linked both statically and dynamically into this executable.

That error arrises just when i load the plugin into the application. So i what i understand here is that i must change where the plugin is looking for libs? Can i change that?

SGaist

Yes, you can change that use install_name_tool for that. That's what macdeployqt uses to do its job.

dokif

@SGaist Thanks! i'll try it tonight. So just so just to be sure, i must change where the plugin libNormalBrush.dylib looks for the libs, and change them to rpath?
something like:

install_name_tool -change each_one_of_the_libs.dylib @rpath/../lib/each_of_the_libs.dylib libNormalBrush.dylib

Right?

SGaist

Check the Qt plugins to see where they are looking for. You also have to check where your OpenCV libraries are stored in the bundle.