Is there a #define for checking if the compiler is Qt?

JonB

@kitfox
If you think about it, you will realize that you will have to define or not define your QT_IS_AVAILABLE from outside of Qt. So it would be flag you choose to define or not in, say, a Makefile, a -D-type argument you do or do not pass to the compiler line.

Also, in your case you have already unconditionally included

#include <QtCore/qglobal.h>

so Qt will have to "be available" to get past that....

kitfox

So there's no defines automatically set when using Qt to indicate that? I have to put a define in my .pro file?

JonB

@kitfox
Sorry, I still don't think you're getting it. By the time you have a .pro file to put anything in, you're already compiling for Qt, aren't you?

kitfox

I'm trying to format the code so that it can build either by clicking build within Qt Creator or by whatever compiler the original author was using.

SGaist

@JonB said in Is there a #define for checking if the compiler is Qt?:

@kitfox
Sorry, I still don't think you're getting it. By the time you have a .pro file to put anything in, you're already compiling for Qt, aren't you?

No, you can build a Qt-less project.

@kitfox yes that's a define you have to enable yourself like shown in the Shared Library chapter of Qt's documentation.

JonB

@SGaist
Why would you start with a .pro file if you don't have Qt anywhere? What are you going to process it with?

SGaist

@JonB do you mean if you don't use Qt in your project ? Maybe because you are used to use qmake to manage your projects and are satisfied with it.

JonB

@SGaist
I envisage the OP is asking: he gives all his code plus Makefiles to someone else, who may not possess Qt at all, no qmake etc. And they can compile the code some other way with nothing Qt anywhere.

Then at one point he said

either by clicking build within Qt Creator or by whatever compiler the original author was using.

So maybe he'd like to know if he's compiling from Qt Creator or not.

The point I'm trying to get across is he will need to define some symbol somewhere if he wants to compile for/with Qt or some symbol somewhere if he wants to compile otherwise. QT_IS_AVAILABLE has got to be defined somewhere in those cases where it's wanted, else it'll never any effect. Different makefiles, an environment variable, something so the Qt or non-Qt compilation can be performed.

ben.cottrell

@kitfox What kind of modifications are you doing?

kitfox

That's right. I'm having trouble thinking of a way to rewrite ffmpeg-cpp_global.h so that it would work either inside of outside of a Qt environment. Currently FFMPEGCPP_LIBRARY is defined in the .pro file and acts as a switch - if it's included, then FFMPEGCPP_EXPORT transforms into instructions to export the definition to a dll. However, if it's not included (which it presumably would not be to anyone who wanted to use the library) it turns into a declaration to import the definition - instructions which depend on the Qt API to work. So what am I supposed to use if someone it trying to compile this with another compiler? I'd like a way to essentially nullify everything in this header file if I can tell that the person trying to compile it is not using Qt.

As far as I can tell, I'm going to have to have everyone using Qt who wants to use this library add some define in their .pro file so that the imports are generated. Ie, something like:


#ifdef IM_USING_QT

#include <QtCore/qglobal.h>

#if defined(FFMPEGCPP_LIBRARY)
#  define FFMPEGCPP_EXPORT Q_DECL_EXPORT
#else
#  define FFMPEGCPP_EXPORT Q_DECL_IMPORT
#endif

#else 

#define FFMPEGCPP_EXPORT

#endif

kitfox

Just trying to get the library to build under Qt. Then would like to write a few simple apps to test it to make sure it's working.

kitfox

@kitfox It would be nice if there were some equivalent of IM_USING_QT automatically defined so that I would not have to have all QT users explicitly specify it.

Chris Kawa

If you're using a decent compiler you can use __has_include to check if Qt headers are available and define some macro constant if they are.
That doesn't solve any linker and toolchain (moc etc.) issues, but that's how you can detect if Qt source is available in your project.

JonB

@kitfox
If your definition of "I'm using Qt" is you have the Qt include files on your box, @Chris-Kawa's suggestion looks great. Is that what you wanted? Or did you say you wanted to know whether the user is sitting inside Qt Creator? Or does the user choose whether he wants to compile for Qt or not (e.g. like you will want to while testing each route of this code)? What exactly is the deciding factor?

ben.cottrell

@kitfox why not use CMake so that you can specifically define whether or not to use Qt, and then decide which implementation source file to add to compilation?

kitfox

If the user wants to compile with the Qt API using my modifications, I want the DLL import/export tags to resolve to the definitions defined in QtCore/qglobal.h. If they wish to use the original environment they were developed in, or some other non Qt environment, I would like the FFMPEGCPP_EXPORT tag to resolve to the empty string and the #include <QtCore/qglobal.h> left out so that they can compile with their libraries. Basically as this is an open source library, I'm trying to make minimal changes and leave it in a state such that it can still compile in its original environment, while also making it capable of compiling using the Qt environment.

kitfox

I'm not familiar with cmake. I suppose I should learn it, but I haven't had the time.

hskoglund

Try

#if defined(QT_VERSION)

kitfox

This post is deleted!

JonB

@hskoglund
Where does QT_VERSION get defined, please? Isn't it via #include <QtGlobal>, so it tells you whether or not you have already included that file? How do you decide whether to include that or not? That's the bit I don't get....

@kitfox
OK, to be fair/clear, surrounding some Qt-only code in #if defined(QT_VERSION) looks like a good model for most of your code. It's a clean symbol. So that's good.

You still have to "get going" somewhere, to decide whether to define that or include QtGlobal.h or not in the first place.