Focus ring around tree/table views?

[J.Hilk]

@davecotter you're welcome 😉

strange I can confirm that, but the pixel size used to make a difference 🤔

[davecotter]

@mpergand said in Focus ring around tree/table views?:

treeView->setAttribute(Qt::WA_MacShowFocusRect);

note i tried this on the mac just to SEE it, and got exactly nothing. is there no way to accomplish this?

again i ask: how does the text edit control (on mac) do it? that looks great!

[Pl45m4]

@davecotter

Qt::WA_MacShowFocusRect will create a QFocusFrame around the specific widget. If setting that flag doesnt work for you, you could try to build a QFocusFrame directly.

https://doc.qt.io/archives/qt-4.8/qfocusframe.html

[mpergand]

@davecotter said in Focus ring around tree/table views?:

@mpergand said in Focus ring around tree/table views?:

treeView->setAttribute(Qt::WA_MacShowFocusRect);

note i tried this on the mac just to SEE it, and got exactly nothing. is there no way to accomplish this?

It works for me on MacOS 10.9, Qt 5.6
QFocusFrame doesn't work on Mac on the config above,
but works well on Linux (Ubuntu mate 18.04)

[davecotter]

i have tried to use Qt::WA_MacShowFocusRect on mac and see nothing. can you show a screen shot of what you see?

[mpergand]

@davecotter

edit=new QTextEdit;
edit->setAttribute(Qt::WA_MacShowFocusRect);
groupLayout->addWidget(edit);

[davecotter]

sorry, i wasn't talking about a text edit widget. that already works without my having to do anything.

i'm talking about putting a focus ring around a QTreeView and a QTableView.

and in that case it only shows the ring when the view has focus right? i don't have to manage that part myself, right?

[mpergand]

@davecotter
It's work with QTable/TreeView as well !

   QTreeView* edit=new QTreeView;
   edit->setAttribute(Qt::WA_MacShowFocusRect);
   groupLayout->addWidget(edit);
   edit=new QTreeView;
   edit->setAttribute(Qt::WA_MacShowFocusRect);
   groupLayout->addWidget(edit);

[EDIT]
For me, QTable and QTreeView have the focus ring by default (without setAttribute(Qt::WA_MacShowFocusRect);)
but for QTextEdit Qt::WA_MacShowFocusRect is needed.

[davecotter]

huh, for me the text edit gets a ring automatically, and no matter what i do i can't get the tree or table view to get it.

note i'm setting it all up in Qt Designer, then programmatically adding the ring around tree/table views, to no avail.

[mpergand]

@davecotter said in Focus ring around tree/table views?:

note i'm setting it all up in Qt Designer, then programmatically adding the ring around tree/table views, to no avail.

Check if the focus policy is not set to NoFocus.
On the code above, If I add :

edit->setFocusPolicy(Qt::NoFocus);

Obviously the focus ring doesn't appear anymore.

[davecotter]

Yes the views default to having "strongFocus". I have recreated the minimal project, which also does not show focus rings even with all the code correct as specified above.

If anyone has a couple free minutes, please download and run this project, and tell me what's wrong?

[mpergand]

Your project works as expected for me.
But I can't test above Qt 5.8 and MacOs 10.9.
Maybe a bug in more recent Qt versions ?

[davecotter]

well i am on macOS 10.14 and Qt 5.13.0

[davecotter]

@mpergand said in Focus ring around tree/table views?:

WA_MacShowFocusRect

can anyone try on latest Qt?

[davecotter]

@mpergand or anyone, can you reproduce the problem? that the focus ring is 1px no matter what? if you see CORRECT results (nice ring like around the search box) can you screen shot that and tell me what version of Qt you're using?

i still can not for the life of me get this ring to look good

[davecotter]

if i embed the views inside a QFrame, with 3px borders, then draw the focus on the QFrames, that looks good. i can tab between all 3 items and the borders look good (if the wrong color).

but that leaves the wrong QObject with the focus. i need the tree/table views to have actual focus.

soi try to do this:

treeFrame->setFocusProxy(treeView);
tableFrame->setFocusProxy(tableView);

then the edit text and tree frame look good, but the table view is back to looking all wrong again (1 pixel border)

good:

good:

bad:

why 1 pixel? the code is correct.

I've a new minimal project if some kind soul (who likes karaoke?) could take a look?
http://kjams.com/downloads/qfocustest.zip

thanks

-dave

[mpergand]

@davecotter said in Focus ring around tree/table views?:

@mpergand or anyone, can you reproduce the problem? that the focus ring is 1px no matter what? if you see CORRECT results (nice ring like around the search box) can you screen shot that and tell me what version of Qt you're using?

i still can not for the life of me get this ring to look good

I'm currently proceeding to a major update of my developement system.
I hope looking at your issue in a few days.

[JonB]

@davecotter
Please take this lightheartedly, but she's spelt Eleanor Rigby :)
Probably not the cause of your issue, but it does imply you are typing these in by hand!?

[davecotter]

does it seem strange that every API for "focus rings" and even one i hacked together, doesn't work?

• setting a frame using styles DOES NOT WORK
• using the explicit API QFocusFrame DOES NOT WORK
• using the mac-only "Qt::WA_MacShowFocusRect" attribute DOES NOT WORK

or: i have not been able to understand the doc well enough to cause any of them to work

[davecotter]

I've updated the example project so you can test six different implementations of "focus ring", none of which are 100% successful.

The only one that comes close is kTest_PARENT_STYLE, and only on mac. On windows i can't for the LIFE of me make ANY focus ring bigger than 1 pixel, which is just too small. I really need 3 pixels in order to keep the UI appearing the same as the previous (10 year old, 32bit) app.

-dave