Audio duration for file manager

[jsulm]

@Nemooo said in Audio duration for file manager:

filemodel->setData(filemodel->index(0, 2), QString().setNum(dura));

You you should do this inside lambda connected to durationChanged, else dura will be 0.0 when you do:

filemodel->setData(filemodel->index(0, 2), QString().setNum(dura));

dura is changed when the slot is called, but you already use it just after calling connect.

You have a memory leak (you don't delete QMediaPlayer instances you're creating in a loop!).

[Nemooo]

@jsulm said in Audio duration for file manager:

@Nemooo said in Audio duration for file manager:

filemodel->setData(filemodel->index(0, 2), QString().setNum(dura));

You you should do this inside lambda connected to durationChanged, else dura will be 0.0 when you do:

filemodel->setData(filemodel->index(0, 2), QString().setNum(dura));

dura is changed when the slot is called, but you already use it just after calling connect.

You have a memory leak (you don't delete QMediaPlayer instances you're creating in a loop!).

Thank you!
I did this file inside lambda

filemodel->setData(filemodel->index(0, 2), QString().setNum(dura));

and still it doesn't work. I deleted QMediaPlayer, just erased this line by accident.

[jsulm]

@Nemooo said in Audio duration for file manager:

and still it doesn't work

Probably because when the slot is called you already added another line on top...

[Nemooo]

@jsulm said in Audio duration for file manager:

@Nemooo said in Audio duration for file manager:

and still it doesn't work

Probably because when the slot is called you already added another line on top...

I tried to change the order. First I called the slot, then I added lines. Still doesn't work.

[jsulm]

@Nemooo said in Audio duration for file manager:

First I called the slot

You don't call the slot, the slot is called when the signal is emitted...

[Nemooo]

@jsulm
Ok! Yes, emitted signal - > slot called - > still doesn't work

[jsulm]

@Nemooo Just to clarify: you don't know when exactly the signal will be emitted. This is done by QMediaPlayer, not by you. So, you do not know in which order the signals will be emitted. It can work like you're doing. You should pass an additional parameter to the slot to tell it which line/index to update.

[Nemooo]

@jsulm said in Audio duration for file manager:

@Nemooo Just to clarify: you don't know when exactly the signal will be emitted. This is done by QMediaPlayer, not by you. So, you do not know in which order the signals will be emitted. It can work like you're doing. You should pass an additional parameter to the slot to tell it which line/index to update.

Thank you! Could you please show me the example how to do it. I am new in Qt so I don't know how to do it.
Thank you!

[jsulm]

@Nemooo Something like (not really Qt specific):

auto index = filemodel->index(0, 2);
connect(player, &QMediaPlayer::durationChanged, this, [this, index](qint64 dur) {
        dura = static_cast<double>(dur)/60000.0;
        qDebug() << "duration = " << dura;
        filemodel->setData(index, QString().setNum(dura));
    });

[Nemooo]

@jsulm said in Audio duration for file manager:

@Nemooo Something like (not really Qt specific):

auto index = filemodel->index(0, 2);
connect(player, &QMediaPlayer::durationChanged, this, [this, index](qint64 dur) {
        dura = static_cast<double>(dur)/60000.0;
        qDebug() << "duration = " << dura;
        filemodel->setData(index, QString().setNum(dura));
    });

Now I understand what you mean but it still doesn't work

[aha_1980]

@Nemooo said in Audio duration for file manager:

Now I understand what you mean but it still doesn't work

Then please debug the code and find out where the problem is.

[jsulm]

@Nemooo I think the problem is that index changes as you're inserting new rows. You need to find a way to make sure you're using the correct index. Or you first fill in all rows into your model and then use QMediaPlayer.

[Nemooo]

@jsulm said in Audio duration for file manager:

@Nemooo I think the problem is that index changes as you're inserting new rows. You need to find a way to make sure you're using the correct index. Or you first fill in all rows into your model and then use QMediaPlayer.

Yes, I feel, that mistake is somewhere in wrong index but I cannot catch how.
I did in a different ways. No chance.

May be you know how can I get information about duration in mp3 file in different ways?

[jsulm]

@Nemooo "Or you first fill in all rows into your model and then use QMediaPlayer." - what about this suggestion?

[Nemooo]

@jsulm said in Audio duration for file manager:

@Nemooo "Or you first fill in all rows into your model and then use QMediaPlayer." - what about this suggestion?

Tried to do this way

void MainWindow::CreateTable(const QString & p) {
filemodel->removeRows( 0, filemodel->rowCount() );


filemodelcurrentdir = QDir(p).path();
files = QDir(p).entryInfoList(QDir::Dirs | QDir::Files | QDir::NoDotAndDotDot);
foreach(const QFileInfo &fi, files) {
    QString name = QString("%0").arg(fi.fileName());



    filemodel->insertRow(0);
    if (fi.isDir()) {
        filemodel->setData(filemodel->index(0, 0), name);
        filemodel->setData(filemodel->index(0, 0), dirIcon, Qt::DecorationRole);
    } else {
        filemodel->setData(filemodel->index(0, 0), name);
        filemodel->setData(filemodel->index(0, 0), fileIcon, Qt::DecorationRole);

    filemodel->setData(filemodel->index(0, 1), size_human(fi.size()));
 }
 }


    foreach(const QFileInfo &fi, files) {
    QString name = QString("%0").arg(fi.fileName());

    if (!fi.isDir()) {
   QMediaPlayer* player = new QMediaPlayer();
    player->setMedia(QUrl::fromLocalFile(filemodelcurrentdir + "/" + name));

           auto index = filemodel->index(0, 2);
    connect(player, &QMediaPlayer::durationChanged, this, [this, index](qint64 dur) {

            filemodel->setData(index, QString().setNum(static_cast<double>(dur)/60000.0));
        });

    delete player;}
}


filemodel->setHeaderData(0,Qt::Horizontal,QObject::tr("Name" ));
filemodel->setHeaderData(1,Qt::Horizontal,QObject::tr("Size" ));
filemodel->setHeaderData(2,Qt::Horizontal,QObject::tr("Duration" ));

pTreeView2->setSortingEnabled(true);
pTreeView2->setColumnWidth(0, 300);
pTreeView2->setColumnWidth(1, 100);
pTreeView2->setColumnWidth(2, 100);
}

The result is the same - doesn't fill the last column

[jsulm]

@Nemooo said in Audio duration for file manager:

The result is the same - doesn't fill the last column

Yes, because you need to take the correct index now instead of 0.

[Nemooo]

@jsulm said in Audio duration for file manager:

@Nemooo said in Audio duration for file manager:

The result is the same - doesn't fill the last column

Yes, because you need to take the correct index now instead of 0.

May be this way?

  void MainWindow::CreateTable(const QString & p) {
  filemodel->removeRows( 0, filemodel->rowCount() );
filemodelcurrentdir = QDir(p).path();
files = QDir(p).entryInfoList(QDir::Dirs | QDir::Files | QDir::NoDotAndDotDot);
int in = 0;
foreach(const QFileInfo &fi, files) {
    QString name = QString("%0").arg(fi.fileName());
    filemodel->insertRow(in);
    if (fi.isDir()) {
        filemodel->setData(filemodel->index(in, 0), name);
        filemodel->setData(filemodel->index(in, 0), dirIcon, Qt::DecorationRole);
    } else {
        filemodel->setData(filemodel->index(in, 0), name);
        filemodel->setData(filemodel->index(in, 0), fileIcon, Qt::DecorationRole);

    filemodel->setData(filemodel->index(in, 1), size_human(fi.size()));
    }
   ++in;
   }

in = 0;
foreach(const QFileInfo &fi, files) {
    QString name = QString("%0").arg(fi.fileName());
    if (!fi.isDir()) {
   QMediaPlayer* player = new QMediaPlayer();
    player->setMedia(QUrl::fromLocalFile(filemodelcurrentdir + "/" + name));


    auto index = filemodel->index(in, 2);
    connect(player, &QMediaPlayer::durationChanged, this, [this, index](qint64 dur) {

            filemodel->setData(index, QString().setNum(static_cast<double>(dur)/60000.0));
        });

    delete player;}
    ++in;
}


filemodel->setHeaderData(0,Qt::Horizontal,QObject::tr("Name" ));
filemodel->setHeaderData(1,Qt::Horizontal,QObject::tr("Size" ));
filemodel->setHeaderData(2,Qt::Horizontal,QObject::tr("Duration" ));

pTreeView2->setSortingEnabled(true);
pTreeView2->setColumnWidth(0, 300);
pTreeView2->setColumnWidth(1, 100);
pTreeView2->setColumnWidth(2, 100);
 }