How to store a unsigned char array to float value?

[VRonin]

From the output in the screenshot it looks like you are sending the string representation of the numbers rather than the actual numbers. You just need to detect those "unreadable control-codes" that you are just replacing with a . as they will probably tell you when a number ends and another begins. you can then use QString::fromLatin1 to create a string from the input received and then you can use toDouble to convert it to a floating point type

[KroMignon]

@Geeva I support the two dots after "13.60" are cariage return (ASCII 13) and line fied (ASCII 10)

I would do this like this

QSerialPort port;

port.setBaudRate(9600);
port.setParity(QSerialPort::NoParity);
port.setDataBits(QSerialPort::Data8);
port.setStopBits(QSerialPort::OneStop);

QString buffer;

port.open(QIODevice::ReadOnly);
while(port.isOpen())
{
    // to let QSerialPort handle events
    QThread::currentThread()->eventDispatcher()->processEvents(QEventLoop::AllEvents);
    QByteArray bArray= port.readAll();
    foreach(const auto& c, bArray)
    {
        if(c < 32)  // unreadable is "end of string"
        {
             if(!buffer.isEmpty())
             {
                  bool ok;
                  auto value = buffer.toDouble(&ok);
                  if(ok)
                  {
                       qDebug() << "Received value": << value;
                  }
                  else
                  {
                        qDebug() << "Failed to parse": << buffer;
                  }
            }
            buffer.clear();
        }
        else
        {
            buffer.append(c);
        }
    }
}

Hope this will help you.

[aha_1980]

@KroMignon It would have been a better and more reuseable example with the readyRead()signal.

Also, the data comes in in chucks and parsing it like this is likely to fail. Example:
12345.6 can come in as 123 and 45.6, both valid floating point numbers.

So you need to handle the special chars between them, like @VRonin said. Most likely these are line endings and perfectly suited to detect begin and end of a number.

Regards

[Geeva]

@KroMignon @aha_1980 I have tried to use qserial for receiving data, but I didn't get the proper response. I don't know where is the problem exactly. I hope you can help me to get a solution.

mainwindow.h

#include <QMainWindow>

namespace Ui {
class MainWindow;
}

class MainWindow : public QMainWindow
{
    Q_OBJECT

public:
    explicit MainWindow(QWidget *parent = 0);
    ~MainWindow();

private slots:

    void serialreceived();

private:
    Ui::MainWindow *ui;

mainwindow.cpp

#include "mainwindow.h"
#include "ui_mainwindow.h"
#include <QSerialPort>
#include <QDebug>

QSerialPort * serial;

MainWindow::MainWindow(QWidget *parent) :
    QMainWindow(parent),
    ui(new Ui::MainWindow)
{
    ui->setupUi(this);

    serial = new QSerialPort(this);

    serial -> setPortName("/dev/ttyACM1");
    serial -> setBaudRate(QSerialPort::Baud115200);
    serial -> setDataBits(QSerialPort::Data8);
    serial -> setParity(QSerialPort::NoParity);
    serial -> setStopBits(QSerialPort::OneStop);
    serial -> setFlowControl(QSerialPort::NoFlowControl);
    serial -> open(QIODevice::ReadWrite);

    connect(serial, SIGNAL(readyRead()),this,SLOT(serialreceived()));
}

MainWindow::~MainWindow()
{
    delete ui;
    serial ->close();
}

void MainWindow::serialreceived()
{
    if(serial -> canReadLine())
    {
        QString str = serial -> readAll();

        int num = str.toInt();
        ui -> progressBar -> setValue(num);
   }
}

I don't know, what's wrong with this code. Output getting only 0 If I get proper output with QSerial, it's not necessary to go with any other libraries like RS232 etc.

[aha_1980]

@Geeva

Your code looks good so far, just make QSerialPort * serial; a proper class member.

Also, check for errors on opening the port: serial->open(QIODevice::ReadWrite);

Then, insert some qDebug() in serialreceived() to see if the slot is called at all and if the canReadLine() works.

Hint: You should use readLine() instead readAll() like this:

void MainWindow::serialreceived()
{
    while (serial->canReadLine()) {
        QString str = serial -> readLine().trimmed();
        qDebug() << str;

        int num = str.toInt();
        ui -> progressBar -> setValue(num);
   }
}

[J.Hilk]

@Geeva to add to what @aha_1980 said,

you should use QByteArray to read your data. If there's any char in the response, that is not String conform, the resulting QString will be prematurely terminated.

    QByteArray data = serial -> readLine();
    qDebug() < data.toHex(' '); // prints the hex representation of your char array
    QString str(data);
    qDebug() << str;
    ....

[aha_1980]

@J.Hilk Good catch. I think to convert it to an int, not even a QString conversion is needed, as QByteArray has toInt() too.

[fcarney]

If you are going to convert to values that may not have the same endianess you might be further ahead in using QDataStream to take as input a QByteArray. It allows you to easily select the endian format for the bytes and use stream semantics to read out your data as floats, ints, etc.

Edit: Unless your data is actually text...

[aha_1980]

@fcarney

Edit: Unless your data is actually text...

Which seems the case here ;)

[Geeva]

@aha_1980 I got the data, but I am facing a problem. The below code working fine, I got the data from the Arduino.

void MainWindow::serialreceived()
{
    while (serial->canReadLine()) {
        QString str = serial -> readLine().trimmed();
        qDebug() << str;

        double num = str.todouble();

Output:

0.00
0.01
0.02
0.03
etc..

I have tried to store the data in variable Thread::store = num; When I was try to read the data from other thread I am getting improper data/slow data/inbetween 0. Can you help me to fix this issue?

[aha_1980]

@Geeva

• Do you really need to have multiple threads? This is complicating things and needs a lot of experience to be handled correctly.
• No matter if you use threads or not, the easiest way is to define a signal void numberReceived(double number) and connect it to the receiver. Then emit this signal from your serialreceived function.

Regards