ScrollBar isn't placing at the current position

SGaist

I understood the idea. What I'm asking is what are you doing code wise that makes your scrollbar move when one user changes its status.

Dimple

void ContactsPage::updateContactList()
{
ui->list_contacts->clear();

QList<Contact*> totalList = DataManager::getInstance()->getContacts();
for(int i = 0; i < totalList.size(); i++)
{
    Contact* pContact = totalList[i];
    switch(m_activeTab)
    {
        case TCTT_ALL:
            if(pContact->getType() == Contact::TYPE_ACCOUNT)
            {
                QListWidgetItem* pListWidgetItem = new QListWidgetItem(ui->list_contacts);
                ui->list_contacts->addItem(pListWidgetItem);
                AccountCell* pAccountItem = new AccountCell(TCTT_ALL, pContact, this);
                pListWidgetItem->setSizeHint(QSize(332, 64));
                ui->list_contacts->setItemWidget(pListWidgetItem, pAccountItem);

i added only these lines of code how do i set scrollbar even i haven't taken scrollbar ,automatically it shows when more items are added ??

J.Hilk

hi @Dimple

this is you problem

ui->list_contacts->clear();

you completely clear the listwidget and add all items anew, and as a result of that the scrollbar gets reset each time you call updateContactList

either work with add and remove item or save the scrollbar position before calling clear and set it after wards.

int tempPos = ui->list_contacts->verticalScrollBar()->value();

ui->list_contacts->clear();
....
...

ui->list_contacts->verticalScrollBar()->setValue(tempPos);

Dimple

@J-Hilk
Thanks for ur solution ,,issue fixed

Dimple

@J-Hilk
just now i noticed that onemore issue i'am getting as u said if i'am going to add code what happens Now we are refreshing all list items,So, I wanted to update only changed items, not all,
With current solution, i can go now but if cell count is over than 100, we can feel small delay , so correct solution is to update only changed cells??

J.Hilk

@Dimple said in ScrollBar isn't placing at the current position:

With current solution, i can go now but if cell count is over than 100, we can feel small delay , so correct solution is to update only changed cells??

yes, but that's also more a bandaid as well. For a model that encompasses so many potential items, I would suggest looking into QListView and a proper Delegate&Model for it. Will make your live easier in the long run.

Dimple

@J-Hilk thanks for ur reply
u mean instead of QListWidget to use QListView ?? i didn't get ??

J.Hilk

@Dimple

Yes, QListWidgets is a specialized form of a QListView.

I you move from from QListWidget to QListView, you'll have to implement your own (data)model and delegate.

It is more to write/code but will be faster and easier to manage, than using QListWidget and addItem(QListWidgetItem *)

Dimple

can't i do using QListWidget to update only changed cells ?

J.Hilk

@Dimple
sure you can, QListWidget offers you functions to remove add individual Items
for example: http://doc.qt.io/qt-5/qlistwidget.html#takeItem

I'm just saying, the better way would be to switch to a QListView and a proper model. I know I'm often guilty of using QListWidget myself, as it's easier and faster to create something visual.