In multithreading, the data received by the serial port is incorrect

HermesSJC

I use STM32F407 send data by asynchronous serial send data to the upper computer and the operating system was Windows 10 x64.
the code on STM32F407 is as follows:

while(1)
{
  printf("J%.3f",J);
  HAL_Delay(15);
  printf("W%.3f",W);
  HAL_Delay(15);
  printf("G%.3f",G);
  HAL_Delay(15);
  printf("V%.3f",V);
  printf("R%.3f\r\n",R);
  HAL_Delay(40);
  printf("A101N303\r\n");
  HAL_Delay(100);
  J += 0.001;
  W += 0.001;
  G += 0.001;
}

And I use the api QSerialPort::readAll to read data.the code is as follows

void MSerialThread::run()
{
    QByteArray receiveData = "";
    QString readData = "";
    //串口如果打开就永远进行这个线程
    while(serialPort.isOpen())
    {
        //读取串口缓冲区的数据
        receiveData = serialPort.readAll();

        //添加倒string类型的末尾
        readData.append(receiveData);

        //清除临时数据
        receiveData.clear();

        //如果收到 0x0a 0x0d 就说明到底了
        if(readData.endsWith("\r\n"))
        {
            //发送数据
            emit readEnd(readData);

            qDebug() << readData;

            //清除接收到的数据
            readData.clear();
        }
    }
}

but sometime I receive the data such as "J1.123W1.2332V1.123R1.123\r\n" instead of "J1.123W1.123G1.123V1.123R1.123\r\n" even "A101N303\r\nJ1.123W1.2332V1.123R1.123\r\n"

I need some help

SGaist

Hi and welcome to devnet,

Why not use Qt's asynchronous nature rather that spinning a while loop without any really breaking conditions ?

geronSEU

This post is deleted!

kuzulis

I'm surprised, that your application work at all (it should not work) and not has been crashed. :)

PS: Don't use the threads if you not sure how to use it. Just use signals/slots from a main application thread (as advised before).

HermesSJC

@kuzulis But,these codes refer to the official example "Blocking Slave Example"

HermesSJC

@SGaist excuse me , do you mean that I 'd better use signal and slot?

kuzulis

@HermesSJC said in In multithreading, the data received by the serial port is incorrect:

@kuzulis But,these codes refer to the official example "Blocking Slave Example"

Please compare that "official examples" code to your provided code and find differences.

HermesSJC

@kuzulis said in In multithreading, the data received by the serial port is incorrect:

@HermesSJC said in In multithreading, the data received by the serial port is incorrect:

@kuzulis But,these codes refer to the official example "Blocking Slave Example"

Please compare that "official examples" code to your provided code and find differences.

I know the differences between the "official examples" and the code I wrote. Maybe because my transmission speed and frequency are fast, when using the signal "readyRead", it will loss data when running about three minutes, so I try using child threading to read data from serial port.

aha_1980

hi @HermesSJC,

can you please define "fast transmission speed"?

serial ports are rather slow, but as the data is buffered, you should not lose a byte when using readyRead.

also, which platform and Qt verson is this?

regards

mrdebug

Hi. I love to write multithreaded applications to manage ioT devices and others.
So there are devices that send data slowly (for example the IoT devices) but others could send data using serial port at 1 Mb/s and I have to manage them simultineously.
Each connection has got a thread and no one byte was missing.
You should review your code.

HermesSJC

@aha_1980 said in In multithreading, the data received by the serial port is incorrect:

hi @HermesSJC,

can you please define "fast transmission speed"?

serial ports are rather slow, but as the data is buffered, you should not lose a byte when using readyRead.

also, which platform and Qt verson is this?

regards

I 'm sorry that I do loss data when using the signal readyRead (Maybe my data processing isn't perfect)
my platform is based on win10 x64 and I use qt5.9.6 (msvc2015 x64) .
as the code shown in the stm32 , I send data about from 5Hz to 60Hz and the band rate is 115200.I have tried sending data about 2Hz,the problem of losing data will be gone.(sorry my mother language is not English, so maybe you will free strange when reading my words)

HermesSJC

@mrdebug said in In multithreading, the data received by the serial port is incorrect:

Hi. I love to write multithreaded applications to manage ioT devices and others.
So there are devices that send data slowly (for example the IoT devices) but others could send data using serial port at 1 Mb/s and I have to manage them simultineously.
Each connection has got a thread and no one byte was missing.
You should review your code.

I have shown the code on my slave computer at the beginning of the question which is based on STM32F407 and I ' sure that the configuration of register has no problem. I think I have no problem after reviewing it.

mrdebug

Please try

while (true) {
    if (SerialPort.waitForReadyRead(100)) {
        while (SerialPort.canReadLine()) qDebug() << SerialPort.readLine();
    }
}

Now you can work on the already ready buffer obtained from "SerialPort.readLine();"