fail to use Q_OBJECT Macro in CMake Project

SGaist

Hi,

Did you already took a look at the CMake Manual from Qt's documentation ?

Sewing

I did, but without being able to infer any conclusive hints from the article towards a solution for my problem

VRonin

The problem is not CMake:

@Sewing said in fail to use Q_OBJECT Macro in CMake Project:

mainWindow.cpp: The file contains a Q_OBJECT macro

from http://doc.qt.io/qt-5/moc.html

The moc tool reads a C++ header file.

Did you declare a class with Q_OBJECT in a .cpp file? if so either yo do as the compiler tells you and #include "mainWindow.moc" (this file name might change depending on how moc gets invoked) at the end of the file or, as I would recommend, move it into a header

Sewing

Mh difficult since I employ the pimpl idiom in which the nested implementation class in defined entirely within the source file

SGaist

Then move the private declaration part in its own header that you only include in the implementation part.

Note that your MainWindow implementation looks a bit convoluted, you might be over-engineering some things.

Sewing

thank you for the help.

you mean cuz of using pimpl? this is just a minimal example and my intention was, to keep the public interface of mainwindow.cpp quite clean and readable

VRonin

@Sewing said in fail to use Q_OBJECT Macro in CMake Project:

pimpl idiom in which the nested implementation class in defined entirely within the source file

You can move it into a header file, Qt does it all the time, they use _p.h suffix to mark private headers. For example: QDateTimePrivate

Sewing

so if I understood correctly, the reason of having to do this is that the Q_OBJECT Macro has to be defined in the header file instead of the source file?

and after doing so, is the line

set_target_properties(${PROJECT_NAME} PROPERTIES AUTOMOC TRUE)

sufficient for invoking the MOC in my CMakeLists file?

VRonin

@SGaist said in fail to use Q_OBJECT Macro in CMake Project:

Did you already took a look at the CMake Manual from Qt's documentation ?

@Sewing said in fail to use Q_OBJECT Macro in CMake Project:

I did

from http://doc.qt.io/qt-5/cmake-manual.html:

# Instruct CMake to run moc automatically when needed.
set(CMAKE_AUTOMOC ON)

Sewing

I read that, just thought variables in CMake are old-style while target_properties are the modern way to handle things

VRonin

I heard opposing arguments to that when it comes to moc/rcc/uic. Personally, I use the set(CMAKE_AUTOMOC ON) way