Set QVector data to QTreeWidgetItem

[jsulm]

@Cobra91151 What do you expect it to return?
Why do you use data()?
Just do

void Test::setAppData(QVector<AppsData> data)
{
    for (AppsData element : data)
        qDebug() << element.name;
}

This will print out names of all elements in the vector. Alternative:

void Test::setAppData(QVector<AppsData> data)
{
    for (int i = 0; i < data.size(); ++i)
        qDebug() << data[i].name;
}

[jsulm]

@Cobra91151

void Test::setAppData(QVector<AppsData> data)
{
    for (int i = 0; i < data.count(); i++) {
        allApplicationsItem = new QTreeWidgetItem(allApplications);
        allApplicationsItem->setText(0, data[i].name); // I assume you want to set name, is this correct? You cannot just use the whole struct as you need to pass a string
    }
}

[Cobra91151]

@jsulm

Thanks. But I have figured it out how to retrieve data from QVector structure. The only problem is, it sets only one row. I have checked loop and it sets only one.

Code:

    AppsData appsData;
    QVector<AppsData> dataVector;

    for (QString key : allCurrentUserKeys) {
         if (!key.isEmpty()) {
            if (key.contains("DisplayIcon") && registryKeyCurrentUser.value(key).toString() != "") {
                displayIcon = registryKeyCurrentUser.value(key).toString();

                if (displayIcon.contains("\"")) {
                    displayIconSplitted = displayIcon.split("\"");
                    iconSplittedData = displayIconSplitted.value(displayIconSplitted.length() - 2);
                    iconFile = iconSplittedData;
                } else if (displayIcon.contains(",")) {
                    displayIconSplitted = displayIcon.split(",");
                    iconSplittedData = displayIconSplitted.value(displayIconSplitted.length() - 2);
                    iconFile = iconSplittedData;
                } else {
                    iconFile = displayIcon;
                }

                if (iconFile.contains(".ico")) {
                    programIcon = QIcon(iconFile);
                } else {
                    QFileInfo fileInfo(iconFile);
                    programIcon = fileIconProvider.icon(fileInfo);
                }

                appsData.icon = programIcon;
                //programIcon = setDefaultIcon();
            }

            if (key.contains("DisplayName") && registryKeyCurrentUser.value(key).toString() != "") {
                displayName = registryKeyCurrentUser.value(key).toString();
                appsData.name = displayName;
                //emit appData(programIcon, displayName);
            }
        }
    }

    dataVector.push_back(appsData);
    emit appData(dataVector);

For example there are 5 entries in registry but only latest is set to a QVector structure. How to get all registry entries?

[jsulm]

@Cobra91151 said in Set QVector data to QTreeWidgetItem:

dataVector.push_back(appsData);

Shouldn't

dataVector.push_back(appsData);

be inside the loop?

    QVector<AppsData> dataVector;

    for (QString key : allCurrentUserKeys) {
         AppsData appsData;
         if (!key.isEmpty()) {
            if (key.contains("DisplayIcon") && registryKeyCurrentUser.value(key).toString() != "") {
                displayIcon = registryKeyCurrentUser.value(key).toString();

                if (displayIcon.contains("\"")) {
                    displayIconSplitted = displayIcon.split("\"");
                    iconSplittedData = displayIconSplitted.value(displayIconSplitted.length() - 2);
                    iconFile = iconSplittedData;
                } else if (displayIcon.contains(",")) {
                    displayIconSplitted = displayIcon.split(",");
                    iconSplittedData = displayIconSplitted.value(displayIconSplitted.length() - 2);
                    iconFile = iconSplittedData;
                } else {
                    iconFile = displayIcon;
                }

                if (iconFile.contains(".ico")) {
                    programIcon = QIcon(iconFile);
                } else {
                    QFileInfo fileInfo(iconFile);
                    programIcon = fileIconProvider.icon(fileInfo);
                }

                appsData.icon = programIcon;
                //programIcon = setDefaultIcon();
            }

            if (key.contains("DisplayName") && registryKeyCurrentUser.value(key).toString() != "") {
                displayName = registryKeyCurrentUser.value(key).toString();
                appsData.name = displayName;
                //emit appData(programIcon, displayName);
            }
        }
        dataVector.push_back(appsData);
    }

    
    emit appData(dataVector);

[Cobra91151]

@jsulm

It should be, I have tried it also, but it returns multiple the same values.

Screenshot:

[jsulm]

@Cobra91151 You should move

dataVector.push_back(appsData);

into

if (!key.isEmpty()) {
            if (key.contains("DisplayIcon") && registryKeyCurrentUser.value(key).toString() != "") {

So

QVector<AppsData> dataVector;

    for (QString key : allCurrentUserKeys) {
         AppsData appsData;
         if (!key.isEmpty()) {
            if (key.contains("DisplayIcon") && registryKeyCurrentUser.value(key).toString() != "") {
                displayIcon = registryKeyCurrentUser.value(key).toString();

                if (displayIcon.contains("\"")) {
                    displayIconSplitted = displayIcon.split("\"");
                    iconSplittedData = displayIconSplitted.value(displayIconSplitted.length() - 2);
                    iconFile = iconSplittedData;
                } else if (displayIcon.contains(",")) {
                    displayIconSplitted = displayIcon.split(",");
                    iconSplittedData = displayIconSplitted.value(displayIconSplitted.length() - 2);
                    iconFile = iconSplittedData;
                } else {
                    iconFile = displayIcon;
                }

                if (iconFile.contains(".ico")) {
                    programIcon = QIcon(iconFile);
                } else {
                    QFileInfo fileInfo(iconFile);
                    programIcon = fileIconProvider.icon(fileInfo);
                }

                appsData.icon = programIcon;
                //programIcon = setDefaultIcon();
               if (key.contains("DisplayName") && registryKeyCurrentUser.value(key).toString() != "") {
                displayName = registryKeyCurrentUser.value(key).toString();
                appsData.name = displayName;
                //emit appData(programIcon, displayName);
              }
              dataVector.push_back(appsData);
            }
       }
    }

    emit appData(dataVector);

[Cobra91151]

@jsulm

Yes, but the apps data will not be in appropriate columns.

Screenshot:

Code:

for (int i = 0; i < vectorData.count(); i++) {
      allApplicationsItem = new QTreeWidgetItem(allApplications);
      allApplicationsItem->setIcon(0, vectorData[i].icon);
      allApplicationsItem->setText(0, vectorData[i].name);
      allApplicationsItem->setText(1, vectorData[i].version);
      allApplicationsItem->setText(2, vectorData[i].publisher);
      allApplicationsItem->setText(3, vectorData[i].installLocation);
      allApplicationsItem->setText(4, vectorData[i].uninstallLocation);
}

[jsulm]

@Cobra91151 It looks like you don't get icons for all apps - you need to fix your code, I currently don't have time for this.

[Cobra91151]

@jsulm

In this case I have all apps icons but we dataVector.push_back(appsData); setting in if (key.contains("DisplayName") or icons key. That's why this issue, one first row is empty.

I have changed to dataVector.push_back(appsData); on the last check:

if (key.contains("UninstallString") && registryKeyCurrentUser.value(key).toString() != "" && !key.contains("QuietUninstallString")) {
    uninstallLocation = registryKeyCurrentUser.value(key).toString();
    appsData.uninstallLocation = uninstallLocation;
    dataVector.push_back(appsData);
}

And now it setting all data properly, but I will check for other registry keys.

Screenshot (HKEY_CURRENT_USER):

[Cobra91151]

The same issue with icons still exists. It's time to change code to Win API and try to fix this issue.