Best data type to store Financial/Monetary Values?

Chris Hennes

@binsoii said in Best data type to store Financial/Monetary Values?:

But i will need to create reports down to at least 6 decimal places.

If you really have a need to generate six decimal places regardless of the magnitude of the number you cannot use a floating point number for it, as @kshegunov mentions. By construction you have a system with a fixed decimal restriction. To be honest, my advice to you is to stay far away from developing this type of software until you are intimately familiar with the details of how computers store and operate on numbers.

kshegunov

It's probably feasible to get away with a 34.30 fixed point signed int64, which would give about 7-8 significant decimal digits after the dot with range of a few billion. However it gets really tricky when you need to provide even some basic functions - logarithms, (square) root(s), powers for such a representation.

To be honest, my advice to you is to stay far away from developing this type of software until you are intimately familiar with the details of how computers store and operate on numbers.

That's somewhat funny (in an ironic way), because this is probably one of the most complex problems one can encounter in programming, so it's really hard to be intimately familiar. :)

Chris Hennes

@kshegunov said in Best data type to store Financial/Monetary Values?:

this is probably one of the most complex problems one can encounter in programming, so it's really hard to be intimately familiar. :)

Absolutely true! I consider myself quite well-versed in floating point numbers (at least, of the IEEE 754 flavor), and I wouldn't trust myself to work on a financial system with these requirements.

Chris Kawa

Don't use floating point types for financial data and don't re-invent a wheel implementing fixed point functions.
There are libraries for this. For example: fixed_point - CppCon talk: John McFarlane “fixed_point"
There are more if you don't like this one, just google it. But don't try to do it yourself. You'll just waste time and re-make the same mistakes people already did and fixed.

binsoii

@Chris-Kawa Thanks! i'm not trying to re-invent the wheel by the way. i just want to use the existing ones already available and easy to use, just like the System.Decimal in C# .Net sitting there ready to be taken. Why there isn't just like this already available in Qt!? :( How could this amazing framework don't have a simple thing to address this. and i really don't like the idea of using third party libraries just for this case. (I don't even know where to start integrating the example you gave, i'm really new to Qt)

Cheers!

binsoii

@Chris-Hennes we already have an existing system, using Django and Angular to accomplish this. we used Decimal in postgresql and accounting.js library in the front end.

VRonin

@Chris-Hennes said in Best data type to store Financial/Monetary Values?:

To be honest, my advice to you is to stay far away from developing this type of software until you are intimately familiar with the details of how computers store and operate on numbers.

Strongly disagree. I don't know 10% of what's necessary to understand end to end encrypted communication but I use OpenSSL as I trust them to know what's necessary. Division of cognitive labor is what made humanity great. A reliable enough library (like boost) is all you need.

@binsoii said in Best data type to store Financial/Monetary Values?:

Why there isn't just like this already available in Qt!?

Qt integrates a lot more than you'd expect by a framework born to be a UI. Sometimes even the functionality integrated in Qt is not at par with what's available externally (see FTP support for an example).

@binsoii said in Best data type to store Financial/Monetary Values?:

and i really don't like the idea of using third party libraries just for this case

My suggestion involves using a library (boost) that is much closer to the standard than Qt is. I would not consider boost code quality inferior to Qt's in any aspect. <exageration>I don't think there's a C++ programmer that doesn't have boost ready to be used on his/her machine</exageration>.

Bottom Line:
if you are concerned with precision use boost::multiprecision::mpf_float_100 100 decimals (base10) precision is more that I can imagine anyone needing (you can still increase it arbitrarily btw, using boost::multiprecision::number<gmp_float<N> > where N is the number of base10 decimals precision you want)

Chris Hennes

@VRonin said in Best data type to store Financial/Monetary Values?:

Strongly disagree. I don't know 10% of what's necessary to understand end to end encrypted communication but I use OpenSSL as I trust them to know what's necessary. Division of cognitive labor is what made humanity great. A reliable enough library (like boost) is all you need.

In most cases you and I are in complete agreement on this point. The problem with finance is that the question isn't just reliability, it's regulation. In particular, does the regulatory environment this software is going to be used in specify when and how the rounding must take place? There are usually very, very specific requirements on software that handles financial transactions.

binsoii

@VRonin

if you are concerned with precision use boost::multiprecision::mpf_float_100 100 decimals (base10) precision is more that I can imagine anyone needing (you can still increase it arbitrarily btw, using boost::multiprecision::number<gmp_float<N> > where N is the number of base10 decimals precision you want)

Thanks a lot! boost::precision seems to be the best choice for my need. i will implement this and give an update once its done. PS (I don't where to start on how to use integrate/install this, i guess i have a lot studying to do. :D)

VRonin

@binsoii said in Best data type to store Financial/Monetary Values?:

I don't where to start on how to use integrate/install this, i guess i have a lot studying to do.

mpf_float_* only works on GNU compilers and depends on an external library.

You can use cpp_dec_float_100 it's twice as slow as mpf_float but all you have to do is download boost, add the path of booth in the INCLUDE += part of the .pro file and add #include <boost/multiprecision/cpp_dec_float.hpp> at the top of your source file

kshegunov

You do understand the problem here is not with the floating point precision, but it's with the floating point itself, right?
Floating point operations are exact to at most 1 epsilon which is the maximum relative difference between the two numbers. RELATIVE. I can even repeat it if it will help.

Suppose you are working on a 10-base floating point computer and you have 2 digits for mantissa and 1 digit for exponent. The absolute difference between two numbers with zero exponent is 0.01 by construction. Now, what is the absolute difference between two numbers with exponent 2? Well, it is 0.01 * 100 = 1. So you trade off your absolute precision for dynamic range. For most intents and purposes this is just perfectly fine!
When you need to do accounting, however, there are different regulations in place, and this trade-off is unacceptable! Your ABSOLUTE precision, can't be less than a specific amount, so that's why people use fixed-point, because the epsilon there is both relative and absolute measurement of the accuracy of an operation/number.

VRonin

@kshegunov

I'm not trying to be a smarta55, I'm honestly asking out of ignorance

Can You show me an example of operation that can compromise say the 50th decimal of a boost::multiprecision::cpp_dec_float_100 ?

kshegunov

@VRonin said in Best data type to store Financial/Monetary Values?:

You show me an example of operation that can compromise say the 50th decimal of a boost::multiprecision::cpp_dec_float_100 ?

Of course not. :)
That is, unless you're about to keep numbers in the magnitude of about 10 to the 40th power. We have no physical, tangible quantity that spans those ranges. Or to put some context in, as I'm a physicist after all:

the approximate diameter of the milky way (our galaxy) is in the magnitude 10^18 km, and has about 10^11 stars
the total number of atoms in the universe is estimated to about 10^80
we know physical constants with limited precision, but let's take one of the best known - the fine-structure constant (it's the exact number behind the atomic clock), so we know that with a certainty of about 10^-9.

Now look back and tell me, do you need 50 decimal places really? The point is there's already established way to represent numbers for this specific purpose, and there are regulations in place (I mean, really, they've written down in law how rounding should take place). Also note 50 decimal places would translate to about 150 bits (~18 bytes) for the mantissa alone ...!

As Chris said, it's been done, it's not new, it's known. So why would you venture into the depths of arbitrary precision arithmetic (i.e. brute force the solution) to combat a problem that's been solved way back?

jronald

Why not use cent as money unit and use int64?

boost::multiprecision seems a little complex, personally I don't like the style of boost/STL, reason:

syntax is not clear, even worse when considering the implementation
speed is not extremely fast, for example, recently I've checked comparison of string formatting mechanisms between C and C++, the C style is more easy to use and 2x faster than C++ style. BTW, Qt and C# adopt the C way.

tham

@jronald said in Best data type to store Financial/Monetary Values?:

Why not use cent as money unit and use int64?

boost::multiprecision seems a little complex, personally I don't like the style of boost/STL, reason:

syntax is not clear, even worse when considering the implementation

I think this is based on personal taste and skills, boost and many part of the stl leverage lots of generic programming and TMP, if you are not familiar with basic of generic programming, it is natural for you to find the syntax is weird.

About implementation, those library are not for average c++ programmer to maintain but for those programmers who are smart and love c++. As a season c++ programmer, I will expect they know and familiar with stl, basic generic programming and TMP.

Unless for me, api and the idea of stl is brilliant, it is master piece of a genius. Quality of boost are very high too.

speed is not extremely fast, for example, recently I've checked comparison of string formatting mechanisms between C and C++, the C style is more easy to use and 2x faster than C++ style. BTW, Qt and C# adopt the C way.

This depends on the purpose of the design philosophy, if you are talking about std::stringstream or boost::format, usually they are slower or much slower than c library(especially boost format), after all their main purpose are not blazing fast. This do not mean they are bad or poor, but they have different design purpose.

Do c api provide you type safety?Do c api manage your memory dynamic?Do c api provide you extension flexibility as std::stream provided? It is like compare apple with orange

Evidence

1 : std::sort is much faster than qsort of c, and I believe none of the c library can provide fast, light weight yet extensible algorithms api like stl provide(std::sort, std::transform, std::iota, std::set_difference etc), c do not have the expressive power of c++ provided. c++ can design almost any api c allowed to do, but there are many c++ api cannot be done by c
2 : boost spirit is very fast, even faster than c functions if you use it right and compile your codes on modern compiler

Both of the examples leverage generic programming and TMP, but their performance are great or superb, even better than standard c library.

If speed is what matter most, we are still writing machine codes today.

jronald

@tham
qsort is slower, but it can rewritten while keeping its interface unchanged.
Compare Net Library and STL/boost, the interface of C# is better than that of STL/boost, though C# is not good at low level things.

kshegunov

@tham said in Best data type to store Financial/Monetary Values?:

Thread carefully there.

Do c api provide you type safety?

It does, no less than the type-safety C++ provides.

Do c api manage your memory dynamic?

It does, the infamous malloc/realloc and free.

Do c api provide you extension flexibility as std::stream provided?

This doesn't make much sense, as std::stream is something STL specific. But there are libraries I'm sure, that provide the same functionality through a C API.

std::sort is much faster than qsort of c

Can you prove that?

c++ can design almost any api c allowed to do, but there are many c++ api cannot be done by c

Show me! That statement is leading and simply not true.

Both of the examples leverage generic programming and TMP, but their performance are great or superb, even better than standard c library.

Once again, you will have to prove that claim. You can't just drop the bomb and not follow up.

tham

@kshegunov said in Best data type to store Financial/Monetary Values?:

@tham said in Best data type to store Financial/Monetary Values?:

Do c api provide you type safety? Do c api manage your memory dynamic?Do c api provide you extension flexibility as std::stream provided?

Sorry, I did not state if clear, I was comparing standard c++ and standard c libraries(scanf, printf, strlen, strcpy, memcpy etc), the answer is no, standard c libraries never provide stream libraries like std::stream which provide type safe, manage memory automatic and extensible

example :

std::string line;
std::string contents;
while(std::getline(file, line)){
    std::istringstream iss(line);
    int a, b;
    if (!(iss >> a >> b>>contents)) { break; } // error
    process_file(a,b,contents);
}

Try to do it with c standard library without worry about memory leak, buffer overread(do you still remember heart bleed ?), type safe

@kshegunov said in Best data type to store Financial/Monetary Values?:

std::sort is much faster than qsort of c

Can you prove that?

I think this is common sense for any experiences c++ programmers(untrue for someone only know c with classes)?More than one c++ gurus mentioned this truth

Performance of qsort vs std::sort?

About boost spirit, see this post

@kshegunov said in Best data type to store Financial/Monetary Values?:

Show me! That statement is leading and simply not true.

It is hard to find a c api cannot be done by c++, but it is very easy to come up simple api to prove that c do not have the ability to design the api c++ able to do, this is obvious because c++ offer much more features than c.

All of the design should not pollute global scope

1 : Design something like std::sort by c, which

a : faster than qsort
b : type safe
c : generic and extensible, able to sort any kind of data
d : it at most only need three parameters

With c, I cannot satisfy all of the requirements by one api, but it is piece of cake by c++.

2 : Design resource handle like std::unique_ptr

a : light weight, as light as raw pointer
b : can handle almost any resource
c : extensible, able to determine how to clean up the resource
d : api must be as easy to use as std::unique_ptr
e : cannot copy but able to move

example :

monster *monster_a = new slime(30, slime_a)
//do something
delete monster_a;
montser_a = nullptr;

//with unique pointer
auto monster_a = std::make_unique<slime>(30, "slime_a");
//do something
//forget it because monster_a will kill itself after it leave the scope

3 : Design a function which could calculate the sum of value at compile time and runtime by one and single api

constexpr long long addition(long long num)
{
    long long sum = 0;
    for (long long i = 0; i <= num; i++)
    {
        sum += i;
    }

    return sum;
}

//.......
addition(50000); //calculate the sum at compile time
long long num = 0;
std::cin>>num; //type safe :)
addition(num); //calculate the sum at runtime

4 : Make sure the double value you declare is a compile time constant(100%) without the risk of scope polluting

//ultra simple and easy to read with c++
constexpr double PI = 3.141592653589793;

And so on, I cannot list them all. I believe similar examples and skills I mentioned are basic and mentioned in great c++ textbook.

Every c programmer I met who bash c++ harsh never really spend their times to study c++, yet everyone of them pretend they know c++ very well, I always want to say f**k to them. It is impossible for c programmer to use c++ efficiently if they always refuse to spend their time to study a great c++ textbook(I know this because I learned c before c++). c++ is not a language you can treat it seriously, but a language you must treat it seriously, you cannot use it wise if you do not spend your time to study how are those gurus write their codes.

tham

@jronald said in Best data type to store Financial/Monetary Values?:

qsort is slower, but it can rewritten while keeping its interface unchanged.

If you are talking about ABI, it is true, one of the defects of template is it is hard to maintain ABI compatibility

Compare Net Library and STL/boost, the interface of C# is better than that of STL/boost, though C# is not good at low level things.

I am not familiar with c# so I cannot give opinion on this part, but I would not surprise if c# offer lots of good libraries, after all it is maintained by microsoft

kshegunov

@tham said in Best data type to store Financial/Monetary Values?:

yet everyone of them pretend they know c++ very well, I always want to say f**k to them

Okay, I'll take this as a sign I should stop arguing. Have a nice day.