How to make a progress bar for downloads?

[Armin]

```

connect(manager , SIGNAL(finished(QNetworkReply*)) , this , SLOT(replyFinished(QNetworkReply*)));
manager->get(QNetworkRequest(QUrl(downloadlink)));

void MainWindow::replyFinished(QNetworkReply *reply)
{
connect(reply, &QNetworkReply::downloadProgress,this, &MainWindow:: progressbar);
.
.
.
.

Where i did wrong?

[SGaist]

Hi,

Aren't you connecting the downloadProgress signal once the reply is finished ? By finished it means that the query has completed so you are trying to get the download information after the download already happened.

[Armin]

@SGaist Thanks

    QNetworkAccessManager *manager = new QNetworkAccessManager(this);
    QNetworkReply *reply;
    connect(manager , SIGNAL(downloadProgress(qint64,qint64)) , this , SLOT(progressbar(qint64,qint64)));
    connect(manager , SIGNAL(finished(QNetworkReply*)) , this , SLOT(replyFinished(QNetworkReply*)));
    manager->get(QNetworkRequest(QUrl(downloadlink)));

What i do?

[SGaist]

Meaning ?

[Armin]

@SGaist Where i did wrong in that code?

[SGaist]

Since it's outside any context the only thing that can be said is that reply is not used and that you are likely going to have lots of memory eaten if you create a new QNetworkAccessManager per query and not deleting it afterward.

[J.Hilk]

@Armin
hi,

in your sample, not the QNetworkAccessManager has the downloadProgress Signal, but the QNetworkReply

->

QNetworkAccessManager *manager = new QNetworkAccessManager(this);
    QNetworkReply *reply = manager->get(QNetworkRequest(QUrl(downloadlink)));
    connect(reply, SIGNAL(downloadProgress(qint64,qint64)) , this , SLOT(progressbar(qint64,qint64)));
    connect(manager , SIGNAL(finished(QNetworkReply*)) , this , SLOT(replyFinished(QNetworkReply*)));
    
``

[SGaist]

To add to @J-Hilk which got the wrong connection I missed, you should provide more context on how you are using that code in your application.

[Armin]

Thanks for all
My problem solved.

[SGaist]

What was the problem ?